From: Andrey Konovalov <andreyknvl@gmail.com>
To: Sabyrzhan Tasbolatov <snovitoll@gmail.com>
Cc: ryabinin.a.a@gmail.com, elver@google.com, arnd@kernel.org,
glider@google.com, dvyukov@google.com,
vincenzo.frascino@arm.com, akpm@linux-foundation.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kasan: change kasan_atomics kunit test as KUNIT_CASE_SLOW
Date: Sat, 2 Nov 2024 00:38:36 +0100 [thread overview]
Message-ID: <CA+fCnZd9V8okaozn-LBA3w=TsuVbTR=4Hey+w1+_CRDVQV_XEA@mail.gmail.com> (raw)
In-Reply-To: <20241101184011.3369247-3-snovitoll@gmail.com>
On Fri, Nov 1, 2024 at 7:40 PM Sabyrzhan Tasbolatov <snovitoll@gmail.com> wrote:
>
> During running KASAN Kunit tests with CONFIG_KASAN enabled, the
> following "warning" is reported by kunit framework:
>
> # kasan_atomics: Test should be marked slow (runtime: 2.604703115s)
>
> It took 2.6 seconds on my PC (Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz),
> apparently, due to multiple atomic checks in kasan_atomics_helper().
>
> Let's mark it with KUNIT_CASE_SLOW which reports now as:
>
> # kasan_atomics.speed: slow
>
> Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@gmail.com>
> ---
> mm/kasan/kasan_test_c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
> index 3e495c09342e..3946fc89a979 100644
> --- a/mm/kasan/kasan_test_c.c
> +++ b/mm/kasan/kasan_test_c.c
> @@ -2020,7 +2020,7 @@ static struct kunit_case kasan_kunit_test_cases[] = {
> KUNIT_CASE(kasan_strings),
> KUNIT_CASE(kasan_bitops_generic),
> KUNIT_CASE(kasan_bitops_tags),
> - KUNIT_CASE(kasan_atomics),
> + KUNIT_CASE_SLOW(kasan_atomics),
> KUNIT_CASE(vmalloc_helpers_tags),
> KUNIT_CASE(vmalloc_oob),
> KUNIT_CASE(vmap_tags),
> --
> 2.34.1
>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
prev parent reply other threads:[~2024-11-01 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 18:40 [PATCH 0/2] kasan: few improvements on kunit tests Sabyrzhan Tasbolatov
2024-11-01 18:40 ` [PATCH 1/2] kasan: use EXPORT_SYMBOL_IF_KUNIT to export symbols Sabyrzhan Tasbolatov
2024-11-01 23:38 ` Andrey Konovalov
2024-11-01 18:40 ` [PATCH 2/2] kasan: change kasan_atomics kunit test as KUNIT_CASE_SLOW Sabyrzhan Tasbolatov
2024-11-01 23:38 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+fCnZd9V8okaozn-LBA3w=TsuVbTR=4Hey+w1+_CRDVQV_XEA@mail.gmail.com' \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=snovitoll@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox