From: Andrey Konovalov <andreyknvl@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Sabyrzhan Tasbolatov <snovitoll@gmail.com>,
Marco Elver <elver@google.com>,
Nihar Chaithanya <niharchaithanya@gmail.com>,
Jann Horn <jannh@google.com>,
Peter Zijlstra <peterz@infradead.org>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] mm/kasan: add module decription
Date: Mon, 24 Mar 2025 23:00:08 +0100 [thread overview]
Message-ID: <CA+fCnZd6uLYoKZwwHfBo72C0QLV=pv1feEmB2mMaqP9HKKeo9A@mail.gmail.com> (raw)
In-Reply-To: <20250324173242.1501003-9-arnd@kernel.org>
On Mon, Mar 24, 2025 at 6:34 PM 'Arnd Bergmann' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Modules without a description now cause a warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in mm/kasan/kasan_test.o
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> mm/kasan/kasan_test_c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
> index 59d673400085..710684ffe302 100644
> --- a/mm/kasan/kasan_test_c.c
> +++ b/mm/kasan/kasan_test_c.c
> @@ -2130,4 +2130,5 @@ static struct kunit_suite kasan_kunit_test_suite = {
>
> kunit_test_suite(kasan_kunit_test_suite);
>
> +MODULE_DESCRIPTION("kunit test case for kasan");
> MODULE_LICENSE("GPL");
> --
> 2.39.5
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
But just in case you end up sending a v2, let's change the text to
"KUnit tests for checking KASAN bug-detection capabilities".
Thank you!
prev parent reply other threads:[~2025-03-24 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250324173242.1501003-1-arnd@kernel.org>
2025-03-24 17:32 ` Arnd Bergmann
2025-03-24 22:00 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+fCnZd6uLYoKZwwHfBo72C0QLV=pv1feEmB2mMaqP9HKKeo9A@mail.gmail.com' \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=niharchaithanya@gmail.com \
--cc=peterz@infradead.org \
--cc=ryabinin.a.a@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=snovitoll@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox