From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CBAC4332F for ; Wed, 13 Dec 2023 23:43:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 127B36B0312; Wed, 13 Dec 2023 18:43:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D80D6B0313; Wed, 13 Dec 2023 18:43:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBAE56B0316; Wed, 13 Dec 2023 18:42:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D86786B0312 for ; Wed, 13 Dec 2023 18:42:59 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B52E6A0BFB for ; Wed, 13 Dec 2023 23:42:59 +0000 (UTC) X-FDA: 81563422878.09.83129A5 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by imf17.hostedemail.com (Postfix) with ESMTP id F1B404000B for ; Wed, 13 Dec 2023 23:42:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P6lTVDu1; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.161.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702510978; a=rsa-sha256; cv=none; b=oIFDjeW/lSU453RWtw/KmHcY5kGh+RDQRdujztFtzBu8rRqPyVQ4CobLufmF33Uxh8f6rg pLH4lCfVT2hPOeEgO8r/RtvlZ+sLtrjO+cOpvJ1MlJLRyGKE2EzatuznAYWZdkY8KzhhRr yqD1Hiuf+ohb3iAuB7eJRB74eeyJqVI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P6lTVDu1; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.161.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702510978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=irtsiUCUylZGPtSeScUGgZwEzBoaabXmknnY3lf14ec=; b=3TFlC8cwGWRhGSVgQSJPraJPT0QzNQR7ro/vRUft2FTSMD4Y+FbPlj7afcwV+FeqyOqxt6 cSHrkOOKjk7XXv+CIf3tTGokDsbOFXOdY8Zaa02UA1+EVeDotjZg90dim6TKFqTlMErU7p dAxxuPfu9p/ONaRPr3sR6uwpuiUbK0g= Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-590bb31ccf5so3324544eaf.3 for ; Wed, 13 Dec 2023 15:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702510977; x=1703115777; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=irtsiUCUylZGPtSeScUGgZwEzBoaabXmknnY3lf14ec=; b=P6lTVDu1n/zNVRhPWY89o7oParbggGy07iU+QCVYlGXct8fk4TgK6fim+gXRS8tQY1 ZMKU7uU01QLYlSaGLLn2kSeJv7XMwUrCBjuerBJ9qz5H/X7Udj4E1XIol764yE4l48iA PRcDwyBOjYwj+H5iSYCtQXqXODz1QcpYNtrAynOgWtH302d05gWsAMvtXsLHC7up9B72 aIuJeFCj+CnAjIg3oE8Ba/CikYDFIhNhINZVBGucSFpTEnIVljIRh0+l2UfHsUr5HG+H rwniIgul1JHtIrRQHjMQzNrCHReOK3lc4nCxRPaaxMNTLrBoXnh2uO/TiaIXVOuTISfV qYfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702510977; x=1703115777; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=irtsiUCUylZGPtSeScUGgZwEzBoaabXmknnY3lf14ec=; b=vHHHrrHusIEjumIwEooKiy1CNpjsDtqLSt2HGyo3Wq303ql9WCglChNWE2j9pPxsjF AQUCbd6+/lp/oY1hmmvjy7LpuKxGvGUGosM0vK9WISWQTX7Psd621A5qTvsNlU3+xoBm ctO9kl7CE25+NwSqFic1/ITQn/qMQah+Uj4HnMn56wsjiqniWCsiH1tNla7sZB30+e0z 9KqlacetJmPK50R7N1jVuaq1mkWp+X/BsUqraDSTl+JC/JxiOOqbyYOqralnrs7TV8Ua 8H4qh9SPqdQNaEK20KxhcquJwUwelVq1t/zKR3RgjE7L1c0xX331+nSIXFYU2vJYXFeg dG8A== X-Gm-Message-State: AOJu0YxHh+uNMucWOpnQl0RANcRrVqVyJcEGz8N2awXvg5IgwA0qfgjl C9hCe45wq5qH7U7KKHW+cDlpj7vDeTULXYEkzfA= X-Google-Smtp-Source: AGHT+IHyxsSvPMDcrEJ+OhDv3fNcRm1G3ibjxqwdrYC9xsCq7fCgqUthDr/+y8Iq/Bc8aUj0imzWPPXYAnpzZDLH/fk= X-Received: by 2002:a05:6358:99a0:b0:16b:fe18:27fc with SMTP id j32-20020a05635899a000b0016bfe1827fcmr10609380rwb.31.1702510976965; Wed, 13 Dec 2023 15:42:56 -0800 (PST) MIME-Version: 1.0 References: <20231212232659.18839-1-npache@redhat.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 14 Dec 2023 00:42:46 +0100 Message-ID: Subject: Re: [PATCH] kunit: kasan_test: disable fortify string checker on kmalloc_oob_memset To: Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, akpm@linux-foundation.org, vincenzo.frascino@arm.com, dvyukov@google.com, glider@google.com, ryabinin.a.a@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F1B404000B X-Stat-Signature: tpz1t15mhkfnodmawpjikszot5ra347p X-Rspam-User: X-HE-Tag: 1702510977-955242 X-HE-Meta: U2FsdGVkX18f7tex6hvOuf1hslluiVUa412S2pBiTA7MjqhrUEMCW9MsU8rGvggSE4dyHuqj869E91jlVNAnvw/9GwcHRdgjYxbdYMwO1JoEjr3UlucQdqanzpr3dpUCFCzeZ+nINa5s0ZyLu7f550mt4dXfv8Brisi0d/eeOIFeD5+skjSYmzafcm+TWQGRzdIm8H2FYaJDYmJHtUe8CBTsOK/yeJoy6SDm5LaR3gPnXeG3av2+VsmFOeuIpYAqqSXUGIwP1Yt7VgjtG9VB9mYSgcrVF4CMcTg4IAAyjCoie7OW/blvmMrJMFhljquPMnidXyX8b4+0ZhC2+xbu7ZsvsX5dikbaQxZZmzjz94zspek8JGuA3E8v+AfwbDOMoxFniVXc67A3v5LfMQ6u8Y3oXCVe8gaH8lYrml7rnI4w27mUoKXdUN0SluFS5Ctx+X3+WNoq+op2LzFTmKxuddY0ZzEG5fzNRhknZRBCQM/vAFNfWsGkU9kn+0+hUwPzQHm5EEykJQj7X5mgGFfmMggaisrj9r5UZ8Cx6wKHRvVNKDXp5ypEA/YgarbvLrzNiMETnzw1tECBRgBuYGTMNa2lSaAjQ8FJ6Cw/biwooKffi8UExlDYim/O35zTQ9pEvCnYWbar4rbKyf6NkWYyLUCMN3V5D/2Wc0Crotm+SlYkHeQ/Ioc7VdH5YvIGq5KJXLGwXDVIKaXA0RmFo1JaDGOfxjNS16jUTJxqj7jsh2vqEmUPVFJYBOA/nGYgUoi2hIpkmqcSTg2nQ90aaVD87q5ud9xrG/qPFaVfTNZ9+axHRKK5pnHJPx82PSkAx3bstByJT99YmqCHsTDqIwNq04C77XrHu+Vk8NMfqG4XNs0/uw+aaXWeVnP74PokkVas50Zf1ibkApjCnq92taZ8q/kV7adA9+6TFYK0afYV9W2zcvfWmYJNOhIv/dJRSxSSimOKFyCDENZNx8PYp87 c9Z77+CX 7oc6LW8PSi1MHdR7+kfvoOuKXvm32MgAnf9EF5ITsNrl2ImiJyOZhwqQmjdT0ZquZplLgn+z0X1zHMWlF6o3eCOqicq6OSUQTbSY59dNByMr1Yzs5tKAaqcBoVa2J0eO5/7C46aeZoAi5YSUqWmsH3oTybr42cGctTHvXq/jJpltt35d6xejO79EGWJg1ranG5jOowjO2j0XGJ1rpOxoF/O+gWl/wFrWa738Tb3uY00Wv3YJCU/Wlv7qbQkweCzeQDKYbEK3iKoTcgZbzxpQcEe4WgM3iviwgQtVB/b9dPt4JnV/10vuR5PV2am4gHl4d6xjfMpU69B+db4GHGPwpLZziVnJSjWOEivFkW0fSgnLajG8DX7h58q2LqvwWCemrgpjGVby7cJkP6j9yP8sCIO2gEorlT9zvMeCbtXkp77fchuUP8h3sa/C/Z69qJUvyXjoyGBsN21+4/gvMZj2HqkM/pdZ+qf5/ETAVmcAPTzJvFTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 10:42=E2=80=AFPM Nico Pache wro= te: > > > > diff --git a/mm/kasan/kasan_test.c b/mm/kasan/kasan_test.c > > > index 8281eb42464b..5aeba810ba70 100644 > > > --- a/mm/kasan/kasan_test.c > > > +++ b/mm/kasan/kasan_test.c > > > @@ -493,14 +493,17 @@ static void kmalloc_oob_memset_2(struct kunit *= test) > > > { > > > char *ptr; > > > size_t size =3D 128 - KASAN_GRANULE_SIZE; > > > + size_t size2 =3D 2; > > > > Let's name this variable access_size or memset_size. Here and in the > > other changed tests. > > Hi Andrey, > > I agree that is a better variable name, but I chose size2 because > other kasan tests follow the same pattern. These other tests use size1 and size2 to refer to different sizes of krealloc allocations, which seems reasonable. > Please let me know if you still want me to update it given that info > and I'll send a V2. Yes, please update the name. Thank you!