From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F8EC433EF for ; Tue, 12 Jul 2022 20:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A34DF9400D0; Tue, 12 Jul 2022 16:38:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E54F940063; Tue, 12 Jul 2022 16:38:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ACA39400D0; Tue, 12 Jul 2022 16:38:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CB72940063 for ; Tue, 12 Jul 2022 16:38:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 370A7B89 for ; Tue, 12 Jul 2022 20:38:24 +0000 (UTC) X-FDA: 79679610528.25.635164E Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf11.hostedemail.com (Postfix) with ESMTP id CC20B40094 for ; Tue, 12 Jul 2022 20:38:23 +0000 (UTC) Received: by mail-il1-f181.google.com with SMTP id m20so5200424ili.3 for ; Tue, 12 Jul 2022 13:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gtA9X+fkjEw/LyXx7cshYRPvYgSQ7aQHvwyjYuYISkY=; b=n9RIa554dycPGIKBOybZCxXvgE7O3FOURYuK5Rnd/mSxb6YmPx4NecnpLLC17ZO13g z2A3RBDfsGBdtTvmzt3QWmSQZahjAWF62t9H+KbGXH2iBNkyI5TTBHickAHetTgp+gm1 e4d5G7Qu0bfcSaX20DM9iU8hk1RtRpOgraFK+HU4nkHoRbsXkTby588r0/xTUbYX5TZP ICqKI5uM6ndDxfDavEceu3s5Zc1Twx7qSiApci11ooZBvr9YqtCX+qyTmfm58kk8k6j7 PaAQFdD2y9HOeCmn3N+DOd1eVwAM76SIKI9tEIkKwUIFXBkiVg1Njzo9F2A+S8HSvhkc Imrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gtA9X+fkjEw/LyXx7cshYRPvYgSQ7aQHvwyjYuYISkY=; b=ZNwPbz8Mj9dr0OH4OaIziH5RnZtye/2JoXvKcitWcMN7ZRCpHzSEFS3u4rKPCcxmdQ a5sp9tTRg0k6zIHeau5zI+aCxOPs31v/pVVPttDZcFSfyi/2twKA40UMcBOJmRfey/u7 eV0UtyVaQY3iJXGJtZqP8S9/GxgYktBBSSBXx1iPLMhdYNjomq0zrMWjQysV1dbK5e5X ec5aIE6jUMx63Z060uMQCl+eUHHt6x6ImcY5OEFUcMEjnMaebTY6qf5wDv1e1aglaj5o LGjmCpn4j0IHg7cv1gI9eKNRtb7DCxTP5MdKlyGYxsFEO6TujaqO1bKbvHa//03mfq9L SHjg== X-Gm-Message-State: AJIora+Bqc22HXpRwHboHKvLj9RiJsXlCfKtsXxcLg5mgYA8nGhWIo2s 9RzgWobzhypFzVR46enQwghIaGsASjHi0zg39UI= X-Google-Smtp-Source: AGRyM1sVN9YSYB7R1dSBnm2ETFni6QgUDtN1HElitlfGihAv/kBYE0FaXotZOZQmmTStA3kvphxi9Y1pG9MpCrbFaDE= X-Received: by 2002:a92:c562:0:b0:2dc:7ca1:a54c with SMTP id b2-20020a92c562000000b002dc7ca1a54cmr15605ilj.28.1657658303138; Tue, 12 Jul 2022 13:38:23 -0700 (PDT) MIME-Version: 1.0 References: <5949bc710889be1324d5dada995a263fd3c29cb5.camel@mediatek.com> In-Reply-To: <5949bc710889be1324d5dada995a263fd3c29cb5.camel@mediatek.com> From: Andrey Konovalov Date: Tue, 12 Jul 2022 22:38:12 +0200 Message-ID: Subject: Re: [PATCH 21/32] kasan: simplify invalid-free reporting To: Kuan-Ying Lee Cc: "andrey.konovalov@linux.dev" , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , "kasan-dev@googlegroups.com" , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657658303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gtA9X+fkjEw/LyXx7cshYRPvYgSQ7aQHvwyjYuYISkY=; b=eKsIlnjGt+5v3+WYrQphPNG3tdWlTJCFjt1Zf6wsPGop1Ji06nK7uB4GE5rFmETbNwGaes 25DQ9ulcBWHUqIy+dL9ha9Ez/dJjlYQn6fIosNxVfDTpaoyrhvtfmt91zMaVps2s7twWGa nb+77wByr+nSeMinVgYjXQTLHKrqMMc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657658303; a=rsa-sha256; cv=none; b=paEMy6BSIO1I9jfGmF19WuMZOnG8NQqvANJ7yGauFl9YJGCQ+X9ZbajZsSdJSN19JRxljb Wq6K/9xuZYqM5VLGKFQvXc/GeZP362fQ0Evz2TurjDk70PkxKRpClsDR1u5KVXf7MddFOG ta9SK+KH8Vi5bychxhSqC+kPxiGnPyo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=n9RIa554; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Stat-Signature: rapas9usphdhuhpq5fqjj1hdeo1zwtb1 X-Rspamd-Queue-Id: CC20B40094 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=n9RIa554; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam05 X-HE-Tag: 1657658303-650875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 21, 2022 at 9:17 AM Kuan-Ying Lee wrote: > > On Tue, 2022-06-14 at 04:14 +0800, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > Right now, KASAN uses the kasan_report_type enum to describe report > > types. > > > > As this enum only has two options, replace it with a bool variable. > > > > Also, unify printing report header for invalid-free and other bug > > types > > in print_error_description(). > > > > Signed-off-by: Andrey Konovalov > > --- > > mm/kasan/kasan.h | 7 +------ > > mm/kasan/report.c | 16 +++++++--------- > > 2 files changed, 8 insertions(+), 15 deletions(-) > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index e8329935fbfb..f696d50b09fb 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -146,16 +146,11 @@ static inline bool kasan_requires_meta(void) > > #define META_MEM_BYTES_PER_ROW (META_BYTES_PER_ROW * > > KASAN_GRANULE_SIZE) > > #define META_ROWS_AROUND_ADDR 2 > > > > -enum kasan_report_type { > > - KASAN_REPORT_ACCESS, > > - KASAN_REPORT_INVALID_FREE, > > -}; > > - > > struct kasan_report_info { > > - enum kasan_report_type type; > > void *access_addr; > > void *first_bad_addr; > > size_t access_size; > > + bool is_free; > > bool is_write; > > unsigned long ip; > > }; > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index f951fd39db74..7269b6249488 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -175,14 +175,12 @@ static void end_report(unsigned long *flags, > > void *addr) > > > > Hi Andrey, > > Do we need to distinguish "double free" case from "invalid free" or > we just print "double-free or invalid-free"? > > I sent a patch[1] to separate double free case from invalid > free last week and I saw it has been merged into akpm tree. > > [1] > https://lore.kernel.org/linux-mm/20220615062219.22618-1-Kuan-Ying.Lee@mediatek.com/ Hi Kuan-Ying, Yes, thank you for the patch! I will rebase my series onto it. Thanks!