From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C37ACF2579 for ; Sun, 13 Oct 2024 16:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D77DC6B0089; Sun, 13 Oct 2024 12:04:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D281D6B008A; Sun, 13 Oct 2024 12:04:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF0106B008C; Sun, 13 Oct 2024 12:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E1EB6B0089 for ; Sun, 13 Oct 2024 12:04:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50793802C2 for ; Sun, 13 Oct 2024 16:04:18 +0000 (UTC) X-FDA: 82669050954.17.1F3A93D Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf08.hostedemail.com (Postfix) with ESMTP id B015416000A for ; Sun, 13 Oct 2024 16:04:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nkgiQVio; spf=pass (imf08.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728835390; a=rsa-sha256; cv=none; b=Ilw+DbQ2lTEA05X7vDF2+La3dcDdY8ZsYPyMgHFadNQmi+TodL14BVC9Z03Jz6WpYwfnlU QoEg9BeNbnNy7iIvymbtW6qpU1ybFAnn/GxFS0iliGjAqXM0dewXvEZ6TrlmGF/EqG60GY N0yKztdniLwSzDADf47kP5uq54fJAy4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nkgiQVio; spf=pass (imf08.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728835390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gMpna/8AYXdCR0wRcOc/2xASvv+nmGVic53OMYWL0o=; b=h6rkOF3JTdGYLavsbFbBc4BfPDE3uWBPm/xCNW2MRUH3BzT3Bu1N11ONUoa3kNi6BPWsLN ltXm9g7koEnRSc34rPiJATuPhtHMFyoHgU//H7sYIirGchJtgqc2/3DV5fUj7n8QGy2RfI M3wphnMVtDBwAH5h1SEG17Sk2Wwyus8= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43115887867so23111795e9.0 for ; Sun, 13 Oct 2024 09:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728835461; x=1729440261; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5gMpna/8AYXdCR0wRcOc/2xASvv+nmGVic53OMYWL0o=; b=nkgiQVioy+T0Wu+S9svxXw/ntWN8COOqPTU6Ld+C3IlfL4gbr2vMao/v7z1sXGBX4L rsdzEw95L2fd0yFeDQmBsyosNQf3zj8BhnUE7+FNEL53E+U4xc7dCRKAPpBixd7xPVPZ 9McXPMB8KbYpn8X/VkxRhXBVh2SgSGAifhImrXlCmsiQVkDVKF3foPIoS/ZV+658uLIc FLOlxHFgLi6e1Pl8LyF8KAvwnSvPxyD7FCtlFcn4ofts+0pHvUPR2Po/zPfZXESUiWf2 JRzYRtvAgmywIAiw+j6IY12595fBarHulK2qxnFSYssHIMnbQsnpQCSDeTifX1i6oDfy QeMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728835461; x=1729440261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5gMpna/8AYXdCR0wRcOc/2xASvv+nmGVic53OMYWL0o=; b=dtWs2vzFvplG8HU0vvBJ+WcxTemf04NPsp7wvXz/OxbX9GYDYvodEf/vHsnTyUcIh4 D4IYRtBipLrXkgI4yeWApx5fZ8dKLI8t1bvvg+TDtYHWnHXKAjlJ1HAke7XBaYZtdL4f vOysdxlDJEOw0QcLMY8a/x8gVnbw4P8mWgrHUwVS461OmP5u4ur4jySZ+RxI1wDS1s0q MF0D8VLJ2uYbXidLkb+1jimO7NcfLwT5I7VLW58HQM9GOhxYKXLDzX0f+kPrK0fn3D9k BU6YHSTe8OTTQQNgJ4hNHmCvqoOoK+X1ityzimIlXJSzCcS9FmVAMVnxLDclikXU98QZ s3CA== X-Forwarded-Encrypted: i=1; AJvYcCW7VWPo1r+8IUG5A8+W6yk+JRZ8ynROUjB2/mpsUi8Dg+GSMGyStLPl+1397WjcPotKNe5lHHgL3A==@kvack.org X-Gm-Message-State: AOJu0Yyp/ReP3t5pNYt3d8o2a9SiVzVVB2TTJesSzzOeq7Eity9yJLn+ LytMrp9X69EOyCTuKWxSW6pgsA1LF9twppo82z67v6Cq8DQGtIbN75O7PEyfQJ+x4i80HDvfWdC KQaLvxAF0JKxrTCMPHKZH7otTHBHRuw== X-Google-Smtp-Source: AGHT+IFnhmlYgpEhWeyPYax2Xt7ebzE0H4KnqzeDfB8AqkfjBNX4rSLlp5VGE2NO4VU+LCR1OkSF/cZoTAfjMs9zl4E= X-Received: by 2002:a05:600c:1c9f:b0:42c:ba81:117c with SMTP id 5b1f17b1804b1-4311d8914ecmr69774385e9.6.1728835460697; Sun, 13 Oct 2024 09:04:20 -0700 (PDT) MIME-Version: 1.0 References: <20241013130211.3067196-1-snovitoll@gmail.com> <20241013130211.3067196-2-snovitoll@gmail.com> In-Reply-To: <20241013130211.3067196-2-snovitoll@gmail.com> From: Andrey Konovalov Date: Sun, 13 Oct 2024 18:04:10 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] kasan: move checks to do_strncpy_from_user To: Sabyrzhan Tasbolatov Cc: akpm@linux-foundation.org, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com, elver@google.com, corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn, 2023002089@link.tyut.edu.cn, workflows@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9utno5tfmbi7x4bzcmh1i6s15fbjb39g X-Rspamd-Queue-Id: B015416000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728835458-461609 X-HE-Meta: U2FsdGVkX18TwceWtqr+fPCR1hDIbIg2hSshFavCJMC4GjHiK4YRd7eep/nP8R6cyO6cgBd+AoUZVprGH3QhgFroFLvG6xD9b8RgI0zGUj4qk/GPWbiIp3kE/9e2a+JkWTnIKvXQOwNJ3eZq5Y2OUpfRZqbFyLB/IkRt9coE6rZa28UFtbhMLY0LHFbSZNBgysXuVjgABq5ueCP8K64J6uB03Uy86pvM2HSEI0mg0ZCYYj+caRLfcwVjSwlO18l0r5oow/0wC6TF2OA1tPwQc+NtlNpue/+8iwTTKKOiwGxRtopnc0CNiZvJfGjQyJeMh+jo6vITSa9jWFv0k4a8aMAgm87a5ThJD8GxOrwu3ynfFqTpln64Vt317eKMsiZf9Ay/13g7/NIseK3Cgm5OTrXqQNsfWGeo5vIVzp0rcV/NVWY2+tsPYk15G/s4F/SeZBYBrnMGPesiEGdsxstxJ3KZu0dRpjA4ymDQDrwNMyWt+Lg8gay7XL2Ce5JrK7Y1KXBfCgWdAgJnwQBhnpAeJwt90mjokKVruUs9PsmB/DXkB6itaG9Wlt1x7QB4Dkoanu5OZES2h569ni643l9YFk5sMJm7IMvzqvslUxGdek7DVKCWCIWOD6UM8A7Nm7hRe3VgkEl73iSP20jNXPZnXXuwPgLTkhUxrCLQBGEK/3Hd1FyfgXH5HLgHC7Y0e1U1H8doIT7t/GtmP4lwdXfeRIFRP6f2OR71UWai2+V/LQty6XEUnlDyULt13fB/ccAxtzIxvHbWW9TvboxRT0w5lQVHOZ986By6faYKC9F4eYIj07xWqSj8M+fbjn5ZygHmw7VRphND3b57D6ewM1EPO7llCvMpQ6k5KdNrQziq6qb8BScHKn0WzqCBqNMeq2UUnDB5s2xF0tIhOKvDg9jEtiMIjUJsyUjT7xKhZqqaVQtOQLaNbcZTDQjn0RQQ6UR9ZLkoz4Zb6U96BrriQgw sxSsQCBg d9Qcp57ny2JP6G9ios6eLGvsboaXKF3sz+1Qy1NBGcie1YJ6P10wKC6y5/+HtSoGjVsh9SraASfOQIRv8Z2U9u95ZXuzVvmIHuBSBQDXvEnNOsYUmx+mHIRnc1f90HS5fDyUUMpK24LQOwIwKtiRHHZlWGgsmWjAcQo54jZ3Q20BDZEWIH6mWLfCADZ0DgEiPU37OvjUo7UPEpYpE0EXQLEg+1Ajo/nPGe/E3uADw51Hy10JcwKg9eVWsti3xfgBENl/XW+6Q0FC+xuLUxyE4AYhUPbEmecDBVBNJqRu5tcdtMUFMVYVvak0KicU3LBb5yrfRrcAx99n1ab1CmHtLSs1ZZ4KQXKShO3HSaR0JCNX5Nc60L2rYJcRsiqLv+nmyJeYPXiIsyhFcmxls4nowzJaX1MXkz0K7Ruo1nyzCfpQOoRZqgU9TDxP6tvKSi7/C+BWd4YKac2LWzms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 13, 2024 at 3:01=E2=80=AFPM Sabyrzhan Tasbolatov wrote: > > Since in the commit 2865baf54077("x86: support user address masking inste= ad > of non-speculative conditional") do_strncpy_from_user() is called from > multiple places, we should sanitize the kernel *dst memory and size > which were done in strncpy_from_user() previously. > > Fixes: 2865baf54077 ("x86: support user address masking instead of non-sp= eculative conditional") > Signed-off-by: Sabyrzhan Tasbolatov > --- > lib/strncpy_from_user.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/strncpy_from_user.c b/lib/strncpy_from_user.c > index 989a12a6787..f36ad821176 100644 > --- a/lib/strncpy_from_user.c > +++ b/lib/strncpy_from_user.c > @@ -31,6 +31,9 @@ static __always_inline long do_strncpy_from_user(char *= dst, const char __user *s > const struct word_at_a_time constants =3D WORD_AT_A_TIME_CONSTANT= S; > unsigned long res =3D 0; > > + kasan_check_write(dst, count); > + check_object_size(dst, count, false); > + > if (IS_UNALIGNED(src, dst)) > goto byte_at_a_time; > > @@ -142,8 +145,6 @@ long strncpy_from_user(char *dst, const char __user *= src, long count) > if (max > count) > max =3D count; > > - kasan_check_write(dst, count); > - check_object_size(dst, count, false); > if (user_read_access_begin(src, max)) { > retval =3D do_strncpy_from_user(dst, src, count, = max); > user_read_access_end(); > -- > 2.34.1 > Reviewed-by: Andrey Konovalov