From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DD9EED619 for ; Fri, 15 Sep 2023 16:53:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61AC18D0027; Fri, 15 Sep 2023 12:53:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CAF58D0005; Fri, 15 Sep 2023 12:53:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B9A28D0027; Fri, 15 Sep 2023 12:53:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D8E28D0005 for ; Fri, 15 Sep 2023 12:53:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 089FF806E7 for ; Fri, 15 Sep 2023 16:53:48 +0000 (UTC) X-FDA: 81239428536.06.326B647 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 3B192A0007 for ; Fri, 15 Sep 2023 16:53:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YxAD+C1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694796826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OpolqE+SEAVwVFTY41H2JAWAfBtJPW7sGVhV9bEg07M=; b=Yoc0EJgGY9WRUR5yrcvgHQJ+iGr+vwLjrQtuIFgsAmIiGS+NsWHnqT+PHGE4y+Bu/U9DTF wUsmeiXCdIsElqQlVN10V9BQ8iscp4mf71R8SEhfbGRe43Be1EzHIg1Xn1jV4zYGUmAzRw Cw9J8yhOTSMnJm8ono5psX11mXI2HXE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YxAD+C1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694796826; a=rsa-sha256; cv=none; b=kMMa3FvEPGXzvzQwt/Ky7aoVRc/cT9S2DoV3XIGozSiBWKZJrmZDpgB6U+zOiJ5CUjWjj3 zVxklloyzXeWy8eNUf/2FG3fn4cJ8YG59LpnEFhLwaKoN3oeuZ1uLBEg5QRqyLj9NoRhpk Syl4OVBe0BM+4XjrmDWHbrfyfUBL7wk= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1bc0d39b52cso20081045ad.2 for ; Fri, 15 Sep 2023 09:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694796825; x=1695401625; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OpolqE+SEAVwVFTY41H2JAWAfBtJPW7sGVhV9bEg07M=; b=YxAD+C1a7+4UNoXRKnEbszzelkcic04H9K7NDri4PaIU7E+nhYpUXdNAc05w04CQiH 8Z0RCnJUdLSy3VEH5WotxEvhYBiEWDMEgHtBfdDdghbWvezoiEHYVbeLn4bD3Tfrt2Zj J1osBx6gsk2X5sp73QmfKPQl72Xktw8WA2GVaDSSD94vz3PAQhS7PZC+6OPJ7znCBk8g I+MEpOB3gK0kChpPyjDunmiC9F5j0VT2q5eqwk09Sremp71JzDfZylhfArPF16AVo8yC XbceU/GY9TR3ksHaerzSJyqzu5gZJu1e/hywJ15oEpTnVsMQFRm0M+OIqyvkYYXqZJkQ BIHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694796825; x=1695401625; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpolqE+SEAVwVFTY41H2JAWAfBtJPW7sGVhV9bEg07M=; b=qhh98Ci93/XQLp9CSEinUPEZMRsCNYy0VmeKpOUb+foSqb/k+7FNP7mHn+45Nhaa8i pUtD1GwTpqeKDck6Xlom6Bm1bPrT098yDylZxDKZSiPQ7NrtWU5eUR3mAgxPZiDSnRSX jFGKBdluwF7D0bjFNR2EQKqL4JV33dPHSd++hqPUvAjEegfwT6svLW6XAg+A+UYkGuqa Pr1dOTZxPwi+sy84hVN21tef8ENc2TG4X7ktsgEV4U8zJUHCAiAGbRPWgR0go3m5xbbR hP9VFPjop6yW9ONMdv9/fRmsHEh3rJ7MIDcsD8P0HvLxRtWXfcE9UrQblZO2I0DSwPk7 5hbw== X-Gm-Message-State: AOJu0YzCkfX+/n1T9L3jc8Mx5o1Umpsk7LAgPKDJ1HhIRE5VJmp54ggG fCF4P3u4QWXwmb3UJoCdZuTi5Xam08X03EFI/+c= X-Google-Smtp-Source: AGHT+IHdg5qFvGAFmPjYLsoqHgR9aVE+mxhLvc6aKZLyM2Lf8HzCOCEXGWDSsjgJmyQBolmCaP2cdGU4Fzy9TenO3Dw= X-Received: by 2002:a17:903:1109:b0:1c3:bbad:9b7c with SMTP id n9-20020a170903110900b001c3bbad9b7cmr2546503plh.31.1694796825027; Fri, 15 Sep 2023 09:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20230915024559.32806-1-haibo.li@mediatek.com> <20230915094004.113104-1-haibo.li@mediatek.com> In-Reply-To: <20230915094004.113104-1-haibo.li@mediatek.com> From: Andrey Konovalov Date: Fri, 15 Sep 2023 18:53:34 +0200 Message-ID: Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal To: Haibo Li Cc: akpm@linux-foundation.org, angelogioacchino.delregno@collabora.com, dvyukov@google.com, glider@google.com, jannh@google.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org, mark.rutland@arm.com, matthias.bgg@gmail.com, ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com, xiaoming.yu@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3B192A0007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sist1139uqfj6kpgni5swqfsrfhyz4di X-HE-Tag: 1694796826-465547 X-HE-Meta: U2FsdGVkX188ARmvMHV1XNyMtf96c8LzdNcG0wmhdzCasJ8Xu1yaO9kQ+8sWe5Cu7Xd7yOBVQkVZJhEQHRz110Znx1pP/MP3n9BUXK3Cl16I/UG8XYjmtNpzjTbsLOOmF8Vi7aWdabBA6xmRM87BU5xZTiYUsORRQ8SHePTpfUNii7z/zKk7P8DGPXBgs8Id2W0S2pf4+x29WRaMg/zlk7TaghIj6PsXztr28a052b9Fw+f162hiXnwb01L89JoMNKqB+slFDf7zdkVPoQA0aZlvzemnfoUjkSQUppLZ2EEHpY2wqRp/ogk3gfNogL7cDQKCQ5yTrUxVaQCQReGSofXEEn6Dkqaqi47HJIzKNieZmSv+GfomRkh8SdeMNnIPkPwsA6ZPIRpfKdQx7dOrNMXRtrGYreM0adN4WhM5U9d1qmE++NaGYuM7ADjtYCUvx4yOrqjvztbzyHCZwytDdIk4NdlCSLsBCS1vxBP3rcS0HjiieZBHEfx4bitLTZwr+WQNQYNywB6nH+gi9TjvLKVjxQtMqTIHn1IlKui+pobedXzZKWS3dimVtUnp1d8EvmO7hqEH7ks9/nsoAEiudtYBjo8lqLH3P94PblRdvHY0Rxb8DgtuPzvB8djlgmLBxKYyB1t8zuktZLeE43XMihwtO00btM41smWsVvoK7+K2V1e0gY9KkYxSRkWmI7EYqAi6FP6r9gMyhgF/EwiDdLDn5u3zGsBokHX4ewx+l3ErwLZv70PTj7wWDD8lj+6/Hj7Haj0erMqn5cVwxCUw29T1vJe0JMRWohbR8hjSNuHOQZZzsPjH3Ya0Xb/EDsd4lOqXAv0Qm49iv6wYEy8B0GfgwvfyvA9ywX5ic6MZwylpmwQ2WUIdYcRnA25iFZ5EOGXtecbG6WO7W6ZU+c4vf206nOXBIIa0mucYShLUbwmNDlwWqCbLaOyKyazAFZaQDzqwo1w2IXEgSpz0AN1 UOfIXlrk mSb7Al2I5ur/D3vIyolnIDs+j3ls112FzeizY3wMTQX8IgEIZmyxsFsVV5J3xwhp0ImaHM9EL8ioKT5IPCQFiQ9O8rSbgkHg71Yc7bEfh9Bqq27LqagZEFFBEmMDgc9PIA5K+rS/NzA7yiWiq8vVT+sCIknz8qXB6R5hR3LwBH+kmnONjFk/YhtAb7lTQHdRaLb00DggrRb1TI5PNZaTpzqMIeT04W2uwpFGso9lAD17Zq2TIMROlzDP5WoQYTRmOmk7z6OJOtAoBLtyeWQ9YtU3iV/XEJMSoSzhuxEwQxxj/iu171GDeNcK9OnGgkQJXi/S65E+a484eubepxO9aXwYgLc/6aZJMwzloooDw7oryDYU568qVtEJou5a/5p2oJRtRjuLPFzDgsbL/DdzQhEUqpDwYG+ZQsagOj1UxOzfzXLY21HJlUJG9Ec+Wi94sLmIroolAD3h8xPb1ibVLrh8yGJSeBNYJuySleItP1r+3KBqDcAxMkB2cIcI77ZrCyAc9hw47nZKrGPChTPpamBKOok3CrMmL58ElVhqGgygXl4E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.030851, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 11:40=E2=80=AFAM 'Haibo Li' via kasan-dev wrote: > > I checked inline mode just now.kasan_non_canonical_hook can print > something like below: > > Unable to handle kernel paging request at virtual address ffffffb80aaaaaa= a > KASAN: maybe wild-memory-access in range [0xffffff80aaaaaaa0-0xffffff80aa= aaaaaf] > > When addr < KASAN_SHADOW_OFFSET meets,the original addr_has_metadata shou= ld return false > and trigger kasan_report in kasan_check_range. It should, but I don't think it always does. But if it works for you, let's leave it at that. I'll double check why it failed for me later. Thanks!