From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC20AC433EF for ; Tue, 8 Mar 2022 14:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DA1A8D0005; Tue, 8 Mar 2022 09:09:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4637E8D0001; Tue, 8 Mar 2022 09:09:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 303D28D0005; Tue, 8 Mar 2022 09:09:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 2128A8D0001 for ; Tue, 8 Mar 2022 09:09:55 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id EA2E98058F for ; Tue, 8 Mar 2022 14:09:54 +0000 (UTC) X-FDA: 79221402708.07.B8709F6 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 7C637A000E for ; Tue, 8 Mar 2022 14:09:54 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id x4so6104664iop.7 for ; Tue, 08 Mar 2022 06:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EbG/qqfr/wurjd2//LUTHT4MZ/YTGKmKEm4o3JLwT/s=; b=HvQ65t8feIo0gRSK95UMXEATxi4c4DoYSB6JJZCO8NKipsnwvobh9/vyJW6KnA4Ta1 d7ZwUmtiJ9X9jqfy4IyCBp4LwwKTbw252gdFl5IvhQiRdHGR+yCENQLl6YhN+Eluw8tQ kcsLzGPN/hCZpD3pYKze6xFjB0UPWoHCBjA50sP7SsW7R5wpEeuxbiE3yJhYMEBqJ9bL DL4o8ZvmQtB1yX8NmUi3iRxe7s+oVJCKQx4wO7WQnzy96JG53slddSp/RQXUmkWTUPAr nRzkkgeolSvSx262NMoqgxSeyHHln9AkpMp2esCK/ML/vQmG2XrTEL8q9aTEd6O62roq FPXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EbG/qqfr/wurjd2//LUTHT4MZ/YTGKmKEm4o3JLwT/s=; b=tDI00x8ohoAqrgPr46MUwVQMTPTgA3FOR/GuAWbQWYw0DN00AAu+AJ73OjWoze03ts U386Zr2Oq0UKYvFv4Gits7NH2qirx3SXQbm4D/NlD6iYgOh9K3Z1KlSbjWrk/pA17Wde sSv18Y3CUdc944/0zLOpf+VIgIN5mD1ztDo3mavEuorhIWVd4059Viohcf+K/h4wpsIO U3Nz0tm1YtmlSTCGW3ujnOJRUzPJaSIcTN0RwIamo1xsM9iIb3lTt2GS4iCL2mLWXUdz WkYfirACe0ofRFe0hfLvtZm1xzV23cUVkhsYJdd9rM80b7JK253NZ6g6yEq6OlI7pdT3 hu5Q== X-Gm-Message-State: AOAM533gtFyPqmixLxBccedZUpsnBQZw70xDOmqtvC4cg9pO2UYv9rJh L5opJ4+VYmm0hqecp4Y0WXHovfiu8TQxYjmHzeM= X-Google-Smtp-Source: ABdhPJyHVEnG80mBmkBO7S9LJFrKBhfsOeGnPEpj31gTwsUsW8Xe9N4Iq792Vb2CDymIu/7dlukAnPRZFx0iJ7bN6ok= X-Received: by 2002:a05:6638:d85:b0:317:d2f5:8f1d with SMTP id l5-20020a0566380d8500b00317d2f58f1dmr4997851jaj.117.1646748593868; Tue, 08 Mar 2022 06:09:53 -0800 (PST) MIME-Version: 1.0 References: <029aaa87ceadde0702f3312a34697c9139c9fb53.1646237226.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 8 Mar 2022 15:09:43 +0100 Message-ID: Subject: Re: [PATCH mm 05/22] kasan: print basic stack frame info for SW_TAGS To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7C637A000E X-Stat-Signature: d7i6unp5p67un4fyzcdqu9qae1oxdjk1 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HvQ65t8f; spf=pass (imf25.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-HE-Tag: 1646748594-54163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 2, 2022 at 6:34 PM Alexander Potapenko wrote: > >> diff --git a/mm/kasan/report_sw_tags.c b/mm/kasan/report_sw_tags.c >> index d2298c357834..44577b8d47a7 100644 >> --- a/mm/kasan/report_sw_tags.c >> +++ b/mm/kasan/report_sw_tags.c >> @@ -51,3 +51,14 @@ void kasan_print_tags(u8 addr_tag, const void *addr) >> >> pr_err("Pointer tag: [%02x], memory tag: [%02x]\n", addr_tag, *shadow); >> } >> + >> +#ifdef CONFIG_KASAN_STACK >> +void kasan_print_address_stack_frame(const void *addr) >> +{ >> + if (WARN_ON(!object_is_on_stack(addr))) >> + return; >> + >> + pr_err("The buggy address belongs to stack of task %s/%d\n", >> + current->comm, task_pid_nr(current)); > > This comm/pid pattern starts to appear often, maybe we could replace it with an inline function performing pr_cont()? Sounds good, will do if/when posting a v2. Thanks!