From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E5FCC636CC for ; Tue, 31 Jan 2023 19:01:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7E376B0074; Tue, 31 Jan 2023 14:01:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E5C6B0075; Tue, 31 Jan 2023 14:01:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91E656B0078; Tue, 31 Jan 2023 14:01:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 842416B0074 for ; Tue, 31 Jan 2023 14:01:06 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 440B01204B9 for ; Tue, 31 Jan 2023 19:01:06 +0000 (UTC) X-FDA: 80416011732.24.C1F1F77 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf26.hostedemail.com (Postfix) with ESMTP id E2CEF140034 for ; Tue, 31 Jan 2023 19:01:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=POpr6rtU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b1NzJQj+IlX2uUKAqxA9aAlIl32T8LLkBO2KdikgTrw=; b=W+qRk+HOKZ3QMHrLHASb+YqifyYE5YvhfE9MEjnC2FJRZi/BZVboWRFbCa87AeESOLxlxL tKFAqOKubvld947Qs7siDJPATsqWDlmXcoF1Lz5S0gMQh7BcK25EqqS2GEM8/uEgIG7iGC ea0VvEIzTWdLUtGg00IpeWDmyy1YyPg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=POpr6rtU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191663; a=rsa-sha256; cv=none; b=hBfFzW3ciSYssqhBKcqi/iJdqGiqlfs4qjWv8uHtsuorIkosqFsRcyNbcSPorDcf22NXS8 4Ev+e1LYJVZgQpI5JuduihPuRA3gwYgeyKcoEv/JkByh/j8qK+VuzKBboPd70bFP1chwIC WVJZaRqpJnCW2rQflSOFs8ZieD9gTp4= Received: by mail-pl1-f181.google.com with SMTP id h9so7460110plf.9 for ; Tue, 31 Jan 2023 11:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b1NzJQj+IlX2uUKAqxA9aAlIl32T8LLkBO2KdikgTrw=; b=POpr6rtUzbOEXVUyz0KPld50XaTfjwTRbNMH8d5J2igr75HqUw8wn90WpgqoDKL046 RcWTXbeXPGvoPjqcW07ptOP3iHwWFeBXc8tiekDXDvF/LejmGtoREbloLtMUw65NODPf oLHldBXWNOrGGkj8iaZ2PsUPUYS76S0jwd/L5Sc9KKEHVKr9aZG+R7WXc2vwu7vygNGe P1aYV5t9cwjivcY8xAN2lvxFbYP5B4cTaxxgPLtGWnioZz3B8tdeDySLdPApRBrSAy1O Qt66RkBR4C0rG5qG5bOOPsVqkWckGjC3CYJveB1HNOHTaHCeNWI0YuIxqPf2Oh86mxmt dr/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b1NzJQj+IlX2uUKAqxA9aAlIl32T8LLkBO2KdikgTrw=; b=A84NDRIbSh+F37vJtKszb0si6S8O2t5RSn2WmRm9y7ec0ZCpkZgLoIOJlKTC7VoTr/ CMSPoK4tLRaW/sqeqMrHIRf3Zcat+ztQwcvfXaRRrGZmYeJsZDWShmlkWi4nVLFhMj/O ljkvfQoy7CtRdR6MO8c1pLpqn2VUBml0n9r1XDWw4QuEgu46buHJSm0GPv1nfjUE0fZn +pzjyPhJY0oc105fTOOVelCD0Ei4OI895ouZY2eenhNFLlMStqd2qaz0vYfemnbFrfut t6S6KvEb+LxfXupGNJ1rM3inWquQJvhIya8U6fIZlxLbzIEqqZHVDiC3sIt/HfdihR+v uKHQ== X-Gm-Message-State: AO0yUKWZvF4SXCYFlb9sTcyYmctaqyA3+ZjhW6gnYflEN8eRywz0/gKT xVMYaBqO3a7Ams1XU0lf6rah9XuHuzqbHuNHLLQ= X-Google-Smtp-Source: AK7set8bc7F3qbqkhbudXFapyZSTiQa6mULkelevw59uR/GLAtno9GuThVSykdKYn4f2fcDI1+Jga0NXpcHac0PMfeQ= X-Received: by 2002:a17:90a:cc5:b0:22c:4462:fb92 with SMTP id 5-20020a17090a0cc500b0022c4462fb92mr3207848pjt.44.1675191662752; Tue, 31 Jan 2023 11:01:02 -0800 (PST) MIME-Version: 1.0 References: <9fbb4d2bf9b2676a29b120980b5ffbda8e2304ee.1675111415.git.andreyknvl@google.com> <20230130161817.a13365bca60543e34da27f48@linux-foundation.org> In-Reply-To: <20230130161817.a13365bca60543e34da27f48@linux-foundation.org> From: Andrey Konovalov Date: Tue, 31 Jan 2023 20:00:51 +0100 Message-ID: Subject: Re: [PATCH 01/18] lib/stackdepot: fix setting next_slab_inited in init_stack_slab To: Andrew Morton Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E2CEF140034 X-Stat-Signature: zf7rnaq9iq6z9nr8y7uzajiccfecj7p8 X-HE-Tag: 1675191663-947890 X-HE-Meta: U2FsdGVkX1/7UAD6CduYs/5JsQhwshS0FMW+yWYcO2cCNtwOXzdvfuywza/iUX/ZfmBtMFWFRdZIGoj+Y3evQuAKso/9zztUcJMBbaGG9GIOJ6fVqp9eLXO8x9//0kRlpCVENA3acWID8YrpjWfPpgc3IPnzcvn4yaYpUR8Htvp9A36dNwwbsMRmgJ8s8P0rIOS4/FI8OOPKeqI3Qm6mJ2hApbhPFOBmqJRFpwhiNTuKwXu+cupZQE/1L+s4BFusK+dPWShYp92cGx9QaC44/qy5KooMYhnrUwxIfNGMzQrkxV5WLSs1WwdXwpt3qVr2YHlR4bMFQRCuBqW32FdoBaZYPsxOeZQpVvl2kni9UuAt4Ye27j7KTX0ouLdP36z0goLo/i0FOni2LaJi5gx+HnnwftUiw3/bnNvWVfTxTd5Iefu4rSWvyFWZLlAtGeyUiQuGlk5KLD2Dmfu5Zrp1GuF7CtcV6j5lNLO85UOOYyCcfJhU77hT1FvMKtExGP4owdiXKdlcB0aDZYI0n/YyZ0hd+X38zFVmatj1xD3J1KUsr8VHotsNvxKkQNtw7bcKU9kLFA6hbn1BssghpKVmU9To9KWY5maqx2yLIF3BL3X4KKoTedjuuvqRdM39k58aw4Y8BHfjDB7Hs/BwHmVipNI7Vgm9bgYUG6TY4803f2z+A8kWu8P9K1qbKxXwGlcqfDB53VebHhmy09IAkgHZvETu0OCFBpaKiT2MlPO0XOYE1zikP/W3RJGVN3he6kYzDbPi13pLITALjNprW86MQXt1xRNUPZES0qJTjSKaUAdamnSRKpZhmO8xDJhZsKMbu2o7meyL31QY+1d8VcMMklXHHWzr2ZG6/Nst++xaieRp/+4Cymv60PWcwMtkD7B0XN9oF4ZmljKofCAUhBu43MGiAJGq8+AHk4hTBEz68QtAwMGsIRBmYwkhEY4MFNx7XaHCYFGdjqRoCGG1xlK j8ex6jHL aObwsV6wKpVotd+JNda7fblGOy+Yoc3PwV1rBVZ9M1vE+wwUjZLeo+OoC/pFc1p0ZAUVxzefcdwtkjeiZXprdq3hXlUQoqMabNei99RmNJM+mywy9XWvH85p08/dXsX7ecU6t0aWetlrTGLX391/kKH7DXF1EDFuZVv/BT+Wya58WYM7CF+dbKxcvTW1sAwgR6Q90K6/QXUxo+4iDeMrhZtAn3L2EXYnGCiU7Ie24d/Yxub5h/cOR9VEJWvjZ9YEIVMfxfMGbDAukyKd/3BV4Sa9Aooo+UoO+zgs7g4PXWc1N36y62Pb6xTCYFLCTw2uaXYRbNRZs275I0mxooD0u1Bp+iH+3zLcNoFm1z6POahdO2rjJ5uijAzVqW6MEpim2IH+XuWJ0TUu3Jk2VxzAo3TzTLs9435QzZNMv9FtSm58cxy4il1rd43ATE9l5h2S3a/IYX/0qKX0PifpB9A8KOK/KITQYZfEwvP+e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 1:18 AM Andrew Morton wrote: > > On Mon, 30 Jan 2023 21:49:25 +0100 andrey.konovalov@linux.dev wrote: > > > In commit 305e519ce48e ("lib/stackdepot.c: fix global out-of-bounds in > > stack_slabs"), init_stack_slab was changed to only use preallocated > > memory for the next slab if the slab number limit is not reached. > > However, setting next_slab_inited was not moved together with updating > > stack_slabs. > > > > Set next_slab_inited only if the preallocated memory was used for the > > next slab. > > Please provide a full description of the user-visible runtime effects > of the bug (always always). > > I'll add the cc:stable (per your comments in the [0/N] cover letter), > but it's more reliable to add it to the changelog yourself. Right, will do this next time. > As to when I upstream this: don't know - that depends on the > user-visible-effects thing. Looks like there's no bug to fix after all as per comments by Alexander. Thanks!