From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97133E77188 for ; Wed, 15 Jan 2025 01:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2232F6B007B; Tue, 14 Jan 2025 20:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D37B6B0082; Tue, 14 Jan 2025 20:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 074246B0083; Tue, 14 Jan 2025 20:45:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E4D876B007B for ; Tue, 14 Jan 2025 20:45:22 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8629AAE53E for ; Wed, 15 Jan 2025 01:45:22 +0000 (UTC) X-FDA: 83007993684.07.0EAE058 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf18.hostedemail.com (Postfix) with ESMTP id 9BECB1C0012 for ; Wed, 15 Jan 2025 01:45:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ga7fmdS6; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736905520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XgmjFYpiTgYIuyIBFMXIOV1VwCqRUL0ypQNex6Ys2Vs=; b=sWBYQR0v/lYoRIxipFIo/JTVS/XBaTDBQc2kggR5BWzx/2zk4I40ZhXvUpSgeOBGdlSyVU cU0JUTLpDlUuJVB0Ic2a8OjTtm5yrok4ZkNkMVn+fRpnPv33d9qetYt2ALtnChYB0v8Rp8 +hUGB9JaNpcymF0Euk/sOSxRFgwJn7s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ga7fmdS6; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736905520; a=rsa-sha256; cv=none; b=o3TBwnU420pQyqW7Jj/DdB9PmCJCxpvhMbHI75Otnjp1xPDszp67eNLp/RcMyAuh8OCAos YBEKDVRaXTuMxWgL03KK1U6gVXCyVqtHllShXdPBzBi12VReQrGP8QE3JWrS00m/zOebO2 gBApoV0xEIlzoROzKFiJ/vdJaXrfz5M= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3863c36a731so4552567f8f.1 for ; Tue, 14 Jan 2025 17:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736905519; x=1737510319; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XgmjFYpiTgYIuyIBFMXIOV1VwCqRUL0ypQNex6Ys2Vs=; b=ga7fmdS6ARJcyok3pLc+WGdkbzrxeS/toDTMNN38Z6A1FaSSilUzDIlvq51K13zY8D D8gDaQvYJZeE0yRY4la9ZJRKT/B+lXuIQ/9lWYUqYiWAxdnCxTuYZpaLQGEi47urzYkt /xepqUaEwV+Ib/T95+f0NpYUJGKuY7SCfCHKSiZ+3lWy+ly+104k+LTfGDcYxQ1zVYe1 NDmRMWBRYRe5MBJyk/NXkWza7sqhPoYC4Xfw/90ktrsFI03rePRVXnXiolNGxUoInKLv w8Esgztn7SY3/AV/XUnuXZh9J+1N8rCkHc+IcisZglpIHimZ55DN3w+U03/J8b1Hmsg5 D4ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736905519; x=1737510319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XgmjFYpiTgYIuyIBFMXIOV1VwCqRUL0ypQNex6Ys2Vs=; b=ai7NBHfmTjDSNDy8U8Rh9wJvCcQ9Cj7iPiTnvME6NhUz0YcP0cNHw6d0rfXO9UtOHQ 2udj9Q7BtNB0HPUk1T7MPMwz8Geajv3PYUsAsE+mJet0jR6hXKEz9SD4FMKlbISQ2xfZ KY+bLTvfXozaulY90GTqv8pyzZ2FnquPq0KbaxSNINJ1YevQhfeBSOxWBjJvpuNzLaNI bxsRECOAlBqDUDCxcjdQrehi1c4Gqgmu5wtU6Wcby5eEpwbUsH0GF+n1+PbS7+HHVBrp yHRU8KJdcO+52IItj3gxLIbRrFwWGPs2On/ihBe/5AB2Q6PmE7tiEL36RvWMG2E1s2rv DfBA== X-Forwarded-Encrypted: i=1; AJvYcCWp7xn80kKtGgKADMdJCv1bWgcuIiyryj4MNEUJ4GVvNaHE9Whqv4hBwsSed+qi4FhuSMwb+qtebg==@kvack.org X-Gm-Message-State: AOJu0YzDyyYSvX0IlbNPXYCk8F6RXpkQnFyGQawJLuuBklNGxxJlQaTf zSW3GJk6QrQigQRMILMkM8LboAuUr2dAyBNu2QuuqW17KmLQA0o8L+gsDInAgFBZsRz/rZvPIVB 5gN6kGQApT2XPYtdOkKDsguno+Ek= X-Gm-Gg: ASbGncsz08ADW7787Sfl/92xKb8EQzTbq63LzXC0Wc5BCgr67o4gRwO+s0PnSAfO78E U0igWjxstcETjMnco7MDBQZ254dnHfpGmReb5P3HF X-Google-Smtp-Source: AGHT+IEe5HV14nfM+RWkdIGwlPTLNuikEgv3E7zSq3poCR9tymjFJrXI+gzkm2UOxK818mfrCHr13WMyYPhoYuFBvG0= X-Received: by 2002:a05:6000:1564:b0:38a:8c9f:dd61 with SMTP id ffacd0b85a97d-38a8c9fdeeamr21864164f8f.46.1736905518920; Tue, 14 Jan 2025 17:45:18 -0800 (PST) MIME-Version: 1.0 References: <20250114150935.780869-2-thorsten.blum@linux.dev> In-Reply-To: <20250114150935.780869-2-thorsten.blum@linux.dev> From: Andrey Konovalov Date: Wed, 15 Jan 2025 02:45:08 +0100 X-Gm-Features: AbW1kvbYwGqcyC4Y6wXhnrzsnvagjrxrvLFifv8r0TYXBLZmPekoNR3JilBliOk Message-ID: Subject: Re: [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags() To: Thorsten Blum Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: xroqyuocyc9h76onnnq5pju1tk3ndu46 X-Rspamd-Queue-Id: 9BECB1C0012 X-Rspam-User: X-HE-Tag: 1736905520-628523 X-HE-Meta: U2FsdGVkX1/LG/O4oOsrTUasPO18GnsQZ4si4abAnufZ04ABItuCWpBRafBIJERklLIxoZ8Sds7Vl00R9DlFpkq+W2Skx+ZiABj0Kl5BH3NJ/M1OmrHgxm6tvPnz880RstJKsTpRHGbstmY9okLBwkl7vVOxgJ9Bq7X81AK15YRAHX5812OwuUElBS6qdKOJ+betNxh+CSsLpvUWPzWCxNI1SmGv7cwzVZ+ETSLzl3qXHoL+VMiNb7b8Pz4/F+Cf5VXCuG038cPZyaggNWwLuRdkQHJqMRSjo1E1/LXx7oMc4D7ZmITtxjCiL0BdZxtLtEXl585qF2pZRHjO5qJ+41bHHovloAED2J0q9Z+J87NBN9Lt80X+fzISwBqi0bW0ozEHOG4EiPDwpy078v2BH8cQUXp/6BzIqqrJQ7FFURBm/SNoqOwjT5sFmv6BW2AVPg4exjGnj1YWfGIaLcXspD5gCmLJcCZs2+tIxK//toau5TK7xJ1nwdiPW8a5qmDlBv8zw2sgzI2E0dneyqPPfK/CwhSa0Evx7gYhvsaK+xNwQS/aeoXOVMlrxfzX6MuErGWnuBsibif3ha32f2DbuOtrE9ahby1cszcsgSZuRNtTkNsGAlO3uSvw+JhWld/ShCBO0+TeF3aer/NHFqv+qeFRAET2Ln5RcdXDoTLXpSTKXTSI1hOyRXEF6NV2feKJijM3wdsv5umCaZG67qUSkK+I93Y8Qo16H6DuBrKPK72Y/26DE3dUVuY34JY5hg0r08Hx1iSh9pxhAvT4XeVL0iFmh9HMw11hxHxQSfJWckdPstJyDftiqB4WXB16PolzkD78sj+aPMdQaVHb91/TsZhCWIIubJEDWlTiu3nPLTjbSrIV1uwPtr4QUC7cEpdgccSh+WFc9zFuNSaM/3dDgfT0W4otsoUqzWc59HOV8ZmGjtJPZ4LKfCqM6i6+taxv0ArRUDIQqJ7Y629bm9+ sPA+RxoF mTvWqDYYYybgNwo+StmPLWVMt6WkT9/DyhusxSO9hgvXgZ2wrsVN1IYHp7lXf+kAcbgc2f3h4qY+yxUrE6DISfNGb7AeXX6WyqUv9aR3Q6+5FQ0iq73bdm8ns+ThnEkNNKe3gy7iT8M1F0Yl0uWnMyvTU/GrtbXkUTuzSmQQIeO0xhb3rG1m7AjYrj/Hr4yf3+pAkHNcAC1IWuizRKCT2bnbbsX+wcF2H/WBjmBndb84Kqh8TXlCJ2HXN46koh8A0J8Is7fHQ1bAUa71SkeyTy/0bANKR2lC5R0tMVYSRETv1cmZzY5awQAEuhgB7xb10ki+Ve8dLXRyzniB+RaQwFU3nMGNS9XlO7RML9AjMLOTCkd9moGoS/PFGk0hqhLb+oq2O805zct+wdzEnGhyjhlnrrDGQ7ZT8TxAf6VWpvj1//bMLM6ubc7d4YOsd4R2ta5WnK1aFogHzYDeQ+LUGT5ws6v++KqEaaCLhmnKojBjyqOvKqxMllOfOxUw7Ol2tXWHQnDJFwK7jQSs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 4:10=E2=80=AFPM Thorsten Blum wrote: > > Remove hard-coded strings by using the str_on_off() helper function. > > Suggested-by: Anshuman Khandual > Signed-off-by: Thorsten Blum > --- > mm/kasan/hw_tags.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index ccd66c7a4081..9a6927394b54 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -263,8 +264,8 @@ void __init kasan_init_hw_tags(void) > > pr_info("KernelAddressSanitizer initialized (hw-tags, mode=3D%s, = vmalloc=3D%s, stacktrace=3D%s)\n", > kasan_mode_info(), > - kasan_vmalloc_enabled() ? "on" : "off", > - kasan_stack_collection_enabled() ? "on" : "off"); > + str_on_off(kasan_vmalloc_enabled()), > + str_on_off(kasan_stack_collection_enabled())); > } > > #ifdef CONFIG_KASAN_VMALLOC > -- > 2.47.1 > Reviewed-by: Andrey Konovalov Thanks!