From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F83DC4338F for ; Thu, 12 Aug 2021 12:55:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 76F3F610A4 for ; Thu, 12 Aug 2021 12:55:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 76F3F610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DEA328D0006; Thu, 12 Aug 2021 08:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA3158D0002; Thu, 12 Aug 2021 08:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89C18D0006; Thu, 12 Aug 2021 08:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id AF55C8D0002 for ; Thu, 12 Aug 2021 08:55:29 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A430824999B for ; Thu, 12 Aug 2021 12:55:29 +0000 (UTC) X-FDA: 78466424778.40.1E27383 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 1D53D6014DCE for ; Thu, 12 Aug 2021 12:55:28 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id z20so11388470ejf.5 for ; Thu, 12 Aug 2021 05:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hetAWS8vJTkbvJ1Yuh2ecULwYt0HQ0q3zS2e3QmOOk0=; b=VX3lXUncEAiMWCQXnnXyzQhXlgIUCn+99sQZAdcGcSPeCwxoiBQLOYxunMYCp2evFy PvDkaahs2fIVWzYkjnfhqbuT/TcmSgbaRkPDb4/gXnbSiXAHh+q/HnERGAinmqLS6Z0s 2nqvrzAq2/PAi5rpwaOdTGc+2B9oPKwBy+xyeSL6nEAbvcgKGZMkdIT+Npq4HeHqU4NR Ro5GOsX/6ci3aDRIg+zaloKpMkD08g1hXxTdo9pZzGp14KV/8bx+DC72UUAtDAOQJKxM uwkBkhURpaVyyIGy9UYYIepFjRFXXsI9BEAsjiFRyz+VCdDKsFXzjC9P2SLrLM5h4891 yZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hetAWS8vJTkbvJ1Yuh2ecULwYt0HQ0q3zS2e3QmOOk0=; b=YWB5exOIftlNfs/VuNymZcJEgQFnADH9SVfFhK23UlfafYnNAiw/dPrGGgsE42bkk1 tuNQ3yLdr+2fqlf29ehjnwEgkcsUXm61wHR4U/Rdtf3nhDmX+UgsrHSGwQKYPZVgOVXS xp1vAlTrhBynt77XfgDEytTSvHxflB45F223h5djxDlwzzETu/CK8csQ3yFqjnOSTjhQ TvI9zACqGXGKHABdEYLpp6lQnizDSYUKWSfF+V+JFt88nUb2xAlV+H+/zUCIrZTLgb3h 7rfxKP9YqrloUNkwwcAbW/Dc6LYoRJ/W94nw1OgkJMcvTGlJ788E8aafxzu7m8uTGSpd XZnw== X-Gm-Message-State: AOAM531qrjRapalSe1PE1zyY8M0PPwXohjmvLvABOYgTgHP2taVFE3qx hQ4PFQNf9+Ytg28sJTgs+yW7CFY4sV4Pp38V1KA= X-Google-Smtp-Source: ABdhPJwUGAz+StzvFe3sEKadoMqkzkGxIfpbIgPqcHNBMpIUdAiRvhJvJxHF1csdmHpux4meRLpWTdAZ/DWt3/yVCko= X-Received: by 2002:a17:906:d147:: with SMTP id br7mr3613564ejb.126.1628772927836; Thu, 12 Aug 2021 05:55:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 12 Aug 2021 14:55:16 +0200 Message-ID: Subject: Re: [PATCH 3/8] kasan: test: avoid corrupting memory via memset To: Marco Elver Cc: andrey.konovalov@linux.dev, Andrew Morton , Andrey Ryabinin , Dmitry Vyukov , Alexander Potapenko , kasan-dev , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1D53D6014DCE Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=VX3lXUnc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: jow6rwai6363duup5cwn9q87suqokimb X-HE-Tag: 1628772928-501862 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 12, 2021 at 10:57 AM Marco Elver wrote: > > On Wed, 11 Aug 2021 at 21:21, wrote: > > From: Andrey Konovalov > > > > kmalloc_oob_memset_*() tests do writes past the allocated objects. > > As the result, they corrupt memory, which might lead to crashes with the > > HW_TAGS mode, as it neither uses quarantine nor redzones. > > > > Adjust the tests to only write memory within the aligned kmalloc objects. > > > > Signed-off-by: Andrey Konovalov > > --- > > lib/test_kasan.c | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > index c82a82eb5393..fd00cd35e82c 100644 > > --- a/lib/test_kasan.c > > +++ b/lib/test_kasan.c > > @@ -431,61 +431,61 @@ static void kmalloc_uaf_16(struct kunit *test) > > static void kmalloc_oob_memset_2(struct kunit *test) > > { > > char *ptr; > > - size_t size = 8; > > + size_t size = 128 - KASAN_GRANULE_SIZE; > > > > ptr = kmalloc(size, GFP_KERNEL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > > > > - KUNIT_EXPECT_KASAN_FAIL(test, memset(ptr + 7 + OOB_TAG_OFF, 0, 2)); > > + KUNIT_EXPECT_KASAN_FAIL(test, memset(ptr + size, 0, 2)); > > I think one important aspect of these tests in generic mode is that > the written range touches both valid and invalid memory. I think that > was meant to test any explicit instrumentation isn't just looking at > the starting address, but at the whole range. Good point! > It seems that with these changes that is no longer tested. Could we > somehow make it still test that? Yes, will do in v2. Thanks, Marco!