From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0318DC282EC for ; Tue, 18 Mar 2025 15:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC27C280004; Tue, 18 Mar 2025 11:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7034280001; Tue, 18 Mar 2025 11:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEB6F280004; Tue, 18 Mar 2025 11:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE5A0280001 for ; Tue, 18 Mar 2025 11:33:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F2C2416143A for ; Tue, 18 Mar 2025 15:33:07 +0000 (UTC) X-FDA: 83235065214.12.AB1658A Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf01.hostedemail.com (Postfix) with ESMTP id 01A194001F for ; Tue, 18 Mar 2025 15:33:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IRpmDRLe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742311986; a=rsa-sha256; cv=none; b=xLSCYbnQL5BjpI2xZu9fCjv+kvkWdfxXqi7ni00Jfn4TEtlk9BqvahwSYfPwtrxukf6H58 s7SY4mW3DXMpdsbN7uoLJPCLNxbQ0lu9GBxnQH69nJCWr41ei5gZndKKNRg9RZgwoqQJbo wuCuk0qOxfUoaD9GY25yKLnUlf3mXzk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IRpmDRLe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742311986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pQedOYF0JbGhNTsRLu/QrPIdEyMAq9Lyufwf1HjqHkU=; b=mi96S16k+HDtqy+aodMnxXEKi883DRLgR3B9aJe3Gfas2fXAFkD00X79um03F20r+62hnj WSKb/S07TYt2QS2UGnOLYWrXC0vY1BRdmOFVSZyRndOVtx6S6V7lwqMfG9nWp/qlxpuWa3 sS7UW98MPqqiDVd3rlT0mwsWfQIXZAo= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-394780e98easo3792112f8f.1 for ; Tue, 18 Mar 2025 08:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742311984; x=1742916784; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pQedOYF0JbGhNTsRLu/QrPIdEyMAq9Lyufwf1HjqHkU=; b=IRpmDRLeB9KwdEbEGm4TzUAfJsZKPiedGns3kTy+Bji5y67bu+D2WYza0Y/5RZfhHS 6WpiAFqGuZDXdLPzJkdT+tIiLytGPyA2iBfE3ABo+hJe1rjytyMLKZd1sS0stFFXOIzQ Vbp10LcCUzX4w1/7AHFWpXCPE7UtiiQx3nO2BIrmxHsA36QdoI2W9uclMn9oOeoHK29p r5MLrKtpOD87QrgwK6jjseMv0wC2X0el93NNX09/kvB0jWy9/ktEvNjapLkO60sb47ro 1djClfFwZe788hQrD+Na9E5aLZZGvcBpPs9YUofKmWOCptfQscFvTluRVbqKoFh5yYNB oxAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742311984; x=1742916784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQedOYF0JbGhNTsRLu/QrPIdEyMAq9Lyufwf1HjqHkU=; b=Z0QMzaTtdxx4UcdT0LnHu3qhzo9Dnj871ti2qZ9CEzSTEGWQe5bez5XIJuz9aMb9zw n9tCi3mEXYQMkVYTzOFUCA3kyfmJZTUs6lfsDG+CcjaXuzVzivwDaYXc2GmEdPQzEYwP JpAqjlNxiFMPmjqbVb2tIJPJYC7Kxso9xh6suoC1jG3ZVML85X62+uDfkb53XJXOjaIX 4YJs3p2bMpAo7clootf8cs7OrU8xGepLs+4BXCT0YVeS9GWYZQDGiykCpTX8lDGzZm09 KezUHFgkcECLs2UxZxuQ5+hS3Q1jLxoBkHAlqHAlRBg+BOZ7y+74b5PKrDiITi+8TlP9 XKcw== X-Forwarded-Encrypted: i=1; AJvYcCVisgrZ8W6PTUNMTRpN9EjSVRy8yYbRK1awRTJnSxHI3lyp/w5JucXW5h2Jg8R8u/dyTQE/bissVw==@kvack.org X-Gm-Message-State: AOJu0YzkJNHnhwfugEAD66Ajw8G25iR9L1x3XMRQcf5djPXOA+h1mK68 dCACrKkFmDgUtq3+25lqOoPKAHrhGuNpPJuyI9RL435lgnmKRmYK6qRhoC6KyP5fuwGiGvp1U1G 9rfiBGAi8sbIz+lbhhu2x2OBgBEg= X-Gm-Gg: ASbGncvEyMRo7MMWGP+3v4EZpTKqKfESSqd3EluWmw3qHbtcensFFnO474caAG//51G PmOWHW0NUi/lGswSoRCzA5o7kY4XDtJqIJWAQN/7/XJ8gu+y5nU/215dIQ7AhfO7iQkxdTpUoxK CF7Aq1yE+q/qsCohun7JYPlCpgS+HtBB5kxoq/8Q== X-Google-Smtp-Source: AGHT+IHtUbfef6AuENuUNXTiGbXJ9bAjThV0ug/y6ZpFhUtc+q5kR5UByEL96jx8QrkNeGx+D5z+NN5m4va1bqJ78dA= X-Received: by 2002:a05:6000:402c:b0:38f:37f3:5ca9 with SMTP id ffacd0b85a97d-3996b4a1f12mr3500096f8f.50.1742311984401; Tue, 18 Mar 2025 08:33:04 -0700 (PDT) MIME-Version: 1.0 References: <20250318015926.1629748-1-harry.yoo@oracle.com> In-Reply-To: <20250318015926.1629748-1-harry.yoo@oracle.com> From: Andrey Konovalov Date: Tue, 18 Mar 2025 16:32:53 +0100 X-Gm-Features: AQ5f1Jp2LdhedIBpqplA-ibdx9fucHDmyRIqhF4hweSMbvA5brq57w8VLaw2NDA Message-ID: Subject: Re: [PATCH mm-unstable] mm/kasan: use SLAB_NO_MERGE flag instead of an empty constructor To: Harry Yoo Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 01A194001F X-Stat-Signature: 9wxyh53gk9w5mq5juay11khrhai8az8p X-Rspamd-Server: rspam06 X-HE-Tag: 1742311985-600197 X-HE-Meta: U2FsdGVkX185DENU3M3A7N0ySGvkULNJByywx8wrJgHdl6L3bvxrYuRQpSwkuHQ4MPT22MyUNKiiemNQht2ciK1tNUC+0n1HLu3nLRRpU/0LHKd1n2EbnADkmnLEJ8sgnHuYOOVBZQnPZOfL5EZGpM3pibY+KUtgEgB+0u/ueO8Heu1ZCZVyZe36BhGrPnjj0mov5l6IMr+ZkxLXrz1atpwPt/An3B0S+jWD4aK5VvNi2yGQsXXKMujZ1lZ9EoRWHzjqqNyi+zJplxrRFBfLW2yl/Kk/z2/xYxzIk58WDlWXRWUXpelti43W2NGC9ign0rO4eHfAJa+UcTaI1sjHk6xB348MILFd5mjBTR17fOAJ3RyLW+pV9nK6m30vlCmahdfyz1/nYUFtAJBXIgGP/OHA877UvwDH3kKk7O1Dx28tPgEX9nheDYNWPQdjhz+OIVRLRNv0cbN0XDKEqh5eU8QFv0V5WknXur6vGB4uZRZdijPul6K/q+4khml2szPK+FUiX1SiiBS8Nex51tpVbgoOb8JLmdZty4m9y/T13q4Klgth66GzL1Q1gklpM3vFAAgi0tgkjrTO7bmCGt1bejfTB3vwNj/wUiJbgHkv37L1Pl6CnAolxU1t+e7pvFU4vVqKUweTK7MipO7vgXlsOkj0Z+D44mvsHt34Jk/C2Fa+C4lR8/qEcb7Y9y9U1uEFiwAhijyaw8IHgtsDsc50KU1RT41uWFc09nLyYJ+AQpT/zULJYHW4VWnNxKYiDMnW1ZqItkX+ODrfnAJw1Y5AHUk7ikHppKtT3cOec5FZOtkkfHaUbWtWINoMXM4DYLsLh6elolTPFQhoJCkmFMw8wyNXYFAYF56lHedHFzMIaYusKMCwyRDzod8PGWXMAoRY6icNq4yFrmE+7sOAoSNMbRn7VW9CUzPmrx/9+bv39kgY0BtJWlU4Looac8mfFRewk2Kna8v17bXXq7u0ZfU zySDcBiX NfgofOP8+eKy/ob5KakkovQoRbpaNPVWaF3K01SOaWtU8XJEqk/QFKS+xkcZiO0cQfTd8qa/Ji3cstkFz9rNhX2+/m1Zvyg9hNTWTZeDI94ZtxOM8g1HrVwxN6ugMejZygfVdK7wkWJRDzrnKlb7/Lu8Jqer8FuOFPLZns1VDVVwdxPNbNx/wAToNvMO8n9tKZKZ1zdp7m7pRZ+V/Lu0vY4yfrS7jtbhiSsy83w4HkZOwbcpv6plzYjvu42MMA7nH+25TJEzcin8YyYhIKPlGPz8r2FabKDywTMy9A6oHvjJDJ052C4vvU9R9NImD7N9HPNgjgVIxO24tgMtsjsy6r+EjQkULTDaxaKJg1AyMBBcJ5aNLIbabZCqqMjiy8/GCoBii9d6QjBi5kDyWv4FXYnjxwn1FC3biVGG/19kFqB1qWovPEcyJHNyaNPfOiCXBiqHP7Kfkj26DftQzsSuZQChB5EyJshFs3viEey5uYhh2pOY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 2:59=E2=80=AFAM Harry Yoo wr= ote: > > Use SLAB_NO_MERGE flag to prevent merging instead of providing an > empty constructor. Using an empty constructor in this manner is an abuse > of slab interface. > > The SLAB_NO_MERGE flag should be used with caution, but in this case, > it is acceptable as the cache is intended solely for debugging purposes. > > No functional changes intended. > > Signed-off-by: Harry Yoo > --- > mm/kasan/kasan_test_c.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c > index 59d673400085..3ea317837c2d 100644 > --- a/mm/kasan/kasan_test_c.c > +++ b/mm/kasan/kasan_test_c.c > @@ -1073,14 +1073,11 @@ static void kmem_cache_rcu_uaf(struct kunit *test= ) > kmem_cache_destroy(cache); > } > > -static void empty_cache_ctor(void *object) { } > - > static void kmem_cache_double_destroy(struct kunit *test) > { > struct kmem_cache *cache; > > - /* Provide a constructor to prevent cache merging. */ > - cache =3D kmem_cache_create("test_cache", 200, 0, 0, empty_cache_= ctor); > + cache =3D kmem_cache_create("test_cache", 200, 0, SLAB_NO_MERGE, = NULL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > kmem_cache_destroy(cache); > KUNIT_EXPECT_KASAN_FAIL(test, kmem_cache_destroy(cache)); > -- > 2.43.0 > Reviewed-by: Andrey Konovalov Thanks!