From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0DEE6F095 for ; Fri, 1 Nov 2024 23:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A9696B009F; Fri, 1 Nov 2024 19:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 258D96B00A1; Fri, 1 Nov 2024 19:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F9EB6B00A2; Fri, 1 Nov 2024 19:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E815A6B009F for ; Fri, 1 Nov 2024 19:38:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9705AACAF8 for ; Fri, 1 Nov 2024 23:38:39 +0000 (UTC) X-FDA: 82739142654.11.C2DD320 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf01.hostedemail.com (Postfix) with ESMTP id 2964540013 for ; Fri, 1 Nov 2024 23:38:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hOiAtVzn; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730504138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z5rcjHrmlWR+LzcpKryq3ZwD/HvuZwE0xyR9heRD69s=; b=bvsGvuG9tvJkGr9e3eN7UvwCfw0gnPC0Q6zCaeigEmFBjKrCXUdIOC2/gbTTM3G1FymC0s 9zbW7TvQc9T5sKopfZjfU1sdu5MfHXW7DxsvMMRGqyatT6A+s/s1Yw1sxiZGoMiv4b+Yh6 WX2JXi/bnXkgFgAx34AZd0xS/6+8NXw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hOiAtVzn; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730504138; a=rsa-sha256; cv=none; b=T8ZdvhIFTOvNocoubNBTRNxvT1j8d9OcS/Kj2QrEO4bk0OrRYHKfqT70FzWG8ZuaSif9FZ f5j64Qo9bNK0rqQ8JPdZR/SjmRqM8gyT/Yz9eBxs2J/pwLXUMthgHhqaCXvv6uO0Y+WX0X maTCQ6wdiy77Ztju6L9mgYyyHICglOg= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4315df7b43fso19608515e9.0 for ; Fri, 01 Nov 2024 16:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730504316; x=1731109116; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z5rcjHrmlWR+LzcpKryq3ZwD/HvuZwE0xyR9heRD69s=; b=hOiAtVznal3gvmBWvC3fwpSvJLm1Fy6OuCq/prmk4kAQalmk3HOvk6FZGd/AbVCQiP Ao6M7IrkKPs7IN5xTpa+WkooLdAhHYcbs6EuCR5zr/ZYUSMgSnWaERCd2yjqHLgWUYlT mkQ2ogGsQHx+lUS9Mj9m8Cf1N0Yyh0me69tw59G/qg7fsAiC7PHQwXm9RGaihoXeotUV l7mZyKrCqIGIXza4YXaL3Xs7ljzPqrxOleZzIcRcVGhVHISU8AICTKrr0BOmi/6O/8PC D+EbVBuy7EqW9/c6QrzhriWT5dheARbSysSZcg4LsuK3K8FtvJ4tJIbPKYMmze9kwnds S1ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730504316; x=1731109116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z5rcjHrmlWR+LzcpKryq3ZwD/HvuZwE0xyR9heRD69s=; b=t3c9rEIe//9xegk9DtpSzodowAsWdKaBP98H18zkCmaazYP0orD783XXNqguAalOLB ldB5GjRl4Eniea4GJz0ZC6cRmnOkeB6R1042wWe+wFsH03ra7cByw8C1dQXEgSSflmlK IaztKZje3hs5ExWiAvzczUwL0QL/ZocMzIheKwJjMTgZ+zIvlgsX4oTNjyEJo1T2oVcB POWbXFqcp/amGkS0MqmxBEa7bqzBgLvEbRiZdCnU/0bOhhbQXr3ALfnmpNqztejmbl35 8mVntml8uS2dvr4/fXQCkbJaivDys9wM5f6m3tLc0Ve+w4VgzYoWSo32SO9QkzFAOh8X Arow== X-Forwarded-Encrypted: i=1; AJvYcCXMTWunNLefMhMWrmzCeO9chhurKepdzJDYiqAQ/+29Y1OUvNOJtonfxDOZm/EXcMkJgR6feI3gvg==@kvack.org X-Gm-Message-State: AOJu0YwLsNgB/godlkmPPawset5wKffzOKJueaPurzLxg1yaEodHdckF kh/1KlNK2AewINRx8ZJmLnmNMhc81GHswzDHaOLrc0R5aTrNtCHFmrWTO7upVCloMA4RVLSIaSE V2fj/k1q96mKQmsfJAnnBD6Dsh84= X-Google-Smtp-Source: AGHT+IEVeOhuTN1DkEBQ8XjGr9sip5JeKBjAy4hzGpo17c0t1m1d24S2PEf/M6lGQcJaBNOT2uNkU8x7ObeDEuK3JQM= X-Received: by 2002:a05:600c:1d1c:b0:431:55bf:fe4 with SMTP id 5b1f17b1804b1-431b17365ffmr149672825e9.24.1730504316102; Fri, 01 Nov 2024 16:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20241101184011.3369247-1-snovitoll@gmail.com> <20241101184011.3369247-2-snovitoll@gmail.com> In-Reply-To: <20241101184011.3369247-2-snovitoll@gmail.com> From: Andrey Konovalov Date: Sat, 2 Nov 2024 00:38:25 +0100 Message-ID: Subject: Re: [PATCH 1/2] kasan: use EXPORT_SYMBOL_IF_KUNIT to export symbols To: Sabyrzhan Tasbolatov Cc: ryabinin.a.a@gmail.com, elver@google.com, arnd@kernel.org, glider@google.com, dvyukov@google.com, vincenzo.frascino@arm.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2964540013 X-Stat-Signature: 7oc9wakzkq41fap44k1formn6fiz5kct X-Rspam-User: X-HE-Tag: 1730504294-133945 X-HE-Meta: U2FsdGVkX18wi3kifChAK4bxc4Wnjx9j22BulrUKoFkLFDxFXduzbc0JDGy0mg9fU+kLZevTD+k4pM5um9XqoldiiB2rMfvq+w3EXTV2XRh61ZEmxRE0PSSyeQTQJ2Lck2SlQsIOgeiqCltzT+ezXRAhkqcWcjbsq1mgcjytggiNOZIHjpmrYctbBcPvlVDZzLhDopqWeDunpwHr3TgiCpAZjRp3b7mHy9wYzrUEaoCuIP70INTl1jwHFKMYiO37KPnYZYs4aULgi6d7q3h19SIXmL3d3vVs0XNvwzi5lJ5UGCoQaFzlRTxCqNw3O+077dodumaSfDZ0wVKWJiOmD4SRiJ+TXWXRZ8lgFdxuJwaBTG1Fo+6GnYbAfMRdfziCoUqREaqP1d5wwVvgsoD7Cf7/aqLDbBwJIKCGdX7ako3wReGUhMgH+agbtgo4/v+MXj+iK06wQvKiFJ3pNJ9NuICHOS2/Pt7Z2wZvb2dAVavl9aiDkxCHFIFwp0RLv1IkeYKGqvysbOjfYBohHnUlcJfLsc+v3WYMWLxuAbA9LMjym6RLgEjdT8en/MJzjtoReeGV6em83bSeAJiV56yGURPz7ed2VmfIv6EkwwuqrFwr9igCBM1sVJp/XSyuL4jAV8a78kbGQbA2wZYPYUUCkKgTVS/20YpHghSWfF+pU9Gk1mHI0Ksu6m808yu5icj0HQT/04yZrUXm+tlr5FZQK5VY0/MHbq6JEVmfXpXkwc2H7ht4+7Sb+dtPhceo/qgLs48vkd/p4lJ35GcSTqKaZmB4C0I8qi9b7/X/TZRzipA8H0ASBnqLe0ALTzAw1dYOjW52QjxluJjM4DOtvvvVeIsqZS4bvaG1yqJAC897xtaLxyplxljuycpChjndGD295T+LGxXaXfOv20fMTagPomKM3Gnwh/GWGUHAtuz23BVDhFuXz+4kx8Am/XX+4LZu66oS9bxmTwU6H7cTVkw rUSM8rY+ 887df2L6DShZZj1pZd6eA473ETBDTzQ77RvW4DDBA1X/CQAp2smeUhEFQAysfcUgi5h9vjtaqZcghyf+9WNj9msZwYdWKWmYAh4i081oiaA+RFfLmi7JXAM+kWvEE3y5VckfcjY/oYXuobu33ntksmwGLF5imPuXRWXOoL8RIMDQQh9v7zo51Z9YyiprzwbnpczWWwdBOS2t/aE5/qoTSTCVYQOB49iFWpYjosEy1YDrHq637xTNzGJxNqDpkrdqPjHUZkTSmV8j6OQnk4UIG+nSWeeq9DHEtoe/wbu6lLjLP/baswBkNlhXvJEK2JgMHQhtc7uHKJ75NWL8/MW/Pde7tzKdwOkdU4ochwLR79SGmYcwwCx09jZ7ByxkIktXgHZC1+ZNBdseM8BIiYWISaXx4F3r2VRVUacyd0wjQyE12ZADdMSvN7FRigi2bZjrQFmoUF4h+CyjY6UR3QsRaxDwBd7Y7z/jhhrjVqpDDESYLxps= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 1, 2024 at 7:40=E2=80=AFPM Sabyrzhan Tasbolatov wrote: > > Replace EXPORT_SYMBOL_GPL with EXPORT_SYMBOL_IF_KUNIT to mark the > symbols as visible only if CONFIG_KUNIT is enabled. > > KASAN Kunit test should import the namespace EXPORTED_FOR_KUNIT_TESTING > to use these marked symbols. > > Reported-by: Andrey Konovalov > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D218315 > Signed-off-by: Sabyrzhan Tasbolatov > --- > mm/kasan/hw_tags.c | 7 ++++--- > mm/kasan/kasan_test_c.c | 2 ++ > mm/kasan/report.c | 17 +++++++++-------- > 3 files changed, 15 insertions(+), 11 deletions(-) > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index 9958ebc15d38..ccd66c7a4081 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -8,6 +8,7 @@ > > #define pr_fmt(fmt) "kasan: " fmt > > +#include > #include > #include > #include > @@ -394,12 +395,12 @@ void kasan_enable_hw_tags(void) > > #if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) > > -EXPORT_SYMBOL_GPL(kasan_enable_hw_tags); > +EXPORT_SYMBOL_IF_KUNIT(kasan_enable_hw_tags); > > -void kasan_force_async_fault(void) > +VISIBLE_IF_KUNIT void kasan_force_async_fault(void) > { > hw_force_async_tag_fault(); > } > -EXPORT_SYMBOL_GPL(kasan_force_async_fault); > +EXPORT_SYMBOL_IF_KUNIT(kasan_force_async_fault); > > #endif > diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c > index a181e4780d9d..3e495c09342e 100644 > --- a/mm/kasan/kasan_test_c.c > +++ b/mm/kasan/kasan_test_c.c > @@ -33,6 +33,8 @@ > > #define OOB_TAG_OFF (IS_ENABLED(CONFIG_KASAN_GENERIC) ? 0 : KASAN_GRANUL= E_SIZE) > > +MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING); > + > static bool multishot; > > /* Fields set based on lines observed in the console. */ > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index b48c768acc84..e5bc4e3ee198 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -10,6 +10,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -134,18 +135,18 @@ static bool report_enabled(void) > > #if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) || IS_ENABLED(CONFIG_KASAN_MODUL= E_TEST) > > -bool kasan_save_enable_multi_shot(void) > +VISIBLE_IF_KUNIT bool kasan_save_enable_multi_shot(void) > { > return test_and_set_bit(KASAN_BIT_MULTI_SHOT, &kasan_flags); > } > -EXPORT_SYMBOL_GPL(kasan_save_enable_multi_shot); > +EXPORT_SYMBOL_IF_KUNIT(kasan_save_enable_multi_shot); > > -void kasan_restore_multi_shot(bool enabled) > +VISIBLE_IF_KUNIT void kasan_restore_multi_shot(bool enabled) > { > if (!enabled) > clear_bit(KASAN_BIT_MULTI_SHOT, &kasan_flags); > } > -EXPORT_SYMBOL_GPL(kasan_restore_multi_shot); > +EXPORT_SYMBOL_IF_KUNIT(kasan_restore_multi_shot); > > #endif > > @@ -157,17 +158,17 @@ EXPORT_SYMBOL_GPL(kasan_restore_multi_shot); > */ > static bool kasan_kunit_executing; > > -void kasan_kunit_test_suite_start(void) > +VISIBLE_IF_KUNIT void kasan_kunit_test_suite_start(void) > { > WRITE_ONCE(kasan_kunit_executing, true); > } > -EXPORT_SYMBOL_GPL(kasan_kunit_test_suite_start); > +EXPORT_SYMBOL_IF_KUNIT(kasan_kunit_test_suite_start); > > -void kasan_kunit_test_suite_end(void) > +VISIBLE_IF_KUNIT void kasan_kunit_test_suite_end(void) > { > WRITE_ONCE(kasan_kunit_executing, false); > } > -EXPORT_SYMBOL_GPL(kasan_kunit_test_suite_end); > +EXPORT_SYMBOL_IF_KUNIT(kasan_kunit_test_suite_end); > > static bool kasan_kunit_test_suite_executing(void) > { > -- > 2.34.1 > Reviewed-by: Andrey Konovalov Thank you!