From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B68EC4332F for ; Wed, 19 Oct 2022 19:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA83A6B0072; Wed, 19 Oct 2022 15:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B312D6B0073; Wed, 19 Oct 2022 15:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D1F66B0074; Wed, 19 Oct 2022 15:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 895E56B0072 for ; Wed, 19 Oct 2022 15:48:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4DB71140CE6 for ; Wed, 19 Oct 2022 19:48:54 +0000 (UTC) X-FDA: 80038736988.02.265F19F Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf18.hostedemail.com (Postfix) with ESMTP id DC7881C0007 for ; Wed, 19 Oct 2022 19:48:53 +0000 (UTC) Received: by mail-qk1-f176.google.com with SMTP id d13so11452652qko.5 for ; Wed, 19 Oct 2022 12:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cXqWYGSUyr7OrNHL1T/x/7EkjfHttBM4QCa4eRu5CdE=; b=ox4rhvjtu73vL7Eoxb3ELsaih0GlyG+yB5zAmkNS2KiGxZogVp8NBKoF6fDJ9BzkmB g5m7neSOBU7hxoeYpgeJhyW82i4iUuH+nAkA1889hB4gGWH4W84vgK2aEjqfKIUmw9e2 6KQeu2jyaZbGrHtlleYWE765geA3KCNVdXzxzwVlSMf01m+k+kOLAS12he6YgxdoOX82 rXVagiCyq1Cr/b1T2PqecVmN8w/Y2jDApucHSTERZlg+zPKUq8lW7N0qfzAdtRJFAukt UcCZNp5iz9eOTx0EkWGUMtkEpjXHNVJLVNrndqpioDkYpW6THJL9HVRtB1vn9S37Go8D hl0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cXqWYGSUyr7OrNHL1T/x/7EkjfHttBM4QCa4eRu5CdE=; b=4j+LfR+fZokhBC1AQ2jm9YKi93uNgg2bNoTLa3PGLATeEwhJ4FYKWU4eG1fbZieek+ 6aQoS5sztgmAp8AEpO8l5iUIGKheJxmJaezYxqLY8EFphTDXe3dvmSuq6ny8h+y82KqT Z4dTad0WZKPbC8MQqParEPEteDo2fG9FOwteXeLEnUqNRw1UlE8+UADqAcm0+kryLYyU uaQfOqFKDCuZR0JCGntELaQvGfJ94PTzowIUSGS5uOQvUge9CZUGC9EFs1MtVoOju4pX uP4Wtr0rmOpsBw304SWbjZItgWh/Q4Lo1jHlaPdn6lIXbN5Hw7G5tE+hGMRhBmvSyXTp 6kHg== X-Gm-Message-State: ACrzQf2b7RmZIuBuPHBk/5gwFm/H4xwzRDj2DrjsHg1Y63oTUMCzU5Oe Kz+mRpcP05K6k0fQSFaIec8F4JxBgmlkA+DPCak= X-Google-Smtp-Source: AMsMyM67C5+6trm/g0kHA0nfVIVp7N/QTSeM9dZkG/qfb9srEg8RMwNlyV/8r8K+waGxTBLgd71QtUJMHNv6t+Se0ks= X-Received: by 2002:a05:620a:d94:b0:6bc:5a8c:3168 with SMTP id q20-20020a05620a0d9400b006bc5a8c3168mr6743224qkl.56.1666208933104; Wed, 19 Oct 2022 12:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20221019085747.3810920-1-davidgow@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 19 Oct 2022 21:48:42 +0200 Message-ID: Subject: Re: [PATCH] kasan: Enable KUnit integration whenever CONFIG_KUNIT is enabled To: David Gow Cc: Andrey Konovalov , Alexander Potapenko , Andrey Ryabinin , Dmitry Vyukov , Andrew Morton , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Daniel Latypov , Brendan Higgins , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666208933; a=rsa-sha256; cv=none; b=1WwFAS7ZzrhZ2WgqTeT1TZnV0LLEcxJkjufUlDs0T98heo/9qg1FUQhGamS+Cd3XgAkfqw Fzn9IOI2btIes5e5Kc31b25eAjoNCNf7miNDNtcUiSRtmYlUce93YCuFkNrKrpa92JDZXh m0zRXTNs8b0mGui9/gOr/PiYjmDWEsM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ox4rhvjt; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666208933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cXqWYGSUyr7OrNHL1T/x/7EkjfHttBM4QCa4eRu5CdE=; b=8cTBmQxsj/zN9Dw/ffcWYpjE/Z2pQTJp6OBqs53jXWmwmNQAgIUnSowE3FdvQyo6kYFCdK miaM25DvgQU7/Oe790qJSMtK0P3xdOU6vmw5LTsgZ8lKGp4xkYPx0Fex2Xi9KMX8jNcI5R n/AXWJkNve8Lv3bAA4KphmlOqJLHdYo= X-Stat-Signature: r8rf3zp5snodcr6d6ekknm8fdh6tmbjz X-Rspamd-Queue-Id: DC7881C0007 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ox4rhvjt; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1666208933-957218 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 19, 2022 at 5:06 PM David Gow wrote: > > > How does KUnit detect a KASAN failure for other tests than the KASAN > > ones? I thought this was only implemented for KASAN tests. At least, I > > don't see any code querying kunit_kasan_status outside of KASAN tests. > > Yeah, there aren't any other tests which set up a "kasan_status" > resource to expect specific failures, but we still want the fallback > call to kunit_set_failure() so that any test which causes a KASAN > report will fail: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/kasan/report.c#n130 Ah, right. Thanks for the explanation! > > I'm currently switching KASAN tests from using KUnit resources to > > console tracepoints [1], and those patches will be in conflict with > > yours. > > Ah, sorry -- I'd seen these go past, and totally forgot about them! I > think all we really want to keep is the ability to fail tests if a > KASAN report occurs. The tricky bit is then disabling that for the > KASAN tests, so that they can have "expected" failures. I wonder what's the best solution to support this, assuming KASAN tests are switched to using tracepoints... I guess we could still keep the per-task KUnit flag, and only use it for non-KASAN tests. However, they will still suffer from the same issue tracepoints solve for KASAN tests: if a bug is triggered in a context other than the current task, the test will succeed.