linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@gmail.com>
To: David Gow <davidgow@google.com>
Cc: Marco Elver <elver@google.com>,
	Alexander Potapenko <glider@google.com>,
	 Dmitry Vyukov <dvyukov@google.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	kasan-dev@googlegroups.com,
	 Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	Andrey Konovalov <andreyknvl@google.com>,
	 andrey.konovalov@linux.dev
Subject: Re: [PATCH mm] kasan: fail non-kasan KUnit tests on KASAN reports
Date: Sat, 26 Nov 2022 19:16:17 +0100	[thread overview]
Message-ID: <CA+fCnZceUx+Vqj7nUPiLrexnmU11KkGGtJ3-9KfXm336e+cv3w@mail.gmail.com> (raw)
In-Reply-To: <655fd7e303b852809d3a8167d28091429f969c73.1669486407.git.andreyknvl@google.com>

On Sat, Nov 26, 2022 at 7:15 PM <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> After the recent changes done to KUnit-enabled KASAN tests, non-KASAN KUnit
> tests stopped being failed when KASAN report is detected.
>
> Recover that property by failing the currently running non-KASAN KUnit test
> when KASAN detects and prints a report for a bad memory access.
>
> Note that if the bad accesses happened in a kernel thread that doesn't
> have a reference to the currently running KUnit-test available via
> current->kunit_test, the test won't be failed. This is a limitation of
> KUnit, which doesn't yet provide a thread-agnostic way to find the
> reference to the currenly running test.
>
> Fixes: 49d9977ac909 ("kasan: check CONFIG_KASAN_KUNIT_TEST instead of CONFIG_KUNIT")
> Fixes: 7f29493ba529 ("kasan: switch kunit tests to console tracepoints")
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Hi David,

Could you please check whether this patch resolves the issue with
non-KASAN KUnit tests for you?

Thank you!


  reply	other threads:[~2022-11-26 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26 18:15 andrey.konovalov
2022-11-26 18:16 ` Andrey Konovalov [this message]
2022-11-26 23:44 ` kernel test robot
2022-11-26 23:54 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+fCnZceUx+Vqj7nUPiLrexnmU11KkGGtJ3-9KfXm336e+cv3w@mail.gmail.com \
    --to=andreyknvl@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrey.konovalov@linux.dev \
    --cc=andreyknvl@google.com \
    --cc=davidgow@google.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryabinin.a.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox