From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A987C3DA7F for ; Fri, 2 Aug 2024 22:40:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0246B0088; Fri, 2 Aug 2024 18:40:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 714726B0089; Fri, 2 Aug 2024 18:40:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6E46B008A; Fri, 2 Aug 2024 18:40:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 309106B0088 for ; Fri, 2 Aug 2024 18:40:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6225EA7D86 for ; Fri, 2 Aug 2024 22:40:52 +0000 (UTC) X-FDA: 82408776744.17.AB15D8F Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf15.hostedemail.com (Postfix) with ESMTP id 8BD29A0017 for ; Fri, 2 Aug 2024 22:40:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CfCeYj6S; spf=pass (imf15.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722638392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/AS4PCqiOdbZ+esYBLs/r2lwVfepCVbyBq4ZGB7mHqg=; b=om0j21R8bgsomSxybIITXe0MHt1SP6OUlVZ5tWDUCU8cYjq4CfpLvgTNLJdaDwChOiwdd8 /Ndm46CLc664tj8LemRNNU7uPmxczjr5bOaktnZnnF7t1E2DIwEdtNTi+I9c2g37qOTJzZ q9ecQZLZHinPFQVHtOma5KVeghoNjoE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722638392; a=rsa-sha256; cv=none; b=Fl/UHp2DqmjKv4HTBTpqjfh+D9wxXsae3HVwPbcWHxHLdiOy9eer/w/EmTMK87CnAwZYpP gCEq2kQJBhLVckS6YQ5meHVPQGu4tHvMNiJBSesjBTHOU3Qu33NeWqsWIb1I3X/fwUhw2/ tHcTZXnDYxYZleVOrD+BIrvvEQ05r3o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CfCeYj6S; spf=pass (imf15.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-36bcc168cdaso248561f8f.0 for ; Fri, 02 Aug 2024 15:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722638449; x=1723243249; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/AS4PCqiOdbZ+esYBLs/r2lwVfepCVbyBq4ZGB7mHqg=; b=CfCeYj6SoY2oZ0AxPARxDNNd0ss77zqSd013K1gyVuXdTTh0aIufp9xNLBpZiasVFB 4CAdYMESSwztbr2D+HeGmzLP517a2U3rNgFtKVKJYRpq0KYC2CZ8yThV7+rfwvYAvns1 9tmpA9bK3qw4OB17lENnYkQ4O9ZkfCKl+PBytnHzAkZ6GEyqunzeIt9vw0sNlZDREX6n Yzuqep7dwsNXcsia/vqp3srKU9nOEIIiKECgaQtOjqjt0ys45wyB14JTna9Xt3T2PRcw PWWC9QI+SApc7p0h6NAWJIAw2u+IJ81G4Dgu/WmCS1eKDDaotoZEaAsilPQuyUlyKaO8 kkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722638449; x=1723243249; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/AS4PCqiOdbZ+esYBLs/r2lwVfepCVbyBq4ZGB7mHqg=; b=sAzYWUMx82lQGYni6wae3Oowa3JPLfqvOdMcvdOZqzX/f4brqp/sXxp7y87cCYryeB XRNngmsJkhIUhmw6CVHPWB7tYKIfu2/ZSuUaX2UnGAXJOCx3RER0gI4ltJpO9a8wCzss k8Q0JIEq6XUhDqoSQQiQ20g3/71WXYoaQC3epuiYkfvU7vtszH+Rdv2suypsi8sjlLEm UExXEMvEMZAAN3tR1Wq/mBj9X7B4v49CLpjElHpSQLvdPnoWwb7Deq1xRDzVohNtpyC1 +HsIdnUGDSkf1o0ocrpJ+qjFjpLXYkx0awhpxN6pFLn/1R4ZeDE43JBxfHd+Pe2LnoOe whWg== X-Forwarded-Encrypted: i=1; AJvYcCVHbEHZFIe+Z2gUWEHMl9FbMUXVtgKltXuRjkWAxRX5amdPD4gbmj4AjFSMg6IfT2Ol2DskTmLMtPPPaZiQeoJybVE= X-Gm-Message-State: AOJu0Yzx+rY86C/2g9TXBeA/+RaMgon26osR5g1uj48yW3VF++oMrGdE XymNNQakh6cyQ0md/o914OBp2Ge2O9IiEbmpB4bDWMq1jouapgUFcrh4JdpuwucBGBrmKKKkQGM sRVVAm89t7O5Fkm1TTnCi06FSYYo= X-Google-Smtp-Source: AGHT+IF8449QxY3t8SkkFK2YfVgF3YWp9glPxk3SBTBF2/RQWo9PnCHlyQLOyQPaq8g0ThC2WlvdwDsfuUmWphADdr0= X-Received: by 2002:adf:fb85:0:b0:367:9903:a91 with SMTP id ffacd0b85a97d-36bbc0e0cdemr4158321f8f.11.1722638448698; Fri, 02 Aug 2024 15:40:48 -0700 (PDT) MIME-Version: 1.0 References: <20240802-kasan-tsbrcu-v6-0-60d86ea78416@google.com> <20240802-kasan-tsbrcu-v6-2-60d86ea78416@google.com> In-Reply-To: From: Andrey Konovalov Date: Sat, 3 Aug 2024 00:40:37 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] slub: Introduce CONFIG_SLUB_RCU_DEBUG To: Jann Horn Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Marco Elver , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+263726e59eab6b442723@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8BD29A0017 X-Stat-Signature: yushfty1zzkxmkb8pspfczdwgn8hmiy6 X-HE-Tag: 1722638450-975234 X-HE-Meta: U2FsdGVkX1978cMl+AW0Dxb6pk+IwezChutllI7lGRQHjG/ooMQ4wmit0HyQ+12kJYKro34rG/NfPsbGFXZCnZTJoDKCmTjoeybizwmjduy3B1Ug8zQWKVTzwGg2myUAmU8g28lzIqbZPw1fi8VMTM9fwpKABsC/IW51Q7N5k4r4EcZay8TPdkx3JLfSzqtF770oCJU3y9Gw3nm/d9FNl7b5sgKAFERh0ON0DEW2etZ2qU/QukvLlD1TKCP/RYP8acKsfMuXYV6ueGuJPWSg9YbDnuRb1KPBmTH2najIwbFQoY2/wVwjwvYv7U0vN3Go90C2rm+NPdxdNCZ32QPBvLJ33UkJKb0HfAMu/kyeNKSJuQGO7f8ohcF3A2yPAQxUyS/s+SFOEYavXp+x1QGM8neRn2mzbWxkpJCHur3g+g/bZdKZVHjU/LfTWgJeq+T/oM2DIeau5NrOz49fV99AoPMU+MzaHecTdzJoI5vppHzDtp4Qo0prCLTTQLxe5ewb4JHCRgN88+ygVjLotlOX06mM7WnbxYQEAQqjlAqFBodN1IKxKjoNRe/OgGu4gfwn1l68DoH93pOlrxztBj0L/lpRHnxjHQtgKQFUfET+Ba3PA4ZZAfi/t1pURISFhwnTk15pONE0bqvgBBXAeSiEAR0eAbTjE4RFZyEE8tXUQXCrUNXyMbuR045HSCfjUT5Fh4M3WHrtTGzjQ7mf6SgxWBrCLSJ3QMHlvp405/8sHoyhxE3ACaPTxrnD0qzjQ7w/h8/01e8P4+w7wQPPaLKnq4FQR9nXmDDJgxvs6dolE0crOc/vuP/qQWP2GMn74gWOGE8TZuu9fOeJPHAT1EwL0b0fPZBRfYS9cyDTSfhHlPVojqL9AG23MctoWoDcDtTpwIAIvtq7WHGuemDETsKgn0ronSu0U18lKnq2NOjQZzfsqDdbD5OTD13mIZBy0rIifHodfTEIub2xNn/PzhD Rz+scstw e4WfJfil4abLjw8eHfv5uWbf0VWbKGYjWLx44LSiUewGl7EYZ5XHASAfQjjVbx/Eo9DjKOAxPrJXbgC1ZhR4xL3VF/GOGWOahEHDnWWXfZji6OYme4K/XtbjBW5RA4+mOJ6UYHsr7aute0lkwYXk9xiWEEPRAGVhN7BDRkgf3I/ml3t1s9I1K7fIyYJgiaIcj2v3o2ccgvhZNooU6ilGTJzdhM41nSM/zGsMSomPpp6HtTMpMR4Pij+RauewUn2b5KExT23tpyjvWPGDMmYUHiye0dPjb0U1u6e/r5NCDwkus1aDvA5XmbPKUpUH14Trp1cxORj+nkKIuijq0quKwen8WwmL4C9S89E1FsQNLOrgtlF2cxOJBfPq4HnoCxqwbjWDZMgl1F22Z9A1HyQQrpf8qF9GiCPiD9uKkbg6RJUTHlzpdZEd3IXWe0C1v3N9G2hBJfCVVTh434176o6eTqqc8cQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000155, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 2, 2024 at 11:35=E2=80=AFPM Jann Horn wrote: > > > Ah, notice another thing: this test might fail of someone enables > > CONFIG_SLUB_RCU_DEBUG with HW_TAGS, right? I think we need another > > check here. > > Why? I realize that HW_TAGS can't detect UAF in a TYPESAFE_BY_RCU slab > after an object has been reused, but here we do no other allocations, > so the object should still be free. And the kmalloc_uaf test also > doesn't check for HW_TAGS. Ah, right, all should be good, I got myself confused, sorry.