From: Andrey Konovalov <andreyknvl@gmail.com>
To: Jann Horn <jannh@google.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Marco Elver <elver@google.com>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
syzbot+263726e59eab6b442723@syzkaller.appspotmail.com
Subject: Re: [PATCH v6 2/2] slub: Introduce CONFIG_SLUB_RCU_DEBUG
Date: Sat, 3 Aug 2024 00:40:37 +0200 [thread overview]
Message-ID: <CA+fCnZcZbP-PNG9BZfoOr9UEoqxqLkCviS8ooWOLc4Vp9+XimA@mail.gmail.com> (raw)
In-Reply-To: <CAG48ez0ggtaV8MF-bzzS2=zKg-3nfG1G_QaqGdesAJpQSj39TQ@mail.gmail.com>
On Fri, Aug 2, 2024 at 11:35 PM Jann Horn <jannh@google.com> wrote:
>
> > Ah, notice another thing: this test might fail of someone enables
> > CONFIG_SLUB_RCU_DEBUG with HW_TAGS, right? I think we need another
> > check here.
>
> Why? I realize that HW_TAGS can't detect UAF in a TYPESAFE_BY_RCU slab
> after an object has been reused, but here we do no other allocations,
> so the object should still be free. And the kmalloc_uaf test also
> doesn't check for HW_TAGS.
Ah, right, all should be good, I got myself confused, sorry.
next prev parent reply other threads:[~2024-08-02 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 20:31 [PATCH v6 0/2] allow KASAN to detect UAF in SLAB_TYPESAFE_BY_RCU slabs Jann Horn
2024-08-02 20:31 ` [PATCH v6 1/2] kasan: catch invalid free before SLUB reinitializes the object Jann Horn
2024-08-02 20:31 ` [PATCH v6 2/2] slub: Introduce CONFIG_SLUB_RCU_DEBUG Jann Horn
2024-08-02 20:54 ` Andrey Konovalov
2024-08-02 21:35 ` Jann Horn
2024-08-02 22:40 ` Andrey Konovalov [this message]
2024-08-05 9:01 ` Marco Elver
2024-08-05 11:08 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZcZbP-PNG9BZfoOr9UEoqxqLkCviS8ooWOLc4Vp9+XimA@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=ryabinin.a.a@gmail.com \
--cc=syzbot+263726e59eab6b442723@syzkaller.appspotmail.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox