From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACEBC001E0 for ; Mon, 23 Oct 2023 16:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBAA56B00E5; Mon, 23 Oct 2023 12:16:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6AA36B00E6; Mon, 23 Oct 2023 12:16:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A32966B00E7; Mon, 23 Oct 2023 12:16:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 945F36B00E5 for ; Mon, 23 Oct 2023 12:16:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71605B5B6F for ; Mon, 23 Oct 2023 16:16:08 +0000 (UTC) X-FDA: 81377228016.27.E195D63 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf16.hostedemail.com (Postfix) with ESMTP id AAB6B18001F for ; Mon, 23 Oct 2023 16:16:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dArecPSv; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I7P8oczVJ6z+n4v15CASAjFJRtKrm1cxI4uPJHeGdVo=; b=gdrlCwy9nRb3WG5huKV1lVVv7j10rXqGbxucUmBtMXBks6/NtO+IzEdgmRiSs9Uz2sn71c N/a1PPGwAOSv37nDlMSO8ylGQnX9s/hQJLiTzkzhr011jBNc4lktatGinf4ec1E4iuDiEM o5kib8xvHUnNuOCcktQeM3P3x70S/U8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077766; a=rsa-sha256; cv=none; b=nyE56/m+davvyD2cPK0YXS27Ui4Ov+/kP4hUikikCLL87CBUskrsLQ8W6yRpmfoNC43M00 IujvAMh7db3Z1/IO2LYehunrYaqm0EENOIjiB8P7nKAB1jZqw8R916u483gbap04XD6Opb WJQDdtXB5O6+93pCuVCdIT7lqB2fci4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dArecPSv; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-27d8e2ac2b1so2135681a91.2 for ; Mon, 23 Oct 2023 09:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077765; x=1698682565; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I7P8oczVJ6z+n4v15CASAjFJRtKrm1cxI4uPJHeGdVo=; b=dArecPSv0J/XBkMA3UWFLMCmjpYjC+BQ+elPYbaD/GYWwAhAj2cKyu1I13PDL04nzD GHwT2LAsO5OjU2QCus+eHf0zERbUv3xS/6zYkx87I85IKOKvd96efAk/zIyhl7BaYic8 F28vKyLiFlzRoLOuN3me6VAU+4T6mmHiO03GKxbByjpQ4LIrvhup0v9EdmzUiaWhqzW1 5RM6R2xkZdUo8GlC8HKmKUdLNsXYQMFueb5KDxVr4OJ4Ae2BAQoNUPVPqE9bC9nc+OJl LYTBPRCzVW1q18JFH26HOKGMzti26aMjkzKHGJTpSKz6X6yUJZpxX74DUifFMu3lmlGT EvcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077765; x=1698682565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I7P8oczVJ6z+n4v15CASAjFJRtKrm1cxI4uPJHeGdVo=; b=EL1lcImGZCQgmSQN/0vfSCR2JZ8DnLQQ+lS3sP4b2CGeWAFLxZ30hjRKpxI97vFYh6 pm1Jwks+NFurhjzJ3hPzqLvhReSTAkXjfe/ggNFIXnzf4/SJ9klNlbZgkgVRv7gGWrrM BwKyCMhHk1fArHhqIxuNdcaukvR59GcnwKSSmZtGeVTdG5c9owJAHkJK8/d2KaeNDOKD wRPEb7HF9LMjJmf29MFoHwCh3nA7xSOjR1YClBgpG3ga3AtLZQVNzKtyCTq+t0HRNXnw 5t8k+E4dkiVRD0MCxBpnldlGLekiMp5XH3pFnzAb4i5SqzEb2p+xS3DaNcufGKKUEFEs RJiQ== X-Gm-Message-State: AOJu0Yy0I+f1M2Cdh9WLaHK0x0L4kKU2vP6lz3wt/yCGjmQm5BlQs9zx ygHQM+NghChYabKP3JvqNszTnlfSQxUwAR2Lzms= X-Google-Smtp-Source: AGHT+IGE9ocFI9+MvERlI4Z5hqiW7HqKx/YOe7KTld8ZTi8R/3MltMbrT/7KaL/rGY5Smbt+r6SniLfQEXAjJYVpQ4k= X-Received: by 2002:a17:90a:8a12:b0:27d:1af5:3b17 with SMTP id w18-20020a17090a8a1200b0027d1af53b17mr6747462pjn.26.1698077765375; Mon, 23 Oct 2023 09:16:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:15:54 +0200 Message-ID: Subject: Re: [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AAB6B18001F X-Rspam-User: X-Stat-Signature: r1crmiz64yhf98nrfpr117suzdq351gx X-Rspamd-Server: rspam03 X-HE-Tag: 1698077766-745649 X-HE-Meta: U2FsdGVkX1/KF7Z/meQDVvesE00yCPsDB/9FIPK9a/otoyrTE1Cj3ylRmRtDt/DzUlw+6+SKRY4ila28DzIni/qB0hUqrYHWykvWWAOJ6OYHr4OJBetzewIRNj9sUE6cupzvOUiZ/rSpJak+fhUk7dsjLDkMNhNGBJxUJvuZ+RDZx/DYCd0rOj0xjFbPFCgouxEIAhDdod9c1cSoh1Z4FAkIFCTcxVhmT/oc3VWEFravQJeBvfH7EiJZQ1fgXW3MDsvRy4K9FYPnzNbV64HJiRP2uNA35OfmKT3EL+IEj1ezqQSCmPG5BKdbNuTElTwiBiolgMVHGwRMfhoS8n0Z1g9i+cMhhriLHGHTcqaGexOfU8lp7U1pzjii1gZ16wyE7lr4zBB9kqI5usd12agox7ibPQABt5L2huJIS2kpGsJsoS+SlTPrXh/b83HKiPKax91SD1D0v5MIh8yaeVNVKsQueTQFeQecnWGlsWLNRqd8jCdKhUYAiNRZ2ZZ44l/NfxR8rL+jCwJUA4HMjMHVEUpZZl7MjUh0LGw5JILdv4N0elvPywiuiVxL79UUdSvo0eEiIAV+5y/qA/UBnBnVckAQ8B8ICH9T9R2mlsQIGncEPL0UqrLBUkuiu/gLQZm8LKYepCboYiW1CFStY4Zy63DKp7C3SpADBjDpgRmLONJWU75jb6R4vLvhFPRVS5FOJbIBv7LGb18FU+hphA1QcidHcP2dUQpTjeATzgScBc3rtLJedwbaVMOm0Lcsl/FM4pHiHeJkTRjOoyrpH+h3DU2o7fwDg+ZDzMrZpp+ypa507/D9hdHHfmm19RnqCfL1cKME+gWHf+cCPwirzT2XWPz7mF+faSfgzSlOTUlC0yGKxqESlaIv19el9+9w+bRuJXM0BqZwUwCygB0zbLRRwhQyjr/fGfVvYhqhajJcMEbv2TIj5lQ8NIM2tK5ZzKjsz9OP2xFIEbqTYDnikeJ d5ADkyfa vEGfJvFhWFRqCW8TcT5Jtg4fzZ+6ahVgZU6ix1KUxFlfzPVeHYLKeuyuPiGiYSnenUE6zzNhWuz6C+wzrP0dQHoJq1e7dzf7eZQk9VpYzLxz1JRfRBNNyO73l5q+FeeHyjOBq/+JooSzPw6RyrfkyHSkeZ6wd5MQzUGg1//X6TJfJqlvptjrLlk3DpLNy0wCTjz3Yrwxmn1t12vakG8IbT5baqBoKvIFujHPDX0iSB6gQaX+evZo8kBZEaFHl0hFamMcltryvc7kKMxjX69uZqRD74AaZRGevXzb4PVuaVChhKFatm9Wd2AnT39wBp5lwo9h6vNstcjIiDyEr36sfo9b6PD6Kx4iJsa0XL9US7PLdgGNf1dsJeSXt/Gqqjk7wKONUhEpZGhUKt7e9tAKDtLkbEZV8hGv4ZkcrL0uk+hg8tXiabBYi0EGVwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004453, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 6, 2023 at 7:22=E2=80=AFPM Alexander Potapenko wrote: > > On Fri, Oct 6, 2023 at 6:14=E2=80=AFPM Alexander Potapenko wrote: > > > > On Wed, Sep 13, 2023 at 7:15=E2=80=AFPM wr= ote: > > > > > > From: Andrey Konovalov > > > > > > Simplify comments accompanying the use of atomic accesses in the > > > stack depot code. > > > > > > Also drop smp_load_acquire from next_pool_required in depot_init_pool= , > > > as both depot_init_pool and the all smp_store_release's to this varia= ble > > > are executed under the stack depot lock. > > Maybe add this to the comment before "if (!next_pool_required)" ? Will do in v3. Re removed parentheses: will restore them in v3. Thanks!