From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A03C2B9F4 for ; Tue, 22 Jun 2021 15:45:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7F71611CA for ; Tue, 22 Jun 2021 15:45:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7F71611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 932786B006E; Tue, 22 Jun 2021 11:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E26D6B0070; Tue, 22 Jun 2021 11:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737136B0071; Tue, 22 Jun 2021 11:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 3D0986B006E for ; Tue, 22 Jun 2021 11:45:04 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve03.hostedemail.com (Postfix) with ESMTP id 197581811CE42 for ; Tue, 22 Jun 2021 13:55:12 +0000 (UTC) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 047C71811CE51 for ; Tue, 22 Jun 2021 13:55:11 +0000 (UTC) X-FDA: 78281506422.11.A6DFC82 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf26.hostedemail.com (Postfix) with ESMTP id B79DC4006F1B for ; Tue, 22 Jun 2021 13:55:10 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id l1so34749149ejb.6 for ; Tue, 22 Jun 2021 06:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mtJ7IslezInr0IjO/y83W5WcZUNJEOAxkSrY2hYdtzo=; b=ouzNwjxRs/VrHBOHszXWY5PYOroSfuMEQLOgkPv2T2sBOAAqq1bbesJtm4/x4LeO51 s0iC/H3jnz7pxYyEU9K2qYA2WiEhPA3Ie2IcjdFaCHe8U+Pn8B43G+c4QuwcGNmOnWzq 79fytTdJ2RJp6CSJHX/AuhFHicasprVa7MVyTD6xUsasGN0aqGbfs5NX8gZ35EG40GnQ y/M98oBs7KeKKgfJ/UhqYPs8vkzUWK2OSsHn9HayOtQjKvQjYKMFKiSURfqYXfLTmsHj 3W7LL56gEerLDVBr3/hzQVk6YwmqovsdPmu0pBNcnhjUFli5jk1XWnqJKVvNetqm4MvU HLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mtJ7IslezInr0IjO/y83W5WcZUNJEOAxkSrY2hYdtzo=; b=VwxfcH8uj3jpLsAmal4IJf867Tjl2gLPE0JbsQHPsnqg0xf6Z2dDKUXfrI651ifB4t sJC86YF7IeLnVJ+vQ7swuD2XV00HLeBWX0x9QTQpv5K0Lyl3wcjfIIDwnJvAsSkdf8++ 5exYtf2zTGoS7mDWsf7qf2iTGrZHGKBN5PIV5do09GZKz0oGCVYZCq343VQ4V/oB+ZtS rgEIZuaBcvIjuzFVlgMeoJ9/b55iBQmOiQT/2tFBaRWPsJIqVeI+P9lKTv2u/LQEhsGw JuHm5OP8uR6H9fv89UoSt8IL9cWgbHlX0iwhBwj6gHnvYGnbkEyb+riRx4+szp0CJrtP Mueg== X-Gm-Message-State: AOAM5330k4uiR9cNoR824wl7VercqpDE8gi2ZCJCJ6lrJOF++1LGP98C 4Kf4ycNJO5sxNcXN/u7yPFS7vpYiDhYsFqqNXF8Z9RInW5Y= X-Google-Smtp-Source: ABdhPJy9JElAxjoK8FcIuAfranbHc7RCHMPcqWtQgY9B1Es9IrHjC2++p6pEUqWueW0g9YbeuzEqNkP9tcB/MRGNCSM= X-Received: by 2002:a17:906:17c4:: with SMTP id u4mr4217576eje.481.1624370109577; Tue, 22 Jun 2021 06:55:09 -0700 (PDT) MIME-Version: 1.0 References: <20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com> <20210620114756.31304-4-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210620114756.31304-4-Kuan-Ying.Lee@mediatek.com> From: Andrey Konovalov Date: Tue, 22 Jun 2021 16:54:49 +0300 Message-ID: Subject: Re: [PATCH v3 3/3] kasan: add memory corruption identification support for hardware tag-based mode To: Kuan-Ying Lee Cc: Andrey Ryabinin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Matthias Brugger , kasan-dev , LKML , Linux Memory Management List , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, chinwen.chang@mediatek.com, nicholas.tang@mediatek.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B79DC4006F1B X-Stat-Signature: dc9yhwn9dec7ui6hn5sospszac6phnd9 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ouzNwjxR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-HE-Tag: 1624370110-45324 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 20, 2021 at 2:48 PM Kuan-Ying Lee wrote: > > Add memory corruption identification support for hardware tag-based > mode. We store one old free pointer tag and free backtrace. Please explain why only one. > Signed-off-by: Kuan-Ying Lee > Suggested-by: Marco Elver > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Cc: Andrew Morton > --- > lib/Kconfig.kasan | 2 +- > mm/kasan/kasan.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index 6f5d48832139..2cc25792bc2f 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -157,7 +157,7 @@ config KASAN_STACK > > config KASAN_TAGS_IDENTIFY > bool "Enable memory corruption identification" > - depends on KASAN_SW_TAGS > + depends on KASAN_SW_TAGS || KASAN_HW_TAGS > help > This option enables best-effort identification of bug type > (use-after-free or out-of-bounds) at the cost of increased > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index b0fc9a1eb7e3..d6f982b8a84e 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -153,7 +153,7 @@ struct kasan_track { > depot_stack_handle_t stack; > }; > > -#ifdef CONFIG_KASAN_TAGS_IDENTIFY > +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && defined(CONFIG_KASAN_SW_TAGS) > #define KASAN_NR_FREE_STACKS 5 > #else > #define KASAN_NR_FREE_STACKS 1 > -- > 2.18.0 > Other than that: Reviewed-by: Andrey Konovalov