From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91771C433F5 for ; Mon, 13 Dec 2021 22:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 430DA6B007D; Mon, 13 Dec 2021 16:57:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B8BD6B0081; Mon, 13 Dec 2021 16:57:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 259196B00A8; Mon, 13 Dec 2021 16:57:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 131F46B007D for ; Mon, 13 Dec 2021 16:57:55 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D24B089087 for ; Mon, 13 Dec 2021 21:57:44 +0000 (UTC) X-FDA: 78914133648.27.FA1404E Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf22.hostedemail.com (Postfix) with ESMTP id 251D7C0007 for ; Mon, 13 Dec 2021 21:57:43 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id z26so20580370iod.10 for ; Mon, 13 Dec 2021 13:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Izx2PBJI6AWPZSxP/szrg017GVN03v7urPWV5485xFY=; b=AF0AV2ARAAX4APaDSLFpoXDSN+2gbml2KM50iiimiShWMpDclC0ji249wqsMZcz9gG yrsUAKuqyZ0HVQfRchx9GVT/61lOdPcnMff+SltKucwZKQTywULdAvowtFP9wEaVZfQE Jq6QQge1/gnEZlkpY0Id6VsK02GcIz6mJoVMe5llq7woRBqI2nlDwdnCcItq9cc+Izfr jrwaN4L8/Z/8k5qiOh/g+cPtxcNiNMhvW4h75m6vhP5jMIDdDnXn1SUmc7DRkgl/liwf MaH1Fg5rRMi10oWWoo0zm+DGtedNeukotuLllo5MQiaD+9efPOeH2gwSFU6sF3ebOBz3 PcBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Izx2PBJI6AWPZSxP/szrg017GVN03v7urPWV5485xFY=; b=weUgnP7aaCzMlHEczo14zGXAzGK5Yyc0+mc0Wmddo8L36A6Ge5NKwN/oBQyKoK0jVs f7MemvTy3l74Va8c8a0JjJiV2VmAShPJxAYo5RwX1btZ58qUkmmtRYUXzJDfwQIVPeXD GC6HNQvi/463KYm+TtYKPJ+pGgUbncDhpz6POJaUAodsSXhlcrtWnzAiauLu2LTWf/mE M25exhGxF/PEO+iZMkGY0rbLohLOYsFEZ6MG+7z376vVuoj0BDhUQfI4B7ofRicionxS OMjoNTix01q2FgsgBUjDNdirv/WfSWoKFy61oIkaUHwBEH9XpJ+eF4ohaloFMz51hXuQ J9gg== X-Gm-Message-State: AOAM533SoUjexQiy+C9IvHho6YKwQffj2w3NijkMuGOSzXKjnzMOgQGq oGEThX2CewOvTaUTQvdLuNPYh5sssjQYHDDiDJ0= X-Google-Smtp-Source: ABdhPJxla1h1vaFnm/AGV4DYwa7tRTYS9fOoUcuMbKzgf64wEEeaJZyHVIz7RlfdxOEbl+9pEXMr7xrOdUyXB+D5was= X-Received: by 2002:a05:6602:2d04:: with SMTP id c4mr1017624iow.56.1639432663912; Mon, 13 Dec 2021 13:57:43 -0800 (PST) MIME-Version: 1.0 References: <72a8a7aa09eb279d7eabf7ea1101556d13360950.1638825394.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 13 Dec 2021 22:57:33 +0100 Message-ID: Subject: Re: [PATCH v2 28/34] kasan, vmalloc: add vmalloc support to HW_TAGS To: Vincenzo Frascino Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AF0AV2AR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 251D7C0007 X-Stat-Signature: ozo3is5aesc4iuakt6x97jzssdnkbjet X-HE-Tag: 1639432663-923523 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 13, 2021 at 4:34 PM Vincenzo Frascino wrote: > > Hi Andrey, > > On 12/6/21 9:44 PM, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > This patch adds vmalloc tagging support to HW_TAGS KASAN. > > > > Can we reorganize the patch description in line with what I commented on patch 24? Hi Vincenzo, Done in v3. > > void * __must_check __kasan_unpoison_vmalloc(const void *start, > > - unsigned long size); > > + unsigned long size, > > + bool vm_alloc, bool init); > > static __always_inline void * __must_check kasan_unpoison_vmalloc( > > - const void *start, unsigned long size) > > + const void *start, unsigned long size, > > + bool vm_alloc, bool init) > > Can we replace booleans with enumerations? It should make the code clearer on > the calling site. I think we can add a single argument for named flags to improve readability. Done in v3. > With these changes: > > Signed-off-by: Vincenzo Frascino Thanks!