From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792E1C4338F for ; Wed, 11 Aug 2021 00:41:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0621E60E97 for ; Wed, 11 Aug 2021 00:41:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0621E60E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 465DE8D0001; Tue, 10 Aug 2021 20:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4177C6B0072; Tue, 10 Aug 2021 20:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 304F28D0001; Tue, 10 Aug 2021 20:41:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 151566B0071 for ; Tue, 10 Aug 2021 20:41:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B0A338249980 for ; Wed, 11 Aug 2021 00:41:34 +0000 (UTC) X-FDA: 78460946508.26.70613A7 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf11.hostedemail.com (Postfix) with ESMTP id 62D47F0052FB for ; Wed, 11 Aug 2021 00:41:34 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id e19so684479ejs.9 for ; Tue, 10 Aug 2021 17:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+IKe5IV7lT/U5uUeCk8dwVAQVUVWQi0SX4MD0PFARrk=; b=VpErF9BeqvJ1lvp3C6qQVShFP+IPiAWshgdKLp0P6z5k1tr0AEcTxGz7UXnNvecgkT YT99OYu7LRWl/Fy8NL6FIcxXcEsQLWAxQyNk05Zd8sc8Qx8x7XwvaM2sLY8/poHHrPu/ DyjfK5DuBXeRhweChIlCA1+mwEa406UsmTGdff6uEJHY9SaVQJnQwoVW60I0hdrHNxvT B7PAjoDqxdm+RkuigKCXFaq8jWVK9FfgEfezb2NHeiW/Q1qHn1shnvOneg5hIHS3xcg3 YHRkeLwJ1ju+oYqRCy4vCIsyP4fSsn+uZS9kDF6Io8A5TEIZ4DCoY+wVtUa1vrnoYB34 k4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+IKe5IV7lT/U5uUeCk8dwVAQVUVWQi0SX4MD0PFARrk=; b=NcnmyBhkPDOiW0lZHX1DmKPfN6KTjwJ1867ar8ylfNdCOfy1XCEWsF0/XapHCpS6EI UhBovdtnOtg2MffdT77mZ3HVUDhIM2MobrCfyBYAS4R9wVfkadzyJQQ+F01R4yAciSDU Dl7NJxlLpQtqFMEDrAMioHnksZNYmjCW+hpBYyQVZnkC9GjIhYNMh+OG0AXp/68OYMgV e36Gle+7eLwfUaM48i9NGq+ZKEbRh42uUkG9fIZq3RLMuguKQbhwD5brzpOZBUlEBCCT YbGld85neT2HGXai+k3L1XJ7dN3+txZoTtAaMHErmJxHVw4cbThDT63y8NZbgPXsI/mj tFVw== X-Gm-Message-State: AOAM533Kl0rb+Z6Kr2e3pr5N2u4EK4TjkgTQH0lmkc+/H2nq9ikQe+Q9 hUUPK9ZkcSI9CKI4bRvQyFHPtpG46qRTbfEXK2A= X-Google-Smtp-Source: ABdhPJzhKYKVAFCRyomt10DfXYeqMxabU4psPm98irB3JQRDdIK4pz5dLQpzfGjYi+Bm/E+rvMoR2ThLD7k0wAPtJa0= X-Received: by 2002:a17:906:d147:: with SMTP id br7mr1138362ejb.126.1628642493014; Tue, 10 Aug 2021 17:41:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Wed, 11 Aug 2021 02:41:22 +0200 Message-ID: Subject: Re: [PATCH] mm/slub, kasan: fix checking page_alloc allocations on free To: Shakeel Butt Cc: andrey.konovalov@linux.dev, Andrew Morton , kasan-dev , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 62D47F0052FB Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=VpErF9Be; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Stat-Signature: x7ie1tzz8fwdgqa8yatexy36zjgdjt4k X-HE-Tag: 1628642494-915970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 11, 2021 at 2:18 AM Shakeel Butt wrote: > > On Tue, Aug 10, 2021 at 4:47 PM wrote: > > > > From: Andrey Konovalov > > > > A fix for stat counters f227f0faf63b ("slub: fix unreclaimable slab stat > > for bulk free") used page_address(page) as kfree_hook() argument instead > > of object. While the change is technically correct, it breaks KASAN's > > ability to detect improper (unaligned) pointers passed to kfree() and > > causes the kmalloc_pagealloc_invalid_free test to fail. > > > > This patch changes free_nonslab_page() to pass object to kfree_hook() > > instead of page_address(page) as it was before the fix. > > > > Fixed: f227f0faf63b ("slub: fix unreclaimable slab stat for bulk free") > > Signed-off-by: Andrey Konovalov > > The fix is already in the mm tree: > https://lkml.kernel.org/r/20210802180819.1110165-1-shakeelb@google.com Ah, I missed this. Please CC kasan-dev for KASAN-related fixes. Thanks!