From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FC4C35274 for ; Thu, 21 Dec 2023 18:00:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2CF26B007E; Thu, 21 Dec 2023 13:00:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDC7F6B0080; Thu, 21 Dec 2023 13:00:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4786B0081; Thu, 21 Dec 2023 13:00:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C712B6B007E for ; Thu, 21 Dec 2023 13:00:22 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 984FD160D9F for ; Thu, 21 Dec 2023 18:00:22 +0000 (UTC) X-FDA: 81591589884.11.8FC3B4E Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 6CA2280013 for ; Thu, 21 Dec 2023 18:00:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VqnbV2vy; spf=pass (imf02.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703181619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VDdp8WfkBByjzDwq6Ok/AjXzstviyjPC8n93eKiHrkU=; b=2Hs4Nl96Vnxvdic/7xoqRMbSYQ7OmVvX6ekbS+b2op52EiVEaYs3/vh/2D5NvHkODM0lc+ elWs3Ew/k6uH4kZmkrWxh6rZoLPZ6W/GHDKiSdYDMwVzln4KMyiziOVKyzUhXz8YAGcobz /8QFtE/UWvGFZNX42tp9jUXrjOk2O8k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703181619; a=rsa-sha256; cv=none; b=7ZfZeFoL3pGFj9kxb0dC7sw/bysXX/knOU9D4PohWDuSJCPmQnERW/m8rxT2B7ptZQV8I9 o0mItG7I0m2OrDJ/vuGRvmys63XblBka/oi7mPFOZd9pQy+6VXtwLMiJbIAa9pYDOBpXaw M5URboBi58Ku7x8QYW/mJ4qliyb32Iw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VqnbV2vy; spf=pass (imf02.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6d47bb467a9so1602611b3a.1 for ; Thu, 21 Dec 2023 10:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703181618; x=1703786418; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VDdp8WfkBByjzDwq6Ok/AjXzstviyjPC8n93eKiHrkU=; b=VqnbV2vyMme4A5oHRRXs5V3dAqHP+GJvKT8aEOVwhkWtewh2SKqoGfOBfuqtgq2HJZ wbAjo9DhTDOLy0hLsTzX+ntzhMA1nMTHHq12BTN3xke0z4OECiV5zkHPQV/P+tsZTkBZ Ad7bIMzrbzxcejSU5ffRwx04ZSZZrW8UVhcg8N5lzVVVo4/+RlTfyfU5rWnbhLaI1E2d kwjpG8N/vnGe/wCmuw+2h7PZNivm36m5pellEJD0twXWn6nZEj/L3a7MIgoCwCfNYpzg XqUWeFuwcT0wSP6TsvB8Hf/8T2irldiT62LWYs6+5aaBuEhfKfEqSLkYO2hfQp80KbBU VXtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703181618; x=1703786418; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VDdp8WfkBByjzDwq6Ok/AjXzstviyjPC8n93eKiHrkU=; b=t6A/x1fGFZORMVQm4aCZb3cekbWjfFTMNmEnAWdQ48X8e6nKUouPPdJNDZLCvkTPZf 1CM5Fa9r+u+PIM6KJ9FeSRl1OL8OfoP5r7ILLidGp0V/sK/UDMc3txXjOiywe9jFK13/ KlA6cUMB2+NlueF5w99Cysp4GQG84nZp9nsvp/OJlXwHaLSrVAEFTLWX3b3aNKBAmrWw aq/QtdTbzwbtU4vDpPbf6EdjPusVMjP0yRfQKKY0QymRWgheUeAUxlVEstAFxXRigdC/ c+TOdoWxuTu/0tkvXtb1Z/t40zcYa10EHdVQYTt03efpBgzWoeOM3AlbaNgGr1yOHOPn OutQ== X-Gm-Message-State: AOJu0Yws4SU/flx4XOqXimcBdFNYcx0A/5K4l6AbWRTybTayOmjl/P/A lVgGFIerDq/xwVI2uJJuPs+hlTotiDc/rYEbHK4= X-Google-Smtp-Source: AGHT+IFuOW7jV74kdaQ1EiZtJSMtFg/uNlhiKGSob025+0Bow6FzWbsJR4rVvjKcJbmkGB4HDsUiaIOAL3kQagZSPIQ= X-Received: by 2002:a05:6a20:394b:b0:194:3af:19ca with SMTP id r11-20020a056a20394b00b0019403af19camr61272pzg.47.1703181617939; Thu, 21 Dec 2023 10:00:17 -0800 (PST) MIME-Version: 1.0 References: <20231221-mark-unpoison_slab_object-as-static-v1-1-bf24f0982edc@kernel.org> In-Reply-To: From: Andrey Konovalov Date: Thu, 21 Dec 2023 19:00:07 +0100 Message-ID: Subject: Re: [PATCH] kasan: Mark unpoison_slab_object() as static To: Nathan Chancellor Cc: akpm@linux-foundation.org, ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, vincenzo.frascino@arm.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, patches@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6CA2280013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bwgnuuhexh73f6tgys8wsux5zngawwoj X-HE-Tag: 1703181619-545643 X-HE-Meta: U2FsdGVkX1/U8RiNtjABOQFJE1gHA16jVG+CPErzSLF87g6lV+nIyEK/Y0X+dkCcQy5059H3pBNWh+GhdNb50HskysTUDbdw8sEdgqbpHpTUBwWMbdxr2lF03p4k2E5KB0KwZ4GrxtzWd8R1a44dh5ySkrMpz/zeWc6K8Z5Bnl1vXnKxfaidpgCGCf/Bj+hU58mNAgjoL82MHtCBhq3O6tNSekSpXA/BceNpwcyP3x1NREJ6xMg17onNuM/ORBA1XlaXURePnRoCLam7IglRLE+gyO+4P9VWOSnQgUcduIaYeP25Ql/WrOJ9cYWUM6j8A21JB3SuWbqaHGbVnVuAECWE3lGDFdsasyK868SuCG0d6MBmm0zH4VV/RF2PEna5/iJTSVqRGyB8mKw7r5NhYbcrT2fbjN6XnnXS7QxxHGjX2/0BIpjli/3RFI8HjK84sp27CYjlFwpusqMDHPCApiF+IOOaCng3lHou7fYeTlD/qiJU3P9e+NWKBDWg/aOT9mFxbn8P5yB650Gq4mufmTcW8tcTsWD4m40HtTs6Mb2WfDj/ljYPuolwBX1puux+/IQG23CfTRpSsHc9kNrVteLl1+sLrH7y6WmV9ha6BQNidcz7ys0GwcFF7oiS1ViltDA+I1Mxegj6jXbyBHfMAuuNagzQPtRqr0BtNUYLvIMepA3axMJ4AbIMuF2h/CfT2QcuO80zyCbb70w8J2pKRZeNtulKdjlHdYVjZPqKmtra3hOgtORs4PrW0zTy9cvux+37VT0dmjlCgKUUx5galsFd3HAIpKWca5FQz3WwQpxm//HMD86bc+dpPyHxaBhIXmAahmMotz7s7tdE98ivmJhw6cDc0IMnSwGAzcOy2nnOase0zqg9HiS5qWx5MHF25C+n+nxhWPehdnOo9UwZ1qgIJ/vHVwFxU9Q2mr3Lknli/ApMaTQRgomKUiY7w2y2NNWS+RqakDH3pt7E+ra wfRm4mZv f5KRJ01ThCYCKtk8he/zNfci//W3rK3cnGok6aUVS4UL2KnfpJ8PBfZh4mahtElUn+22zyJj72QolinXn6uAFxG6VkqdXYpGYKwl83eJ9khd+7LJc6cnmST5hoGu5CAk2SupnWYRZVXZvL6weczIOls0L3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 6:33=E2=80=AFPM Andrey Konovalov wrote: > > On Thu, Dec 21, 2023 at 6:27=E2=80=AFPM Nathan Chancellor wrote: > > > > With -Wmissing-prototypes enabled, there is a warning that > > unpoison_slab_object() has no prototype, breaking the build with > > CONFIG_WERROR=3Dy: > > > > mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_s= lab_object' [-Werror=3Dmissing-prototypes] > > 271 | void unpoison_slab_object(struct kmem_cache *cache, void *obj= ect, gfp_t flags, > > | ^~~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > > > Mark the function as static, as it is not used outside of this > > translation unit, clearing up the warning. > > > > Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") > > Signed-off-by: Nathan Chancellor > > --- > > mm/kasan/common.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index ebb1b23d6480..563cda95240b 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long i= p) > > /* The object will be poisoned by kasan_poison_pages(). */ > > } > > > > -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_= t flags, > > - bool init) > > +static void unpoison_slab_object(struct kmem_cache *cache, void *objec= t, > > + gfp_t flags, bool init) > > { > > /* > > * Unpoison the whole object. For kmalloc() allocations, > > > > --- > > base-commit: eacce8189e28717da6f44ee492b7404c636ae0de > > change-id: 20231221-mark-unpoison_slab_object-as-static-3bf224e1527f > > > > Best regards, > > -- > > Nathan Chancellor > > > > Reviewed-by: Andrey Konovalov > > I'll fold this fix into v2 if I end up resending the series. > > Thank you, Nathan! Let's actually mark it as "static inline", I'll send a v2.