From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB6D6C004C0 for ; Mon, 23 Oct 2023 16:17:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665476B00ED; Mon, 23 Oct 2023 12:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 614E86B00EE; Mon, 23 Oct 2023 12:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DDB06B00EF; Mon, 23 Oct 2023 12:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B14D6B00ED for ; Mon, 23 Oct 2023 12:17:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1DC2D160A15 for ; Mon, 23 Oct 2023 16:17:40 +0000 (UTC) X-FDA: 81377231880.13.EE5176D Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 45B2940019 for ; Mon, 23 Oct 2023 16:17:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ffoO4BVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wZyP39z6xvoSIY5Cv54i5pfq0RfQpmz8NTDav/yNwTk=; b=zNKcy0LgIlSv7xfKZSwCtrpqWJOpdERP4gGb9eoiuYzIt/54yRefEgL9/dkZGkYOJ1Bz7j FxcWS1txte4MuqWUKDPjM4xEB08TkiUePP5o3lSJC0dXpFOY3tvJ7sY/IprWsi+lLbpEqW eVDRwzCCGFbpyjXT2a03j4Yh2REsHfo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ffoO4BVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077858; a=rsa-sha256; cv=none; b=0kR0V+yWd1opClS+fkyURS4LKXrb4S45UT62uGnIXneyS1FOTDLdRTTmSl2ZwZPdBX5ZCX ti5c9CUy4kKdKht7qHod3lMIsJYniZh6yb6HrtGY9DqEGqWlU8zTbEyRCJT2/bbEmHOb0N WQNnLRvfeeT7cSXcGFA0IJtVA7XTjY8= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5b5354da665so1752043a12.2 for ; Mon, 23 Oct 2023 09:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077857; x=1698682657; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wZyP39z6xvoSIY5Cv54i5pfq0RfQpmz8NTDav/yNwTk=; b=ffoO4BVR9xbkjJd46TbAfNRLDxs5euE3RZyL/MLg4A6joDBOtGGiiz1FpdxMYt1Piu 27zp7s3VIEyMVfomkCvwV0SBLBkBD9LAKlbWSOc/d2+EE6QLuhOd8LHzgAXEthcbtrWV ikuJn+DQ76k+946y08SeuYAo6rSnon3GuB6PNoW1mj1N4iag3K1t/SaL9uaRSn3Psm8Z a4XTVqR2ugO454YFmnntQGQIv+thW6CA2NE5n5Cqgnfmzew7xeILwzcdceHfUQzYQqru oqGLAY9c96Zjbv+t/xn4Q6XSmAXQkRpafX/E17sPmcHXWWACj9rTyMfay5TKC/vxI+0M krOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077857; x=1698682657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wZyP39z6xvoSIY5Cv54i5pfq0RfQpmz8NTDav/yNwTk=; b=qW0wqipitLyRJajKZRaJCkWvMTDq/LSsLi/bTC3uypz46bMYm7WILysy5nQjVFpEM2 06wR6mUXNaImRLWQBqqSTn4mtN4NCZC05Cp9oTe4B4SToT1/trAPQdhWmpIla7/nOZQw vGF7Zk2hJ0KdJZb9jPAXGzqssDxBQ4pD4VezCD5K09I/FWDnANKMFQTIsHoAnrEsfYKh GCAHyAXelW80c0s4Ow0k4hOAdweRT0lAavk34cAlVX2z5DuoC3O4AS5vEFAGegeby7AR ckbDbNh+Hi53VEHuUIo1A+mUyPNPzHKJeHwbGTB73rYQp9r4lVdRQ9LBDx0RmzEDUCWJ bH/A== X-Gm-Message-State: AOJu0YwvWZa6CvC2fbtLvbUaXKLF6fmjJMFv586fA/nAF9TPi6eQrLPx Aa3xhl/w0UR4K3tCYIB/dJCfrgP4Rl/w31cpHkI= X-Google-Smtp-Source: AGHT+IEfifli79cwbVQ+6TNZdsR3mB4FmfsPsSQK0R3HjgJ2Z1fXeHzkNtCWKDBQ/vBQZ0l//EWdSfTkizgQt0QxwrQ= X-Received: by 2002:a17:90a:f315:b0:27d:1f5c:22cb with SMTP id ca21-20020a17090af31500b0027d1f5c22cbmr6881409pjb.20.1698077857064; Mon, 23 Oct 2023 09:17:37 -0700 (PDT) MIME-Version: 1.0 References: <556085476eb7d2e3703d62dc2fa920931aadf459.1694625260.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:17:26 +0200 Message-ID: Subject: Re: [PATCH v2 17/19] kasan: remove atomic accesses to stack ring entries To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 45B2940019 X-Stat-Signature: korfsroj576ijj4dpi5fjgpo9qeq33ai X-HE-Tag: 1698077858-167828 X-HE-Meta: U2FsdGVkX1/rRbZts0RNMKF2IZxOq5PP5ifXwKuKEMBYDudjSwzIWXWHXRUFk21ojVT8CEfYdKSkOseYxCN/gT3UR84yVX2KciXwwTq8dDD6e5KLUeh7qPXvueqQYAAa+2WHdC6IoswE2DA9zC8NuP9Z9SJVnImkRDPLnwB/dwOMUokq/q2I7+5jc6dGQA1mGt81lacM0JS/7oOk33YwphZA8u8p8Ob99U8oGKjjEqzI0WaKSokzU2oV7eq3netozHYCeIWOYAoDGF4HCSLLJmdJ+0MJYkhTpHOhRUMsIHw6uLdusaIAmlMRIP0oivTzYEuYs5JEptKCWRyPty1Sn45PwWov4Zfi2penTYtVpmmZtYyE5GNDQ6bY7lB3tvX/HM1qi8b8Z1mbQE3ge9S6U5dVShPGRkLPVpvOIUtSKdpUwJLhEAIaP7j9YMft7CmIJv6Q2y2SoGwTu48GBEQVHiWmTOtIbwkXQP7Zi06cMKwir/xfbKJ5t/2KmmTyKTZlDGE5IGBnJD8z8GWC6IinOpk8XFA6VLI9nIuhcdqFtXSIPBxP1Ya9QylQApg+zXdy3vZG9E2vdyNzrIntlR8xCQQf1iuNXPBZBjyA1iLvQPexgDnQ0oIk0VV3cydJyxBIH+5PgIb2iJM7Tzn/viB0PsFMBxJl21UrAHnkxQ9KDiXfK9b2rnRe+gv/wbnU/cQJTWkpbNHjcYpGwd/wdiuEIegYgADbnfNWfc2fncQLmS0xTlGNOTALCAhOzXg4qM4a8ayDwOIqKvcuwLJy04Fp71qTK22EVvQGWhfqtNgPzcJNUFUQ3S4n0zca7Y2EMdRm+RUHKtAeLLjteN7a7j9L3giPACpO0vrxjU2z2xWw0A81LHdMAnidtKonT24rmT4y0bp7WQhkE6iFBiZJENNIwwyAbOFgQ67DY8zuk9ifWsrc6sbwfBGyUu0RlvP8U4PTYoMfN/zdpdm1ubN33ra r3nZnSYq 3WcpLuh0oglneDdLase3X7AZTUzH1sg+JvOzJbjp4+3DQjV+3e04Xcl+XXHkMpT8ZKooYmZb64AH+6U9aDk3Xeh+JK4kNPR/zrZHKQm8QagJ7NcDDZsW7zOXPHLjWUt2eVefH1QErGSacGTLfUUMjbOnKQXqyB9V58dqwBMBkm2nKU+RWa79dGHKszn2yvaWzk5wQOSISC66qj4A8QzV4ZiFmERdH/kF/jBDomedaWk0/LSFSm/JtKpp7drFuHxl3/e8W8wuftxdSxmVF2JkCPzN+xRqxWBxal/5lczzNgiZnkrm5ihydon5W4c803AJz3DMH9SVlR2r4Nlcwb/JuBXQdlQBWHvBB1nlyS/vM7Oo7/ufIUxIkbq/A0nA7MBtkj+6+Rt3ctfT1AauA9ZKTkUbVI0k9IkVEeaz1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009183, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 9, 2023 at 2:05=E2=80=AFPM Alexander Potapenko wrote: > > On Wed, Sep 13, 2023 at 7:17=E2=80=AFPM wrot= e: > > > > From: Andrey Konovalov > > > > Remove the atomic accesses to entry fields in save_stack_info and > > kasan_complete_mode_report_info for tag-based KASAN modes. > > > > These atomics are not required, as the read/write lock prevents the > > entries from being read (in kasan_complete_mode_report_info) while bein= g > > written (in save_stack_info) and the try_cmpxchg prevents the same entr= y > > from being rewritten (in save_stack_info) in the unlikely case of wrapp= ing > > during writing. > > Given that you removed all atomic accesses, it should be fine to > remove the inclusion of atomic.h as well. Not all of them are removed: stack_ring.pos is still accessed via atomics. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko Thanks!