From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FB0C4338F for ; Mon, 9 Aug 2021 18:22:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 243B061004 for ; Mon, 9 Aug 2021 18:21:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 243B061004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 714878D0001; Mon, 9 Aug 2021 14:21:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C4A76B0072; Mon, 9 Aug 2021 14:21:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DA8C8D0001; Mon, 9 Aug 2021 14:21:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 42CCA6B0071 for ; Mon, 9 Aug 2021 14:21:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D66C8182331CE for ; Mon, 9 Aug 2021 18:21:58 +0000 (UTC) X-FDA: 78456361116.07.8A851D2 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf17.hostedemail.com (Postfix) with ESMTP id 9AE98F000787 for ; Mon, 9 Aug 2021 18:21:58 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id y12so26013105edo.6 for ; Mon, 09 Aug 2021 11:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ftVuG4BqRClWmA3Iio5cpbFgJTgza3Lrv72uDZY9cX8=; b=e2p4CwB/Sdak06YFwWS7xB4log0ZLI12SaQRtv3oOwJk9Y1m/p2aHkWA9SXpiWB7db 4qiHOYULfYTOdeHxYQWEx/5VwB1xajImW+W4fWHq0g5fR/Y7vIRkQU8F27QD4CU9hlUN ydC+Uo2y6YkPDQ4tSfINsRT31ruCMsn68e90LnpsA1dW44msW/vq3sr2NPuZGK6byQkt pEE276iAeBaGZ2f0SF+9nYjxp08s5Ye3fq3rlH15G+NMZ96E7/dHkBDUmO6kRjrN23Zj z61c6PTYtueLYPvUjNE9Hi0SE09dxAbGbTxMWVqE1SvfAhDwuEqFildI9CS9X5AkxglC C3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ftVuG4BqRClWmA3Iio5cpbFgJTgza3Lrv72uDZY9cX8=; b=r+uSkhlZuGUcZpBYHcqJRVtUjqz0ZWhkWY4miSUeJuFdEF+2ulQAV1ALPDJfgxZMH/ y+9Pw+AWUl2TqQcczHimbjgMRsWtPsbE2qkF8wBo4VJfKMns+wHFbTTt8yOU9l0TBiu7 AvIR9yl5i1/s3ADR6jCv1EZen27KOnC0sS52rBtXFt7WjdrYbdxnDyHM/CkZO3O//VWt qvOHuuBN49bxhvAkxIXF5lNDhgWF08gA37hNUMYCzTJRfjp1GbLzv8jp45gGjqpCyFpb LQllo3xEU63M/4yZg29Vq+D+KVsGuqh6f8YNBSJn27oiXRIVCeIZWG9arFhPjQpIp8PC ZHGA== X-Gm-Message-State: AOAM530/RV3RYPZ6k1dg//htJMHrTmzoOSySQtLW3f9MFoCsfB6IQsga 8abe+Y2ELnagr2pVPk0j4tpCvu3t9r/V1mk7lsw= X-Google-Smtp-Source: ABdhPJwEhGwSIXgli6nG4803LQR6iq+nzIISsQgAN1rnQR35jYEBmUSgZ3LvSYtmKRVnui1444iQUzixdY6Mjkto+o4= X-Received: by 2002:a05:6402:430b:: with SMTP id m11mr31667971edc.55.1628533317269; Mon, 09 Aug 2021 11:21:57 -0700 (PDT) MIME-Version: 1.0 References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-4-wangkefeng.wang@huawei.com> In-Reply-To: <20210809093750.131091-4-wangkefeng.wang@huawei.com> From: Andrey Konovalov Date: Mon, 9 Aug 2021 20:21:46 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC To: Kefeng Wang Cc: Will Deacon , Catalin Marinas , Andrey Ryabinin , Dmitry Vyukov , Linux ARM , LKML , kasan-dev , Linux Memory Management List , Marco Elver Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9AE98F000787 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="e2p4CwB/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Stat-Signature: 489y4t7y7xootmeygfidhm5c7a49f7gd X-HE-Tag: 1628533318-191014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 9, 2021 at 11:32 AM Kefeng Wang wrote: > > With KASAN_VMALLOC and NEED_PER_CPU_PAGE_FIRST_CHUNK, it crashs, > > Unable to handle kernel paging request at virtual address ffff7000028f2000 > ... > swapper pgtable: 64k pages, 48-bit VAs, pgdp=0000000042440000 > [ffff7000028f2000] pgd=000000063e7c0003, p4d=000000063e7c0003, pud=000000063e7c0003, pmd=000000063e7b0003, pte=0000000000000000 > Internal error: Oops: 96000007 [#1] PREEMPT SMP > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 5.13.0-rc4-00003-gc6e6e28f3f30-dirty #62 > Hardware name: linux,dummy-virt (DT) > pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO BTYPE=--) > pc : kasan_check_range+0x90/0x1a0 > lr : memcpy+0x88/0xf4 > sp : ffff80001378fe20 > ... > Call trace: > kasan_check_range+0x90/0x1a0 > pcpu_page_first_chunk+0x3f0/0x568 > setup_per_cpu_areas+0xb8/0x184 > start_kernel+0x8c/0x328 > > The vm area used in vm_area_register_early() has no kasan shadow memory, > Let's add a new kasan_populate_early_vm_area_shadow() function to populate > the vm area shadow memory to fix the issue. > > Signed-off-by: Kefeng Wang > --- > arch/arm64/mm/kasan_init.c | 16 ++++++++++++++++ > include/linux/kasan.h | 6 ++++++ > mm/kasan/init.c | 5 +++++ > mm/vmalloc.c | 1 + > 4 files changed, 28 insertions(+) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index 61b52a92b8b6..5b996ca4d996 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -287,6 +287,22 @@ static void __init kasan_init_depth(void) > init_task.kasan_depth = 0; > } > > +#ifdef CONFIG_KASAN_VMALLOC > +void __init kasan_populate_early_vm_area_shadow(void *start, unsigned long size) > +{ > + unsigned long shadow_start, shadow_end; > + > + if (!is_vmalloc_or_module_addr(start)) > + return; > + > + shadow_start = (unsigned long)kasan_mem_to_shadow(start); > + shadow_start = ALIGN_DOWN(shadow_start, PAGE_SIZE); > + shadow_end = (unsigned long)kasan_mem_to_shadow(start + size); > + shadow_end = ALIGN(shadow_end, PAGE_SIZE); > + kasan_map_populate(shadow_start, shadow_end, NUMA_NO_NODE); > +} > +#endif > + > void __init kasan_init(void) > { > kasan_init_shadow(); > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index dd874a1ee862..3f8c26d9ef82 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -133,6 +133,8 @@ struct kasan_cache { > bool is_kmalloc; > }; > > +void kasan_populate_early_vm_area_shadow(void *start, unsigned long size); > + > slab_flags_t __kasan_never_merge(void); > static __always_inline slab_flags_t kasan_never_merge(void) > { > @@ -303,6 +305,10 @@ void kasan_restore_multi_shot(bool enabled); > > #else /* CONFIG_KASAN */ > > +static inline void kasan_populate_early_vm_area_shadow(void *start, > + unsigned long size) > +{ } > + > static inline slab_flags_t kasan_never_merge(void) > { > return 0; > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index cc64ed6858c6..d39577d088a1 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -279,6 +279,11 @@ int __ref kasan_populate_early_shadow(const void *shadow_start, > return 0; > } > > +void __init __weak kasan_populate_early_vm_area_shadow(void *start, > + unsigned long size) > +{ > +} > + > static void kasan_free_pte(pte_t *pte_start, pmd_t *pmd) > { > pte_t *pte; > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 1e8fe08725b8..66a7e1ea2561 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2253,6 +2253,7 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align) > vm->addr = (void *)addr; > > vm_area_add_early(vm); > + kasan_populate_early_vm_area_shadow(vm->addr, vm->size); > } > > static void vmap_init_free_space(void) > -- > 2.26.2 > Acked-by: Andrey Konovalov for KASAN parts. Thanks!