From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA22ECAAD5 for ; Mon, 5 Sep 2022 20:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2AB280203; Mon, 5 Sep 2022 16:40:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB35A801E6; Mon, 5 Sep 2022 16:40:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9538880203; Mon, 5 Sep 2022 16:40:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F18F801E6 for ; Mon, 5 Sep 2022 16:40:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5651D12036E for ; Mon, 5 Sep 2022 20:40:30 +0000 (UTC) X-FDA: 79879199820.18.AA370E7 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf26.hostedemail.com (Postfix) with ESMTP id 0C450140083 for ; Mon, 5 Sep 2022 20:40:29 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id g16so6889494qkl.11 for ; Mon, 05 Sep 2022 13:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=0ypgvZx184oYWrPx4/BvTiSUQeZ6xUOF0aM/4U4hfak=; b=Hw2xlQvvPezvVyxfPxdnOm6BVP0INvcJBZ80TdNzoTEFHZDDFcSIpu5mI87YXUvb00 bT20dOT9Km+rhURvLSflJTYCoiT9EAfi2/ghDXo5X1PDfVMC9xTJXYERAtpd+x5b2VSa UnxSC/OhKcpcKcgnm2ojkTibqmvNalxK13+BksspjBIknC50aBz/6gfPPYes2Cts56DZ s/b3lhRRM5tSrtLWQTBW1CHGggv0ZdaXnBJ+WzQKGPpk9/jD+KKST3Yp6WMORX6+eYtn 2BGeQ7Kf9RlrKnAD5Tb8BAOuoB+wwEnxlhkian0jpgYU3xPvaG+hp3FE8+eHCNN7mYkd 6AeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=0ypgvZx184oYWrPx4/BvTiSUQeZ6xUOF0aM/4U4hfak=; b=v7W9g+VteesXe5cKvFYli05uc1QsAZegk82Y+T55K2toh9NP0kpePA7wGnfoYmBMAp M2/bclh96WOIpmLT58VFVwrD4GbsPveU64Uo8WXTGaXAGDsyovnASatOG7Igk8OPLtfT jFe+ZgMYkGwaCr3T5lzDfbnSr8EYkoUqvtMibD2CQjP/YaQjPPnLLos4Wcd4XwinppGk AjR8g52wU/XD47mNZ/kqPIo7eeq8bpU1swXc6zdc5KNsrWE2HMzQ29hFffpRtqtb5s7X XVsv2AHkuxIZRuHlJGN1I1V/8c/bLOcH4abGlaO10KJbfzYyATcDbWKZYNN4kNH4Jjwj hkYQ== X-Gm-Message-State: ACgBeo2NSqSJ7gfPN7b4m5kAqN2Kcz3+JDg9iF29k77h9QEeHLMa8DAR LplcyMZtU6uHahwfl03ctEYYbzw3ToZhgbJZ000= X-Google-Smtp-Source: AA6agR4VoTTQ9yAD7gDLrY+LwJ/yPs0WqHPudFH1zKDeMLs5RG5Kx8s8lYckgN3uyI8O8eQ348FRTTug0GJCd7/56xg= X-Received: by 2002:a05:620a:843:b0:6be:86a8:4099 with SMTP id u3-20020a05620a084300b006be86a84099mr28516707qku.386.1662410429360; Mon, 05 Sep 2022 13:40:29 -0700 (PDT) MIME-Version: 1.0 References: <0e910197bfbcf505122f6dae2ee9b90ff8ee31f7.1658189199.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 5 Sep 2022 22:40:18 +0200 Message-ID: Subject: Re: [PATCH mm v2 30/33] kasan: implement stack ring for tag-based modes To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662410430; a=rsa-sha256; cv=none; b=mDvj1aRxydN9XVYKa8DJal6+kVFdAxtDn2y45DhMakVMaQk+5ZC4/HoLFbzetjxsBUQFDE WBx5ym26LmjgaqJ7h7c/XHZLrFw+bR0kQ50B4+Zc6sQRgbglLgEQqxm9wfxtSvBOYNBXXJ iTQ8+yitG4ol8vqvuIYihgUZIVmaIkQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Hw2xlQvv; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662410430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ypgvZx184oYWrPx4/BvTiSUQeZ6xUOF0aM/4U4hfak=; b=sJjqPKgXmnXOsawD7ffjpvYFTNkyqj6YGCVWmF5HCw8bTb0Btd4DRFCKmJnnuS7iKW/Lj4 uxX03ilem0kMcy766yf49JX+5/z22Ogfpky0lPG8Ia0IKvL/qYmoL+CkrKjuyZl6z94YSA 7MJkjJmfOpYM6TmS0u0ufiTyLsQ46Dk= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Hw2xlQvv; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0C450140083 X-Stat-Signature: br39pwts49fez6cgfqkzgdk7gmgds893 X-Rspam-User: X-HE-Tag: 1662410429-50558 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 3, 2022 at 10:29 PM Marco Elver wrote: > > > Does your "The rest looks fine now" comment refer only to this patch > > or to the whole series? If it's the former, could you PTAL at the > > other patches? > > I just looked again. Apart from the comments I just sent, overall it > looks fine (whole series). Great, thanks! I'll put your Reviewed-by on all patches except the ones I will change in v3. > Does test_kasan exercise the ring wrapping around? One thing that > might be worth doing is adding a multi-threaded stress test, where you > have 2+ threads doing lots of allocations, frees, and generating > reports. There's probably not a lot of sense in adding this test: this part is tested during kernel boot. Even with defconfig, the stack ring overflows multiple times. I will, however, add a test for a complicated use-after-free scenario to make sure that KASAN points at the right kmalloc/kfree calls. Before I get to implementing [1], the report contents will have to be checked manually though. Thanks! [1] https://bugzilla.kernel.org/show_bug.cgi?id=212203