From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642F0C433EF for ; Tue, 10 May 2022 17:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD4966B0071; Tue, 10 May 2022 13:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C346B0073; Tue, 10 May 2022 13:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD6116B0074; Tue, 10 May 2022 13:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A735A6B0071 for ; Tue, 10 May 2022 13:20:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7ECE231F85 for ; Tue, 10 May 2022 17:20:32 +0000 (UTC) X-FDA: 79450497504.14.E1104A9 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf31.hostedemail.com (Postfix) with ESMTP id F17BE20095 for ; Tue, 10 May 2022 17:20:10 +0000 (UTC) Received: by mail-il1-f176.google.com with SMTP id n6so9892766ili.7 for ; Tue, 10 May 2022 10:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qBpP6H1QXIcItowN4taveL7xKKbFDSnKJ/RJbBSFPLc=; b=Lt7mUYnnSclD1NWgc2asYmgfRPG7Azod9mS1i2Jh8ultjaohoNhp9mUqvPMvwKfeFX +3lH2aXb4zAOEjHUEIh/QVpMfpb9lKwD1l33mRtYpWmJOuh9xpwJWcEVBzirx6yRiesk WDtra/VPQTon4LSEOjPwOfjDj5UL5OodfpB/IY8DYaUQSBbceMfgj7BfdTiPDcbWkcll t5vePG3fWKJma1cjQnbkPeCrEoMcTseLIfxwK+ZqjFpnr0DHujza42/uicb0xoV9VzGW pTeZVOaE5ChLPaILdSZp6y/jgaoW5QXbz0KwNageXa1xo4t9su4rAvd/x9qBn+UIntVt 3dog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qBpP6H1QXIcItowN4taveL7xKKbFDSnKJ/RJbBSFPLc=; b=1rurgXu2ajo2vtoEvYBXxpuWlJRmznsvqYbSkqJmq9Yw80Cy979SGH7qStfpc5Bl5W +bjCsD+zNJyoYoGV1xOfVUATP3n+uopLIfp/l/cc8rw56JMcAOFXaiL7dhuq+naqjYff hJaWXuY6vSTnuVgvuHhDtaqDTZ9gYnG/Ql8T0/kQaQ6zMvDI1HC5ifRbrb24WqW9mZcc TrKhfJ+qey57mwUOc67byhay5lMUsa21LBKIzXJwcmLDn4qVkSaQp1Px6cvNd/Us/Oz6 n5jc2zDkGZKaj31/HBJDnCrdz+K5DAYQUp2EtcdhDZsm7ZMiPR95DEnQKbv3WK6QPgZn 6btg== X-Gm-Message-State: AOAM530oJAnKzrFlxX+QTmMs9rXQuLb9A/CYkoBysz3JrtZbXzPw5ae+ ObHO+RYj1VFE/KbIu1zfbmRQs1Ok5vEYAtYaFrw= X-Google-Smtp-Source: ABdhPJwf74Pk1zAv2/dFYx/EPtp9CNrSoRlsl9nMcl48xPvVRkR3cgKz4KPOSlSBn0J9kL7SbZSWcNRZLopRSf3Quhc= X-Received: by 2002:a92:3609:0:b0:2c6:3595:2a25 with SMTP id d9-20020a923609000000b002c635952a25mr9876403ila.233.1652203231521; Tue, 10 May 2022 10:20:31 -0700 (PDT) MIME-Version: 1.0 References: <5bd58ebebf066593ce0e1d265d60278b5f5a1874.1652123204.git.andreyknvl@google.com> <47afaecec29221347bee49f58c258ac1ced3b429.1652123204.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 10 May 2022 19:20:20 +0200 Message-ID: Subject: Re: [PATCH 3/3] kasan: clean-up kconfig options descriptions To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F17BE20095 X-Stat-Signature: wggubqpyndn48doa8nnjxwykxqz9ob1t X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lt7mUYnn; spf=pass (imf31.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652203210-579197 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 1:57 PM Marco Elver wrote: > > > - Currently CONFIG_KASAN_GENERIC doesn't work with CONFIG_DEBUG_SLAB > > - (the resulting kernel does not boot). > > + (Incompatible with CONFIG_DEBUG_SLAB: the kernel does not boot.) > > Why aren't they made mutually exclusive via Kconfig constraints? Does it > work these days? > > Either KASAN_GENERIC and KASAN_SW_TAGS do "depends on !DEBUG_SLAB || > COMPILE_TEST", or DEBUG_SLAB does "depends on !(KASAN_GENERIC || KASAN_SW_TAGS) || COMPILE_TEST". > > I feel DEBUG_SLAB might not be used very much these days, so perhaps > DEBUG_SLAB should add the constraint, also given KASAN is the better > debugging aid. They are made exclusive: it's the KASAN option that depends on !DEBUG_SLAB. And KASAN_HW_TAGS doesn't have this note, as it doesn't work with SLAB at all at the moment. Moving the constraint to DEBUG_SLAB might make sense, but let's keep this patchset as a non-functional change. Thanks!