From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DE7C636D4 for ; Fri, 17 Feb 2023 09:50:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BDB86B0072; Fri, 17 Feb 2023 04:50:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E636B0073; Fri, 17 Feb 2023 04:50:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 034DF6B0074; Fri, 17 Feb 2023 04:50:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E5E1B6B0072 for ; Fri, 17 Feb 2023 04:50:38 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AB37341517 for ; Fri, 17 Feb 2023 09:50:38 +0000 (UTC) X-FDA: 80476314156.12.70832EE Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 047494000A for ; Fri, 17 Feb 2023 09:50:36 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ldqJT16L; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676627437; a=rsa-sha256; cv=none; b=oB85Ul6k8SQhtdkuehDU20d8VXxOE4oeuZWayZY1rUDy0QGdeZoN2AqO82zaQBULkc2SDT E7l2WM05lYoKuS+Xe8AClUbtHY/X6Bdjr1TBVwmgTQ/DKF//cC3xgacNBX9y3kMi7lenKP AMie/PEcfoz/vuzXUEqtud/r+bovbM4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ldqJT16L; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676627437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TTTi9sqA4taT7mQsE24E/BMxLx1RUOLEc/kI+W+BpqE=; b=Vt4GlNkfHjEmPNB1pSZvqpOIKWnKuTnDyEiO/CxryxeXbu+jfQa6adVOlzd89NlM1/4LyX 5l9mn2Tuy+7TFuIi6r7iQzmnTGBbUmKVdRvLlutCvlLWFo3htv/oq9Tyxw8i9JMFKFzjRh fJdwuX+j1bpnKI8dx3A94thEJ61k8Ck= Received: by mail-pj1-f44.google.com with SMTP id d2-20020a17090a498200b00236679bc70cso1619506pjh.4 for ; Fri, 17 Feb 2023 01:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TTTi9sqA4taT7mQsE24E/BMxLx1RUOLEc/kI+W+BpqE=; b=ldqJT16LYD9mRVCoQDkhTqpzelCTrk43UIm9gToZXACH7ESR6+f51LLd8iMLd5i/5f nl3FY3K8ROIZQCcRBgs6geEqkPCE6ZX5NGo7yikxZlT4eBDgiTBPFCM/O2I+mE3TLLQp xxSv6sHnC1p64srJM0pdaylau0YpEmVV2g7mID2jBm3CPJjRjJsnhE1l1ovuxnb19UeZ 7v3yeGw5+nQxN4zgNH4qIQEpddnYlwpbMaASCuLulgbimSdOOlAXOOG2xe0qH2Xumlhn 9F/NKABVsy/IUcawIKAblDjgdZddv6MR0ytIryuybIucgI/bTPw+NSQ7cIqlmT3ZAIga RWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TTTi9sqA4taT7mQsE24E/BMxLx1RUOLEc/kI+W+BpqE=; b=vvZv0U9ubsh+dXmOs5R3HLf/IetabdVlIGxMpfoL2viF5ZiEWK1R3sDLMNELvEAMeP 40bzP/Eji0zQlmUi07wwGMEJsGWiPWhTtmOE6n1J52NwF3PZjhNK+GNw0o+CcOAEVmOA DfQilRJBDZxysIhgZb6S+YAE1HRh/+FV5ENgUp0N3qX+fYmpi5WJQK+xxDpQF8zxNjDt 4Z3Jw1HiSAuguUyFUe3S193crRZE9qACTvOztrgUiH7h7aYqs9RlkYF9BDwhhvDBflHQ 6qgzW3t/rspHNayKwXIDOSxqN7Wy/boa8/q+F0PVkqLd2SS1zoz6Dr4nVVk2J+ePZcvG OtWQ== X-Gm-Message-State: AO0yUKXz6+OACp0a+QW29YuZkEBpObKg1DPm7M4G0UMA0u+B8BAUMe5h JBq52LVnz6E8GRBuaklCavVw7p9swVVfoOCtINY= X-Google-Smtp-Source: AK7set8fTycHc6RsvNxa2gkXvGfoR1jOksoqSKCe6wwtOOit5d83xUWBoUGm9a0tSVNpK0tSPRPHUS2WpSTyZKgtXv4= X-Received: by 2002:a17:902:c3cd:b0:19b:f946:e57d with SMTP id j13-20020a170902c3cd00b0019bf946e57dmr167155plj.11.1676627435846; Fri, 17 Feb 2023 01:50:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Fri, 17 Feb 2023 10:50:25 +0100 Message-ID: Subject: Re: [PATCH v2 18/18] lib/stackdepot: move documentation comments to stackdepot.h To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 047494000A X-Rspamd-Server: rspam01 X-Stat-Signature: psg3metqthtbj63nxbxkeqh7hwaqreh5 X-HE-Tag: 1676627436-457701 X-HE-Meta: U2FsdGVkX18idtjNy2t8fChSf472r8tg0QTYqlaYSpjaGEuTSt5NV0pyTGcb9ap5v4xgItkX2cJXTaoedTQKRn9R2sXScnMD8wUvt+EHZJSgcbMa3nDC8YxnQnSStUAcLVvoO/OuTRSFpFVOYUuy4loVvUudBayx/6d0KPtCAQsKnS3kD9EPlkd0dAxIN5ZenOi0BLp+Q2gUcfMZfc+r8kNLutNPxtTwgembjxQbIgjqd2A7nYC6tawJHWWZGY1zN/qr3Bg1zd6lf9KBh5pRw1hyqATIbNL27XBhVD1J0iSTccMPJBjVp0BN/qPi2Fg0WWjq22XiOTTsqTnvfd1Lb13bu0o9cNcMl+wm8Qe7zRQYEYMceaNH5oaCx3MJhdffmQ6GmByhsqP6UVBPdPXwR23tEjI8uNEpPOooR4YFo7c9eyQ+N/Gmn4MUXQqlrVN5w5jhSHvk6Pp2XaPOfiRgZNIsn4ubwYYwFKSuqaEhTMrlujYAQhoWQj2BoAthQz4ZVJh7qSKe4nD25FdLZvt5w8qJrnmQaf6bz5VBgXcMGQCLcpgl+9AYajgYrFyRoctA8IQZc3V4xJwmYH8RBMYs4ZBpvx/diVxDa8f8QFZk93zalP/J+MzbvO8VdzOlE2qheTgrzbE8PVSA77vNhACbF9rdXWBAd0Y7svh8oB9L3zC1SWvdAoSwIkYykrXEgLUunAwyZtLgSo8pGhFr9jJKPrWIToDD5Y581min17YZVRkEQmxrmpr+1FtViO36me7w7q4U3rzE4/6p1Fh1HGLja1kY+fHTkOEZ3c2l3OLTkNUQewuom5NHgrx313w42uMGLjZgdZnxJ+eNfQGUe+dFgHMGassPrS6QwzN62unq2tAqXzZ9GV0dnMMnONe9ZISFNo0LyneAvRq3M56uW+OOObmX76CSUF7+pJXqi60SYAomrjgOtq5LZbf6VFrKVLpYgj1sQRzbwxkZo3HCIOt zY5bpFG8 940fJ8ZQzq8RMCa6b5eG/1ih3GqnoHF+9SzN5BekSJsJpvAEt9+o32J5tSdxOQLWWntSXOUFPXaXp0caqYdYlXp89Nn5j5g6mI3C2PK3mM2k8Pj29ecW/TJOYL/JNmWhTR4fGHn9lF98oKFjR7WMnbAydTe9iEsjsabsC1dOIsBidyk28oyNgGPLgWFOcQlrBNxXakG2NVmMlg3HyPbyTzkEXVUSN7hKUPd8sFri9+YJGutWGrvmN4hBzCwmlDW8m1zkLlzIxSLYalQOkWbj6ShIpYCUz1B02RMF54iXiKRihtzKFnbHx1ECywi8RJqbpl4WTYQTEIBSljxtYkA73eGJcBsEdN4U0lvY5ifT6isoiajXfQX6Kn8LDd5PX8gdYb1gprv5cYdwJ0fPhj9yuGRCBHu98t+Dlzq92BgolApmRAUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 2:28 PM Alexander Potapenko wrote: > > On Fri, Feb 10, 2023 at 10:19 PM wrote: > > > > From: Andrey Konovalov > > > > Move all interface- and usage-related documentation comments to > > include/linux/stackdepot.h. > > > > It makes sense to have them in the header where they are available to > > the interface users. > > > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > > > + * For example, KASAN needs to save allocation and free stack traces for each > > + * object. Storing two stack traces per object requires a lot of memory (e.g. > > + * SLUB_DEBUG needs 256 bytes per object for that). Since allocation and free > > + * stack traces often repeat, using stack depot allows to save about 100x space. > > + * > > + * Stack traces are never removed from stack depot. > ... from the stack depot? I avoided using "the" for stack depot everywhere to make comments a bit shorter, but I don't mind using it. I see that Andrew already added a fix for this. There are other places where "stack depot" is used without "the", but lets save this for future clean-ups too. Thanks!