From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217E1C48BC4 for ; Thu, 15 Feb 2024 23:38:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8D8B8D000E; Thu, 15 Feb 2024 18:38:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3C248D0007; Thu, 15 Feb 2024 18:38:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DE108D000E; Thu, 15 Feb 2024 18:38:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7923D8D0007 for ; Thu, 15 Feb 2024 18:38:28 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 54A9C1205F5 for ; Thu, 15 Feb 2024 23:38:28 +0000 (UTC) X-FDA: 81795654696.25.6A7F6B7 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 86BB240014 for ; Thu, 15 Feb 2024 23:38:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XyxgL+f4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708040306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sn0sQTAwhEvIBiXDzaG6iULDQCmeFqcNJO1N7EmRs4g=; b=ALB5va5UzqrxMLmOlHkFLutHq+4GH3AUbvLSMpKa2w5Gc1pAzoqZvilf1ssmYzBSsY/qbs COGVQpG/qeIKwcE2PGBSaL10flruDGVdOpXKDAGttxeGjNoMSrtanID2klMSM+UyLJO56L iuDF2vX1g1n9c0G3stJCdHQC/bUdRe8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XyxgL+f4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708040306; a=rsa-sha256; cv=none; b=d6FZbjjv3D/bye6pgQUHEYKWCUiTsiJ/AEyVfhruwZ1wZQzVD8kY1KZZuMgEHuV6U01dPB 9yX1bMGT+eBCO6Lgdg+X8HO1g5JIsKzSNJmgKvanpOLSb+ajxGTme+Om2ff8mtthRUcgJc Mb5jcKBmIxhSQI++kUypjHGww7b+l48= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33d18931a94so153880f8f.1 for ; Thu, 15 Feb 2024 15:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708040305; x=1708645105; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sn0sQTAwhEvIBiXDzaG6iULDQCmeFqcNJO1N7EmRs4g=; b=XyxgL+f4oGRLDE+t/Sk8LZQWU+faf/LCyM200JKjEBxfoGfrFt3wKhXaCfvCBYK9IM w53AAV2Yh7beEBaFkFr/oVJ65HdJsUt/v4IzBN91zXWHneh/ddDoPqDPjVLdr45HrCpk Li4azv8C/OoA1l/LvjOZAMea2rZLxtK8PVPX06A1MlMEswVHLzUhXRph2b/gaZxYGxq2 YxaVLRqk/46h8/AUoXxOTO1WL2IqoDs32E4I0c/45VxmjB85GDGrOcMzaSnAesBxgCiX Y7yuY3kGvxOC+V2EgycYuxAkmdc7d9m1NyDGh+VhshUJl/6/soNjMGUmxVSqJMkxD70C wwxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708040305; x=1708645105; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sn0sQTAwhEvIBiXDzaG6iULDQCmeFqcNJO1N7EmRs4g=; b=dspAtNpb5ozi5J/SyjvtWnZG3c5kRgu67U39Vzg7tp4DdcDh2a8DP62yRfNhyOjlHK 6xNKdg8x4pcVIfAe8gGXVK/fqf1I4No7IqX0EBgyVu71yL70gdTs8L1Zv6/NyAZSJAOo ivWNfOFSLpnbTwPTbUpvP77h3jJLwWuFARpPrJTWA7+qeiyZ8KVKm85+4fqpJgXv62Cn YaNuZjgnFbNLfBPscFoG6GFVclayun5xFlvKocPRWoSezu/iEjttJnr5c+a7y6E88WN6 W9NRZ7nLT3nbq0nau3I5kO5ZTStms4VjLHs93CqiUJ/WssmhikJ4akPP3ZUejbauMgvg qtPQ== X-Forwarded-Encrypted: i=1; AJvYcCUBzCHNmEvzDXl0e7wCHiy6alubsoMWiNTjG5C/DO5YoyOoDeM5/GZyhCHQjXy43ekAUjRlWxrNv+WN2FaikQgWOpY= X-Gm-Message-State: AOJu0Yz7euc7d6z0YklznUduVDGFGLlPJr5+63OGd2leNG8jCT3aeRE9 YAmbjPyveIEn0tMOYn2wbncKZ20/uaxK/QPwZ7mKBQVrlQTsIjEVA8SDAiGC4yl2tNnsPkWQdBI tWNPb/ua6A5sfXcJgqduFGcd5ooc9+ZREJ2o= X-Google-Smtp-Source: AGHT+IGIiVNXedOguEZBF0GODW3XI1skmz6d9iA0LyDWVH2pPb1XYu7+9mg/uy3R1yv6L6XiAK2M+wxThACPvSx96Ps= X-Received: by 2002:adf:f0d0:0:b0:33d:174e:4813 with SMTP id x16-20020adff0d0000000b0033d174e4813mr453648wro.23.1708040305196; Thu, 15 Feb 2024 15:38:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Fri, 16 Feb 2024 00:38:14 +0100 Message-ID: Subject: Re: [PATCH] kasan: Increase the number of bits to shift when recording extra timestamps To: Juntong Deng Cc: ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, vincenzo.frascino@arm.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 6yqm7a7b5yobr54zonbjzoufyfaqnk51 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 86BB240014 X-HE-Tag: 1708040306-370301 X-HE-Meta: U2FsdGVkX1/cNORup+wzD70T1BadEROM/7A22xsOAbEUK10Sf0JsJ4IIR8gqhM4WLVBFNIhqMAEY5ZbyFxOzsVMJGfoaYA8JK/sOux9gIpWdmO2bQCAFppIsIzG/5cIiQMaEJh7MhTuxzh1KXPNw/sdMvJIj0BOeoZhHB5T+B0vokzSFPa27U8arZJwRxCzFw1DH0msZT1l9lqWbV67VdhP2qX0rDzvMnVTXP96PJutzdak/0DhGENUor1rEySM2YvZCogdUolunOGfyoR+iSXA5yznrUIGHXUqmiKc1OHHpXgYCuojBlle1vZQPV76vFsZVyzLK46XSazbnQYoQO4VeKpO15XTLtLurzeuU+1MWe+eZWZYhgvX7ZMZ8cSBwlabR8RIaltGF0OPMSItQArYHlBdkvyWQiBOPlB5ovzYIxfFhkvUOCdjka0SGfGpf1teqrKJLVn6sQliL74pNl9awpTtGKTTfd7ZFCudfehNpizEx0nW8s8Msq4b9Gm9yr1TeTli3KREK4oOniZy4Ea35ccKnrQh/vxTRNTWWth01FnlvYmYNpQ16smSq3WaKY1as2vT3f6f2MgeOziTw0fsxA1BE1Km5HHZhpknlbV2gC4Ntqq9KBe9YbFBwcpgjhLQxZitaB+nSIghh5O28t9pOI0U71Y8dEO67VHdvSG7UhH5/GEzAwN9bbjjwF4XY2Js31QeH/XxNN+sHWn7MxSlv6dvojtMoJGT06nif4Pej+JdkcT5qEHlw3vvBFuUckvvJdMX6B4W+A60ODa9jRwBemDJFCCvTiNtbe2l3pP3+MzVl9l7caOAN+019qP5+Kd1ej9XpOsbgVxo7d08zNhWx0yawK84m8tB9KmO4x6ZdCOBySrBNGpTtns9UFtLiSgRr3QJNBKrLDHeuhpB41AWM3Foytrp8BSO39OnZ02dTDFPITC+lI0xkNT1dS1Cj7LO2ALAzxj3y+U0F/Rs pcKXgHiR JPggjdjmfXIn+cuzCy9kM/E6WhSTR9P3h976I+qCgY3AES8nGPWgYYKkNwlyjmbnRhr5UOIQSiBfMEPSrOQ9N2kvN8gGIzJm5GziXbZU4As9ZZoEH1JVMn2oq182Tb8jvc6veM4iNu0Wz0cQOwU/H60PMtwrq8Jj6ZyHui0tXQUWtj2wFSKoZBh/nkFiY0ptdDFxsOZeXIVjzirNP1j0Caosvrx4t0xadaI+/x3xSA1f2sYBcU+RkXKW2LzBBy7H5jtJvXt9MnhXfPYktk2EZPqGFwhCUiLeDu/DA2z/Rvi8HUNZ2gsIZ6+pREDeKdI8XbYplVUf/RCjlwsVTxBJo4wd6Ls8p/XNOmmLp9xFTezs7BsPHUMo21tvb8mL+HTeOl8tZNwrA16JetttFd93AgDdO7LSiXeazxdPQCCVIHXYXPPGxFVzdzz/+t9+lZAI8ZK3HCzVTIH1pfMLz9kaITVURNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.379626, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 7:41=E2=80=AFPM Juntong Deng wrote: > > Fix the mistake before, I thought printk only display 99999 seconds > at max, but actually printk can display larger number of seconds. > > So increase the number of bits to shift when recording the extra > timestamp (44 bits), without affecting the precision, shift it right by > 9 bits, discarding all bits that do not affect the microsecond part > (nanoseconds will not be shown). > > Currently the maximum time that can be displayed is 9007199.254740s, > because > > 11111111111111111111111111111111111111111111 (44 bits) << 9 > =3D 11111111111111111111111111111111111111111111000000000 > =3D 9007199.254740 > > Signed-off-by: Juntong Deng > --- > mm/kasan/common.c | 2 +- > mm/kasan/report.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 6ca63e8dda74..e7c9a4dc89f8 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -55,7 +55,7 @@ void kasan_set_track(struct kasan_track *track, depot_s= tack_handle_t stack) > u64 ts_nsec =3D local_clock(); > > track->cpu =3D cpu; > - track->timestamp =3D ts_nsec >> 3; > + track->timestamp =3D ts_nsec >> 9; > #endif /* CONFIG_KASAN_EXTRA_INFO */ > track->pid =3D current->pid; > track->stack =3D stack; > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 7afa4feb03e1..b48c768acc84 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -267,7 +267,7 @@ static void print_track(struct kasan_track *track, co= nst char *prefix) > u64 ts_nsec =3D track->timestamp; > unsigned long rem_usec; > > - ts_nsec <<=3D 3; > + ts_nsec <<=3D 9; > rem_usec =3D do_div(ts_nsec, NSEC_PER_SEC) / 1000; > > pr_err("%s by task %u on cpu %d at %lu.%06lus:\n", > -- > 2.39.2 > Acked-by: Andrey Konovalov