From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A20CC07E99 for ; Mon, 5 Jul 2021 14:41:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BFD9961959 for ; Mon, 5 Jul 2021 14:41:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFD9961959 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 541826B0071; Mon, 5 Jul 2021 10:41:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 518DE6B0072; Mon, 5 Jul 2021 10:41:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DFB06B0073; Mon, 5 Jul 2021 10:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 161A76B0071 for ; Mon, 5 Jul 2021 10:41:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 859941843F4C6 for ; Mon, 5 Jul 2021 14:41:28 +0000 (UTC) X-FDA: 78328797456.02.C6E6469 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 41490F0000BC for ; Mon, 5 Jul 2021 14:41:28 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id hc16so29320307ejc.12 for ; Mon, 05 Jul 2021 07:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pAbvWLlq9ACgk831d9oOZ3Sk5AFBCQPn8le+JrfsWvM=; b=oVi79ZcuXpZ9CHQUw/iwBcEb7qnIyQJZxddWmaug5BjbgLJxQmbZtwFADrZwSfRgi0 iYp7+OZxfbgyxjPrxdWRK2Jp6WWTtuZt4y/5l7bbDR7YFXreTDQcI/20yVezPhFV6E8J HWZTS8Czi7PocN4l6NdzISXNDhAhsZL8AZaftVh9uPh630z0UvaqDZ51z6j12YP2TPU+ WjzEYhdjQiUCrKHdIZPta27KizeaY3gaIJTOuNg7VoWhkWAu9jWrGxJgKdiUoLi9F6VM fYZKgiDGjYpkVg0p23Mpwyom3AEsxo2Jp9sGvVBR6gSeVO6E2b9sSZSCqo8Xv6+QCIM/ JHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pAbvWLlq9ACgk831d9oOZ3Sk5AFBCQPn8le+JrfsWvM=; b=sqVRMEot5RBc7cyD7CBfrWiUfIU/WA3GswxQ6o1fh1uGcqNSI80OO33K35xmcVyNp2 jGahQeGxwMBXm4kndLBwQbIhmJwwG+9sfwZjfn06MV6F+wyYFUUh4c945aG4kLdZ2wpR mvwrLirFA+skEwCI3eAWQ2hiEFy38vhMf2NkS2Z2B3qRgwqgMaZMwZ2hZt3mbS6XIP+Y VDP42TcuKFLF3zZnAeuNjlOHWa5NgTH4WmkpiSj4lbCfrwaGe9k4uS/n1qLNyF/2gPmW 0xDXHasFmprd4jQbHIGXtZ40YN3Ja8gzQAECfc6IDG5ZCaE2zeztUhGviNgywASZK1g7 HXJg== X-Gm-Message-State: AOAM530L3ht7JOsc4924YRDELNdynZWyYaMVrmM4r4VVd2VzTXzHKRrn /cXO7Z7DMOx/pk7RpZGRPQXLh0w7OY85/LovCX4= X-Google-Smtp-Source: ABdhPJxBWF6k4qxL/WTwuWOk/hgPz7DDwDGY9wC2hQ6nob3k3f/a1TDRAxqgf6EJG4KigP3jzY+N6o6bOFZzFtf+ZMI= X-Received: by 2002:a17:906:f14e:: with SMTP id gw14mr13913822ejb.439.1625496086980; Mon, 05 Jul 2021 07:41:26 -0700 (PDT) MIME-Version: 1.0 References: <20210705072716.2125074-1-elver@google.com> In-Reply-To: <20210705072716.2125074-1-elver@google.com> From: Andrey Konovalov Date: Mon, 5 Jul 2021 16:41:16 +0200 Message-ID: Subject: Re: [PATCH] kasan: fix build by including kernel.h To: Marco Elver Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Peter Collingbourne , Catalin Marinas , Vincenzo Frascino , LKML , Linux Memory Management List , kasan-dev , Andrey Ryabinin , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=oVi79Zcu; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 91y4yftxfz6z15a8ew166jzxkgnhpfaf X-Rspamd-Queue-Id: 41490F0000BC X-Rspamd-Server: rspam06 X-HE-Tag: 1625496088-653674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 5, 2021 at 9:27 AM Marco Elver wrote: > > The header relies on _RET_IP_ being defined, and had > been receiving that definition via inclusion of bug.h which includes > kernel.h. However, since f39650de687e that is no longer the case and get > the following build error when building CONFIG_KASAN_HW_TAGS on arm64: > > In file included from arch/arm64/mm/kasan_init.c:10: > ./include/linux/kasan.h: In function 'kasan_slab_free': > ./include/linux/kasan.h:230:39: error: '_RET_IP_' undeclared (first use in this function) > 230 | return __kasan_slab_free(s, object, _RET_IP_, init); > > Fix it by including kernel.h from kasan.h. > > Fixes: f39650de687e ("kernel.h: split out panic and oops helpers") > Cc: Andy Shevchenko > Cc: Andrew Morton > Signed-off-by: Marco Elver > --- > include/linux/kasan.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 5310e217bd74..dd874a1ee862 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -3,6 +3,7 @@ > #define _LINUX_KASAN_H > > #include > +#include > #include > #include > > -- > 2.32.0.93.g670b81a890-goog > Reviewed-by: Andrey Konovalov