From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F38C4338F for ; Mon, 23 Aug 2021 02:05:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3D2861222 for ; Mon, 23 Aug 2021 02:05:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3D2861222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5986E6B006C; Sun, 22 Aug 2021 22:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 549578D0001; Sun, 22 Aug 2021 22:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 437566B0073; Sun, 22 Aug 2021 22:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 2684B6B006C for ; Sun, 22 Aug 2021 22:05:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D0F038249980 for ; Mon, 23 Aug 2021 02:05:10 +0000 (UTC) X-FDA: 78504702780.25.C29C37D Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf19.hostedemail.com (Postfix) with ESMTP id 8E1D9B0000AC for ; Mon, 23 Aug 2021 02:05:10 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id l144so31048072ybl.12 for ; Sun, 22 Aug 2021 19:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=a+lvHaFeJkkkAOQLbRXTzBc/XIrK+hutoY3j14PFZrI=; b=MfNfBTZ2vcGCOpo/Q3VnL1nXtWkssmtLA67FYLhXkbprxOmIcdaa36AnwIWnjLW8D1 HLM7wFzyNanE6G8JALSOZVZwO8ZFHnC09STF42HCeoYDAM4zpFJSSDdCg3zCUfMMacFr Db8KAmWZ4jjC3mg4yztVvenudvzmZTy4BlFHUdEt75kQz0bcYJm2FdhLzVcR+UGlxQy2 QP5aSBZX6VOC4bDPCoq4+D1Vaz4ZeeFGnlckBf+QM3O5R5cj/dsf0HLTWnLfKmQeC6Vp duEdP6c/qB4BGDGN1APcKqtckive9N3vW1ESJSRQB/jdS00w5p1RHegoBup37/Xcz1+3 75sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=a+lvHaFeJkkkAOQLbRXTzBc/XIrK+hutoY3j14PFZrI=; b=BkAHMeo+WyClwID6xtNjJB2kbjHeWnLypKBhIM95MUPjmYRGhehqg9JgLZhzZ58srv KHmvMDc2mOAnltu13ahF21PyfBUJbHY8IDIT+hiIzL8eq5HC2dlim7ssx2ySzNL+SbZi 9frPjm3ERgGGZpTpoty+YHDLTP7SLjVo3M4Dh2t1iepIQZTgaN9RWSqGB87Lv+ljAWf4 m9ETF1NEH5FJM79h7adprH286DC3pMK4GhgFshgGPrfBZZU1nhFuuMgMbRkpkKmyMads gO3RTDHuJ93XqToQGHecTywyEHCJK7Jb9jSMGHYiFLlot4HIpPkosc8uo/y10Rm0hLqB wnbg== X-Gm-Message-State: AOAM530JJfcQkco141zW2aktV2nWAA/QIanEfgMuXvOFaTy3dzLsPKju TJH+XOOqzGnrHj0mmM5Ft5doDXq7R6O6NEJei04= X-Google-Smtp-Source: ABdhPJyTFctQxEFbGQTEAfjJ9SfrzImsMKkPY0StuBM9e+G/q6jRwHnf/sBE+LKSoOeNbdsilCTJjhL7/Czd0I9Fd5g= X-Received: by 2002:a25:b845:: with SMTP id b5mr40137971ybm.343.1629684309946; Sun, 22 Aug 2021 19:05:09 -0700 (PDT) MIME-Version: 1.0 References: <20210820030536.25737-1-yaozhenguo1@gmail.com> <20210822151952.23ca9547316dc34c9f3bd482@linux-foundation.org> In-Reply-To: <20210822151952.23ca9547316dc34c9f3bd482@linux-foundation.org> From: zhenguo yao Date: Mon, 23 Aug 2021 10:04:59 +0800 Message-ID: Subject: Re: [PATCH] hugetlbfs: add hugepages_node kernel parameter To: Andrew Morton Cc: mike.kravetz@oracle.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, yaozhenguo@jd.com, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=MfNfBTZ2; spf=pass (imf19.hostedemail.com: domain of yaozhenguo1@gmail.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=yaozhenguo1@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: zggg89nxzwdx6af5kti44xu5oab7tffc X-Rspamd-Queue-Id: 8E1D9B0000AC X-Rspamd-Server: rspam04 X-HE-Tag: 1629684310-54917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: OK, It's better to use a concise way to add this function. I will use a better way in the next version. Andrew Morton =E4=BA=8E2021=E5=B9=B48=E6=9C=882= 3=E6=97=A5=E5=91=A8=E4=B8=80 =E4=B8=8A=E5=8D=886:19=E5=86=99=E9=81=93=EF=BC= =9A > > On Fri, 20 Aug 2021 11:05:36 +0800 yaozhenguo wro= te: > > > We can specify the number of hugepages to allocate at boot. But the > > hugepages is balanced in all nodes at present. In some scenarios, > > we only need hugepags in one node. For example: DPDK needs hugepages > > which is in the same node as NIC. if DPDK needs four hugepags of 1G > > size in node1 and system has 16 numa nodes. We must reserve 64 hugepags > > in kernel cmdline. But, only four hugepages is used. The others should > > be free after boot.If the system memory is low(for example: 64G), it wi= ll > > be an impossible task. So, add hugepages_node kernel parameter to speci= fy > > node number of hugepages to allocate at boot. > > For example add following parameter: > > > > hugepagesz=3D1G hugepages_node=3D1 hugepages=3D4 > > > > It will allocate 4 hugepags in node1 at boot. > > If were going to do this, shouldn't we permit more than one node? > > hugepages_nodes=3D1,2,5