From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65985EB8FAF for ; Wed, 6 Sep 2023 12:09:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D67FD44015D; Wed, 6 Sep 2023 08:09:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D181B44015C; Wed, 6 Sep 2023 08:09:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C118B44015D; Wed, 6 Sep 2023 08:09:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B1F0F44015C for ; Wed, 6 Sep 2023 08:09:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8BEE1B4071 for ; Wed, 6 Sep 2023 12:09:49 +0000 (UTC) X-FDA: 81206053698.02.94BAAF4 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf23.hostedemail.com (Postfix) with ESMTP id B6555140006 for ; Wed, 6 Sep 2023 12:09:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jclWnCDK; spf=pass (imf23.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694002187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Va2nW+Usqp8ZrfnRefu/KyBtk1DZM9iZcObEbx3C5o=; b=glpjQ3Q0FUmCxPbA15+61aBPLdBsy9sOj0bIQ5CkaEHGimnvkYTBrJYdsnwPwZbQMKJC9+ PmcS8QnQZYWPFBFYqSfWSxdaiqbRLKlN8SE0EN7nVykBlhM1bZW6ej8Q7CegQ51C1fXzCI QeGQiLBPbm2ZPicMPDnlGJsLnXGgAMw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jclWnCDK; spf=pass (imf23.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694002187; a=rsa-sha256; cv=none; b=jk2GYG86iUosHuBOUiBbwoLkEPBNq05FgW28ydEMuUDU9pYn4BnRKbdZBB08LY3iICdSGS 4WEnIigMpKecplDpw0tRqKs+UDOdaySQOr4kkI875AX/eWItI/xnsQVe8fMPFHs9Yg8oB7 xAgTnMRjcSzzPAkK+QJbNxmFL2EWmos= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-79275d86bc3so148804839f.0 for ; Wed, 06 Sep 2023 05:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694002187; x=1694606987; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2Va2nW+Usqp8ZrfnRefu/KyBtk1DZM9iZcObEbx3C5o=; b=jclWnCDKmLESnPTrUKCnX2BkWV6FLKNk46dmsMPQIfskwAoZlGbZ26hFwxWm8Tx4s2 RNrVpz14oply8KtZQwYZhN7wsW3aj+t57u+xXSkjP601/uiFUhVoWhSwdAipbXJbhaIZ 6DvkDTL+NIZ5zZcMN8kZaWhiCd+YumKQ6bcpjzgGec7hEW0C+HBSvijXVrGyFXq+Zl+9 uPRG4kO21uco0PcR8lDW++oDdMIG0EHA67om44HgixNezsAy8UJkt2uZV/hA5G858T7a qkmyC4IbnhV0mf9X5vdKcVBcPlNTjdPtmaisQl3jlbeYJU9VMDhtkAPj/vbeCJIFwVfg G+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694002187; x=1694606987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Va2nW+Usqp8ZrfnRefu/KyBtk1DZM9iZcObEbx3C5o=; b=NMHsLzEuBGX1DXwHgCDaNw2Sf8Cv91v/LSmg2JFKC95wO29JkBTcyQ4v0KCeuC046p 1/dkLvepehjutg6en7oYL4VafAVeCetDS3sCbXBrGLMUrUW8P4fe1fDhDLpsNeY5Du4W ubSQjCuPQBFCcceBWhuJi7IU0krGYkjRRiqbOaYKQqESbj3hoish0cFK85Pja3jBlBDk vaYECVHFcuVYAAV9ZoYlwzLvs0Y54Eovcqb5QGlv//+b/eWNp0BgWowjZnV3G/gqyHR/ 4DtCGRAcMpqCWisDbTOokI4BoHmYvBNoSBFrP+dsq1YdG74xOCoFB9YmuXnc4/1gx6yL LTlQ== X-Gm-Message-State: AOJu0YzZaxOWEc+pQyzXW3RAmK6QX8tsJvtRsdbHM8XWtakrvQkIhAkb LuGET1SAWJdvzW5681qb0/BOzmT/HDZQpZXiGd8= X-Google-Smtp-Source: AGHT+IGWtERQu1uvVBVvppCTlAc4PSePNP4mqkpS/y84Zw6WXafaYObIR3DZxO29+98HddvyRnwByAxFYYmURZplQcI= X-Received: by 2002:a5e:9e41:0:b0:792:9ace:f7ba with SMTP id j1-20020a5e9e41000000b007929acef7bamr14897870ioq.11.1694002186899; Wed, 06 Sep 2023 05:09:46 -0700 (PDT) MIME-Version: 1.0 References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> In-Reply-To: From: "Lad, Prabhakar" Date: Wed, 6 Sep 2023 13:08:46 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() To: Alexandre Ghiti Cc: Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B6555140006 X-Rspam-User: X-Stat-Signature: fc9ofmaqge81z9gcsgg8f5bktzycaq5q X-Rspamd-Server: rspam01 X-HE-Tag: 1694002187-87296 X-HE-Meta: U2FsdGVkX193QjWurDfl1+wNfKxrg9H1A7uc49ogaCwH80sUkdfYhq7LKoy/E6M5HecKWmFUoaCdz9gcR00tyd4BE33U79HkFsnXkI2bH4XY1Lz2c96RZuehVcAjudzHTx+/cik1t9mx5+79v5F+baTEjGBk7RmZ0WRGfNG5a6K91LKyBF3FfJldBvDEEsjibmKP+zEEZrbuIaIGwrpQFJ8rAWRdahnAQdd29QSajQuN+FEV+h4ZZsh+8Ay7cyB4PPe0J1BiSkgtOwm/ImK2ZXO+11k+4XZ8eqTAwmvYW3nejG1Bbf59yYDeeKB+jcRpDfY8QvEQDInz0ExMQpJ1svfjCnFK7nPlIj+kY5OBzIbRfOXtuS6rwt7m01Kin1mZSzB+G3pFY6pDM8ILIvtAj/97Z1WwlwLz21KapytkzUm7BF4CgeBuIHHCTRa+LqLvf+jI3H19sGkzbd9+FwVfcgspH/AFHGs5yXtHrvVU46znlaXFD90NMfZZY0q3HIC9J4X2e0+Z7mp/JWq2Bqt9ASN9gDiTR/prLZVAwLhg8qHeLSTaPtQsDgzYMpYR4XxJJaJdfPvQ+JjW2Wmb+OFmwYU4PX1Leq73sxiCsDooPpeR2si1bppJRPRsPS1U6uXWR3JipXUv5sPl5laFYwyq97mfiGtb6B6u2M7/L02TY9w1fW0QXmsTT5te9tIi1jUlQyTAH/9kISmlOSpEV944zN6Z6HHQqf7V2UvvGOwKVY7n6ffqS75PjvLM4jvfpPot3u8rDYQUudmTaWBpCuthPyYhXubYMv3vSC+0YCo8rdEW1ygqM5F/uQQ19IMZuakS4uLF8RqkO1v0Yxzbnx9VnQkVyzKqmKfBkLI1XcxudsaoxCPjBJtF0E0ZIKBOyUtpIxwW48msZmKIcdhDNISxsaebglkBh1BPWdGpkoMUrGGc6g9LPOXJpTORKaM+bRdvKlI/ytCmhpO/m42S9wv do3nF1Sn JCdS0S0DrXaCYZ/MVJAPkRaQ4+e+BfBVB7NZoCWgtmFheeNfkfs5OXYOlYScKabVSphqcfH7HIOl2L56lV9O/aOw+y9IL8gKxKN+OhkcIylHtrj7S4/FQsBgLE7WOa8JOvjmS+QtTtdaZ6ytImtCFOWDkH3p/ZB76OofUAwu7anilOBrSNOgLZ2ZKEPpjW+jobJ4D7ujQZxodcefkZWayOkyfL9PJt5k4aU8NfB5KgHpLY+bwPBke4umF/iB9nyQ9/UAoE6ZL6GRrbb1ysWVZ54BHWowzN4ijUukRkl4q3L7MXZ9GYWrI1IO3L+qOeJ7K9xaruojY32bh6RcvsCQo38vZD4Hr9NkRzq1vFr8cKvqbKAtjDWdwZoicXty4EQJiCVuEXPlmJCl426xoDgYp0hDXNS3K0kmE+4st1mhA4x00VBrlg9MDDv8wNdFzbOBKUX5hidIunB99JhANMy4Yr2QnmrVc3ZPCi7fB8XbZBaAcNB9UkZDnIPbHZ7LSAk/9ZIrn4UnhG6HsZpGLDMtlTnefRa+ve2UTdrry4U8k0ZHwvVoB5Lz2ujGVIkyp87N4UhIYceex2Q5JrBiFR0hx+H0lZqJaPnkYSBVQvvKHPSBwnG3o7JByH0UDylsqEoxazM+PCLmKFHXjSVU6ZVjbgp7jKkCi1TX4hfPXvEEwRTIOnVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Alexandre, On Wed, Sep 6, 2023 at 1:01=E2=80=AFPM Alexandre Ghiti wrote: > > Hi Prabhakar, > > On Wed, Sep 6, 2023 at 1:49=E2=80=AFPM Lad, Prabhakar > wrote: > > > > Hi Alexandre, > > > > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > This function used to simply flush the whole tlb of all harts, be mor= e > > > subtile and try to only flush the range. > > > > > > The problem is that we can only use PAGE_SIZE as stride since we don'= t know > > > the size of the underlying mapping and then this function will be imp= roved > > > only if the size of the region to flush is < threshold * PAGE_SIZE. > > > > > > Signed-off-by: Alexandre Ghiti > > > Reviewed-by: Andrew Jones > > > --- > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++++------= -- > > > 2 files changed, 31 insertions(+), 14 deletions(-) > > > > > After applying this patch, I am seeing module load issues on RZ/Five > > (complete log [0]). I am testing defconfig + [1] (rz/five related > > configs). > > > > Any pointers on what could be an issue here? > > Can you give me the exact version of the kernel you use? The trap > addresses are vmalloc addresses, and a fix for those landed very late > in the release cycle. > I am using next-20230906, Ive pushed a branch [1] for you to have a look. [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug Cheers, Prabhakar