From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265B2EB8FD7 for ; Wed, 6 Sep 2023 13:55:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21401440161; Wed, 6 Sep 2023 09:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C449440151; Wed, 6 Sep 2023 09:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C64440161; Wed, 6 Sep 2023 09:55:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF6E1440151 for ; Wed, 6 Sep 2023 09:55:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA89DA0BB3 for ; Wed, 6 Sep 2023 13:55:44 +0000 (UTC) X-FDA: 81206320608.06.DE9A7D7 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf28.hostedemail.com (Postfix) with ESMTP id E803EC0021 for ; Wed, 6 Sep 2023 13:55:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ru8Iy1Qi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694008542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gbyDWxJfqMgWVcylxBXfX+Os4k5+YTlBDL7fHB3febM=; b=jT4WetalegIE+ZkojY/k2wXrNRxDblv+nK93b82ZaKMwWqcx2mqzzKBxJkEGPyrvPxsbVO RKibtBgb/F0IVjWmH+Fvcd+HGjt5uur8H8+rNI0NDbcmIa5DNa33nlLliIjbY9OdYqUvOB ManN6X73DjGZEItbTtZE0l026QR7gck= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ru8Iy1Qi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694008543; a=rsa-sha256; cv=none; b=2KlakRxZNmbx7P3OMzxCOfSAOEPyT2WTKu5XsPEw1qPIZha5hg//+vEXLyXBXedIrhmRW9 t6QbNpKs9YjNzD90ut/rpaAhw0x9q9t69dQuSDxB2gdC6elgQwjO9JdNVIWal/1vBm08bH y21AqNdQh3akW8H0K+/Ff5LZVXHAyN4= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-79289fefdbeso158362039f.3 for ; Wed, 06 Sep 2023 06:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694008542; x=1694613342; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gbyDWxJfqMgWVcylxBXfX+Os4k5+YTlBDL7fHB3febM=; b=ru8Iy1QiF5A6LotCmSbQ1eTCYcVBoGib6lu/UICcRcs8kPnpyJ8IJy9l7JfdBm4TrX zjkbGHV89MwRPGvmOLru8a9pcziC4T1nGWMEhfEt6dgApbuqRFoq3hEGUnaUDnSy8PGP 4XrH7o1jZO5jDGp3zng/e68YNHwJZU1fdPqfkKVtSC/YPHZxJhwwftoI9NX0V9lKKLmX 93KgmYe6Ri9JJJpxvH1dYYylQN3YIK+zCh5PZvxpqZ1hnpai0fJj3YqzzFlg6lIY4msP ebg6HVogagdaxfc4RZj7FXf1m6+oroUdJfsZhJ6072qV3xjYzs0J4hYKWsbDwpDZeZNu f4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694008542; x=1694613342; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gbyDWxJfqMgWVcylxBXfX+Os4k5+YTlBDL7fHB3febM=; b=JGBgVOb3mobwcy4rKDjMfLG15KDLnntZCFUzrAKbTrWiJXwM0fdaqdggGturJlCQIb zOwjwZlVx7XzQF1i5h5Co8JBareyn3LDFQr0SCyCEHMQ3LmZP1Gg+NnZpcoKBL+AzEOm o0zyyX7PKK8mM1nNsATZunYOUi/MwFCrenLu3kXIa1Rv1XAM2wxpKUNOlvV+V9nHvR2H oHk9Z+J3jkD9trym14AJCR97LhLXhZS5PTXYpxqsJ/B6SrazhT6U+pwR6kPl8NJk7gTa KvhbXwqezK5rwbfLQJs/0U2ziWfcOK35E80QGoQ2atrjbSEuSZJR0eg87j1bM7MMevVi hVfw== X-Gm-Message-State: AOJu0YxYvFbAJWXX7+xfiITcJk+0EjCUsRBRw/ygJXhLvfBO240nQ1wW uEr6mP2DliineGhzA2YOcFpN/8Njhavj17pCYcE= X-Google-Smtp-Source: AGHT+IEZ0jkfj5Uf6FsapgkFNw1rXiq5p1/+3jIz1mfjeACGaSCI2qPmHp4YWLahdQbag1gsTEFoO5T7XElRYHgHrNc= X-Received: by 2002:a6b:d607:0:b0:794:d833:4a8a with SMTP id w7-20020a6bd607000000b00794d8334a8amr17885350ioa.0.1694008542041; Wed, 06 Sep 2023 06:55:42 -0700 (PDT) MIME-Version: 1.0 References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> In-Reply-To: From: "Lad, Prabhakar" Date: Wed, 6 Sep 2023 14:54:41 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() To: Alexandre Ghiti Cc: Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E803EC0021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8rcpz69i8d9hwa6x4s4y8kqqzf6uptoo X-HE-Tag: 1694008542-594969 X-HE-Meta: U2FsdGVkX1/0WOe5CNFMN8ygI8B7A6T+Q6TkdHsBgjiiB7JZHJR+xkmAZza00dPZEbAdSsNw6f8UUHFelxXPh5GemaC5rG85nhMxMGZd+DyxiuAYDy7Os3grTXp43uJQrMXc75amLht94aYZgvgvlovq88L72P2ct4ypnrJGuR0ucrnm49QuiPfkNGPVzj/fREWgUOa0ovYpxZ3oYDAGwQFpv1EKiYdWAZlKgVKrU4Z0yknUf0ssUi9YtdnMwIcw1jj0QTNVFHfiqgau8xoBpz849fR/0yxoPjTa5olYKxrFXqa6bD98wjSIoAy5e5Auup/MKmamDdR/Qdtga/lyJlrKc9v2fDkxR13cgqHzCsmY8DYsx44wO9D7U1e7dEmdK7Jj/UUZkkWJo24NL0rm3QUCGn43RYCH7ed/CFSjNhh+fLXZUgQJoWQVUg/Ca78gtELTltyNtEkl+YriMM1Z3cZFxjuLqd9PlWVJ3JnhlJKjfCDGfyMuSRNJVSpAHFvfIKi07JNMnadiYCCUVVQDMg5BRa0U5fj3D55zkRlMzkFT/TB7MPvWkTSo3G19nzAsS4m7/1WobiZ50iAETHjhvqESJHMgEhKoyFnmw8jJRddYXc+/b4iOkxu85CyGw6xRZOnWZ+J1Aa4AhOBhIuixOUhocNZaPr5sT6C4dG1U7PLgm/L8wVTqimCOSymSuUNU0N0WJNl/CzM4yCZFiJUq2Bmci7Ad2d9VNRGnYtgknWzGrcwuYYtMI8h/V8JqEzZnin6Jnv4ESTE1griao+0LE9HY2IFtF/dYIp0vqJAHI69dpgrkaPYni9PFC0El0g0+ZVx7bHytvxdcOWbTPkLoxc9oESrfs10m5hRwnXY70qYzBZ1MRcOyLiF6onqXrRb7JYZUMwM44LYwvu66cXVmbIcAiwoEyeUnGt3D7lDzKXeRUCuwR6Md6Fd2S96lFNENp9NQ9GXgzDy3HIsF6my XzbXEEDw HbWGc7sOz+rkbPGzpgg5haFOK4YcDAxuKbd+0CLj0jn6Hut45XlVI/ntcZfurKW1UIF2N1CQU/Ni9bhqzza4dGAHMQBo9oL1aymgcFn6hAjHAILhTAIGrZBwjDGBUnU7G4/TJPKQCWJLpuBg/0UOYQdJPEH520xENMTpHyFcWzHJscMMXpcKGh6o3hoRyHbywFsVE0smRix8SNvGUGwk5BxJ6Fs73vZiBvxijvwY0KqVc5xx9PKZrhnPHF3T665+bzOU9/NvpGdpiqkbc821JlsJoFmIHK6BpaXLlIYQngyBzHc7GKbY+RiCR26usA/6OQz/9FsFvyzDl/Dd2Jy1MDd5CXfxYpzE61b+Bu6q2Uip2UXix4lpEN7FDj3jF25nzFRCbxp1tn43a7uzAKP6Bfa4uKV54noSdUzFJ4Xx1l51mjLhwNCVUG+sMf6111bpuaPI1/O6SRuLavO32Hcgx3h5Ku3sZ9yDul6F+zO52ruYpQVu5yPa9M+MnVlnrrRVoGbC1yiBbutRSySivUnZRgwTdn+UWy/FWTpmZ/YATTgp2fgT0jqTpPMjlVZYdF9YDMqo3o57bWfcTD0SCx49fNzNu0eQ2RJlDb1FXGGPUduGQpIJanb7IZHL1t8tF3fzun9KhXe56htIeALPBpsRsTxjlwReApFKWISSmDPJO9KhkO2U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Alexandre, On Wed, Sep 6, 2023 at 1:43=E2=80=AFPM Alexandre Ghiti wrote: > > On Wed, Sep 6, 2023 at 2:24=E2=80=AFPM Lad, Prabhakar > wrote: > > > > Hi Alexandre, > > > > On Wed, Sep 6, 2023 at 1:18=E2=80=AFPM Alexandre Ghiti wrote: > > > > > > On Wed, Sep 6, 2023 at 2:09=E2=80=AFPM Lad, Prabhakar > > > wrote: > > > > > > > > Hi Alexandre, > > > > > > > > On Wed, Sep 6, 2023 at 1:01=E2=80=AFPM Alexandre Ghiti wrote: > > > > > > > > > > Hi Prabhakar, > > > > > > > > > > On Wed, Sep 6, 2023 at 1:49=E2=80=AFPM Lad, Prabhakar > > > > > wrote: > > > > > > > > > > > > Hi Alexandre, > > > > > > > > > > > > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > > > > > > > > > This function used to simply flush the whole tlb of all harts= , be more > > > > > > > subtile and try to only flush the range. > > > > > > > > > > > > > > The problem is that we can only use PAGE_SIZE as stride since= we don't know > > > > > > > the size of the underlying mapping and then this function wil= l be improved > > > > > > > only if the size of the region to flush is < threshold * PAGE= _SIZE. > > > > > > > > > > > > > > Signed-off-by: Alexandre Ghiti > > > > > > > Reviewed-by: Andrew Jones > > > > > > > --- > > > > > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- > > > > > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++= ++-------- > > > > > > > 2 files changed, 31 insertions(+), 14 deletions(-) > > > > > > > > > > > > > After applying this patch, I am seeing module load issues on RZ= /Five > > > > > > (complete log [0]). I am testing defconfig + [1] (rz/five relat= ed > > > > > > configs). > > > > > > > > > > > > Any pointers on what could be an issue here? > > > > > > > > > > Can you give me the exact version of the kernel you use? The trap > > > > > addresses are vmalloc addresses, and a fix for those landed very = late > > > > > in the release cycle. > > > > > > > > > I am using next-20230906, Ive pushed a branch [1] for you to have a= look. > > > > > > > > [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug > > > > > > Great, thanks, I had to get rid of this possibility :) > > > > > > As-is, I have no idea, can you try to "bisect" the problem? I mean > > > which patch in the series leads to those traps? > > > > > Oops sorry for not mentioning earlier, this is the offending patch > > which leads to the issues seen on rz/five. > > Ok, so at least I found the following problem, but I don't see how > that could fix your issue: can you give a try anyway? I keep looking > into this, thanks > > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index df2a0838c3a1..b5692bc6c76a 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -239,7 +239,7 @@ void flush_tlb_range(struct vm_area_struct *vma, > unsigned long start, > > void flush_tlb_kernel_range(unsigned long start, unsigned long end) > { > - __flush_tlb_range(NULL, start, end, PAGE_SIZE); > + __flush_tlb_range(NULL, start, end - start, PAGE_SIZE); > } > I am able to reproduce the issue with the above change too. Cheers, Prabhakar