From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA629C83F01 for ; Thu, 31 Aug 2023 11:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED4188E0015; Thu, 31 Aug 2023 07:23:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E83988D0001; Thu, 31 Aug 2023 07:23:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73378E0015; Thu, 31 Aug 2023 07:23:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA3D78D0001 for ; Thu, 31 Aug 2023 07:23:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8654A1C96D4 for ; Thu, 31 Aug 2023 11:23:43 +0000 (UTC) X-FDA: 81184164726.21.8B5C97A Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf30.hostedemail.com (Postfix) with ESMTP id C481980014 for ; Thu, 31 Aug 2023 11:23:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="UFqZ/npV"; spf=pass (imf30.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693481021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X/4EQg5ev/+deumnX6OUgiklslgIWa0lVWUE22HEhVI=; b=6aZpRFZHFU7Czj1588l//M6t0F5LVV5Lvowtc+pbkqTsLB609Pz5BGh7Ew/AxhzLiHq0PJ ilzghp7pWyhzLNiy2vTvK30LH3rBQkXHmjE2HvcR2CzwKYN/WBTix7gW1Vf3R8r0i9tZkU HxLIa5UG8rwAJ+jotIkiak3PeasIOUY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693481021; a=rsa-sha256; cv=none; b=Sqxocf27iunsfHjHLbnnNE9aPtPMAdz0ZWFE0OSC+fS4MQdXOMh5jYhFGuPG3BVQaWdVPe juD8pyQ/N935XTSTd52VbEv16mTlQZeve/ilL6reR338AlmkCkMa/s7R3wLmX1pq6UnbyH 9GOJpdlU84Q31oExR7RHNj7xoSosfn8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="UFqZ/npV"; spf=pass (imf30.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7927f24140eso27918039f.2 for ; Thu, 31 Aug 2023 04:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693481021; x=1694085821; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X/4EQg5ev/+deumnX6OUgiklslgIWa0lVWUE22HEhVI=; b=UFqZ/npVQnR8MkZw5/YK2Nx9cMGQ8An+mH4HwX5q+6iAI8bgR+gR/3IjXpidu8KNx+ xXedQWVWzUVEPGGihV7fpZDnEKe+qqtcWd1kzdGK8gWe0xjpzLx4A1y5Jb6Ebx6KT1mJ BZUL6DYCJhshAeLWDO/CjGbT4ZigCqTsyLPc1ZgBTU7haqvygo7yzIN+6MprDt3OOMh+ tkIq4lzRxyNoNz4Gwn/6dygUV008/IiZYXPPhArc8Fr/lOv52ARttk5V0+UGX4nxgbkE 52sm+4m0YUnbAoNhURu89gksKw96pK6boZn5m4BDFff/smULfnfcrMmasNlei5Q46jys 6Gqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693481021; x=1694085821; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/4EQg5ev/+deumnX6OUgiklslgIWa0lVWUE22HEhVI=; b=WcojsTqF+/h+B6Ffl9YXBFmHZ8ggkyTPqhL/kpNZZPvKoQn4/I3OWkuktabIar4caL IEWbTPFEnuxzmUKs3RWpWGdWEk1G2bbRefkdHvpv/DH9IpjjhWcdrUhZLpMvTtvcCDA2 vtlV7IZx4G3jIvwktLdNLWT9cMghpxgxRpwalP9SL0Vc7t8obpXwndfmgTEoarSLD9J7 uqljCgyJAtX3rYz5bdWsy/547JTjJ5mVju+U5qCtAWTzZy1X11IMkR+CFRfbJsUPIELD 5FFihco5okQ1We5KZy/QQAELpoICuXP0WoDi7msOZmbXmwP7GUFo2Q7s4CYEIzKPezAq wxvQ== X-Gm-Message-State: AOJu0YwtxP/vBbctIFi8Xw40pXIOTUdyWCs7hFfbrsY/lTBF73Ov1w1t InsATGfwX1NzsbxEwsC8HHN6DIXM2zHwfqme6Qc= X-Google-Smtp-Source: AGHT+IE7kYVayzAdUAGhBuecJxFu3vc4i9pwityv8OGY+ZE/76nl5azA2K6fuvqOt/HcNuVjbfCF5JyFZuuFoBpr+v8= X-Received: by 2002:a05:6602:474a:b0:795:2274:1f3f with SMTP id dy10-20020a056602474a00b0079522741f3fmr5120974iob.3.1693481020894; Thu, 31 Aug 2023 04:23:40 -0700 (PDT) MIME-Version: 1.0 References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> In-Reply-To: <20230831-congested-monument-44ddb496204d@wendy> From: "Lad, Prabhakar" Date: Thu, 31 Aug 2023 12:22:50 +0100 Message-ID: Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known To: Conor Dooley Cc: Geert Uytterhoeven , kernel test robot , Lad Prabhakar , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C481980014 X-Rspam-User: X-Stat-Signature: bwmm3nkufsqpmtqgbdr4nm6ot6tpiosj X-Rspamd-Server: rspam03 X-HE-Tag: 1693481021-666088 X-HE-Meta: U2FsdGVkX1+baa9ojlJvWCMf2KPbItgBIEajV2gf0/AsuTP9HMMx+hEiksd90snyhqlr57SVji9Tec4xZtxQQHonhyWxqFAPSnjkaPdZcDZGI8V+4ff6K4pjWG46to5aj1Y28IYuq7ZZbM0tkT/7IvtjcHKNWWN5jwnWxRVabNR+5Y3EAEAThoj4hph8qdZt06mLJI0a7vZOEEOjNlEO3Ps4p2NhDeSSm0SNt3S2Fr/YGI0jeKJpq5yJ2BmD9fYqJ8DVgNTCjW9XeX6kKcLmeEdjEjjYwZ8JuKYg4Tn120T23N1mFeIuXjOu3UyvtprpFM1P39ZjqatQva6zb2lht0PqZJpDut8nQqMzIaxEo47E2lPBUXGI5GmgL5KIG8KslLgHDKEXy51UpLsJqXgCPyxLrqh1uwH9gKMaJR4KuKTzy4ntRmxvvl5pl46PENHzQTdiYwKoeqCeWsHgqqHViw1PenY+JShX0o1kJGiQMVvFjdpc0pzRoiKy+UdwOGbjcA368OYE50kA/2GUhOrCVzG8/UB18d5mhac8AqW7BQz0IwMfdbsYNhVNtCqTnt3vP7mev7+WXyEwOAmXs6MDf3dSYEq0GhQea4Ho2UlfkJZG/CLpm6BuuRVWFx69WzTB3OQktUF3B2sL+0O+NFrI+JSOBl928yTdINuMKeEyuddk5AD9h113HFr047ZiJrylgciypelyIYczygcmf3FCvncnNHqb+alrxiDvlBL+t8H6bW2AGp9VyD8larqW8K6kOaHdhXY4oIEy/VDg70TVWYI57pP273A+ob7d747DZRleiNbQsThQRAbZ35yeq8Ja8Yi69e0QqAzV7yxvrT5OhUfxpHHJv73m1oUhtOtPFWovH8YxKK39u1wjmkNMv6hhmiu+204oknbnLryDvS70Y8uRvVpVnow0iFWjhq9lmskY8r9cVEZaIh7Hn9akiKfjyiwBHTeicy1FKDar7Nd wMshPaOD oDPvGRo2oO0qTX0+HcYyZoS3/Lhlb9XzKh1soLiItOIDSbNq/3p2nCWA73Pygqg1wIqQPXjqq8PejTeG7aoo0ebpQR1HCWQ0ZfZSLxQA0vqQPCcRiJ0h50V5jB48WokTqLqYBbZTvLcZnc+iOKjVzlIMEf+4HvT0d30tkSg99+YcbH2EWAG3d5FIWu3ovDkxPRHx+kVBvJsKn7bm1OjST+uCe6iCimPiSfAanMOdZMOJi1Vtm4yfJOqDvPefsbMeKFYzlqH83pt6popcnAmhhPVHX6V3g53E2cWk24VyuIn2428+XcaVyu380zSwvnWRPqZdxVmXmMPOVI/Avuxs+XJ/gMgx3DSkxNWCbXQ6v9vBYv/dqcjmvKOukwK+bemGyEpxBPW2ePzV/5sv2T5TZL7sglMhKV/ljQJeFujOhcgu8reNbx/3kBGwjfrmztfgxlK//VKi+u0TG0d6sU2ByQxFXsmtLc8yonv4HPE22ha9Bp9x64m6Q+an0HIfQk33s+u0Et3bimbh278wiaABO+Gy1WAxCLo/S9BI+t09FN5WasOrlh5UlN6MICeTvs6I8szjFhBFh2poPvHVrhwPcWX8WizioPXOG7AvMfd+ougNbHxUzRlNWQlG6AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Conor, On Thu, Aug 31, 2023 at 10:44=E2=80=AFAM Conor Dooley wrote: > > On Thu, Aug 31, 2023 at 04:52:00PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: a47fc304d2b678db1a5d760a7d644dac9b067752 > > commit: f2863f30d1b05e5ecf61c063609cb974954d47f8 [13230/13643] riscv: e= rrata: Add Andes alternative ports > > config: riscv-randconfig-001-20230831 (https://download.01.org/0day-ci/= archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/config) > > compiler: riscv64-linux-gcc (GCC) 13.2.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20230831/202308311610.ec6bm2G8-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-l= kp@intel.com/ > > > > All error/warnings (new ones prefixed by >>): > > > > arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workar= ound': > > >> arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret'= isn't known > > 29 | struct sbiret ret; > > | ^~~ > > >> arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration = of function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] > > 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI= _EXT_IOCP_SW_WORKAROUND, > > | ^~~~~~~~~ > > >> arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 're= t' [-Wunused-variable] > > 29 | struct sbiret ret; > > | ^~~ > > cc1: some warnings being treated as errors > > > > > > vim +29 arch/riscv/errata/andes/errata.c > > > > 26 > > 27 static long ax45mp_iocp_sw_workaround(void) > > 28 { > > > 29 struct sbiret ret; > > 30 > > 31 /* > > 32 * ANDES_SBI_EXT_IOCP_SW_WORKAROUND SBI EXT check= s if the IOCP is missing and > > 33 * cache is controllable only then CMO will be ap= plied to the platform. > > 34 */ > > > 35 ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_= SBI_EXT_IOCP_SW_WORKAROUND, > > 36 0, 0, 0, 0, 0, 0); > > 37 > > 38 return ret.error ? 0 : ret.value; > > 39 } > > 40 > > Looks like the config doesn't enable SBI, so ERRATA_ANDES_CMO will need > to grow a dependency on RISCV_SBI. I think adding dependency for RISCV_SBI on ERRATA_ANDES would be a good ide= a. While at it I am seeing below warnings with this randconfig: WARNING: unmet direct dependencies detected for ERRATA_ANDES_CMO Depends on [n]: ERRATA_ANDES [=3Dy] && MMU [=3Dn] && ARCH_R9A07G043 [=3Dy= ] Selected by [y]: - ARCH_R9A07G043 [=3Dy] && SOC_RENESAS [=3Dy] && RISCV [=3Dy] WARNING: unmet direct dependencies detected for AX45MP_L2_CACHE Depends on [n]: RISCV_DMA_NONCOHERENT [=3Dn] Selected by [y]: - ARCH_R9A07G043 [=3Dy] && SOC_RENESAS [=3Dy] && RISCV [=3Dy] configuration written to .config *** End of the configuration. *** Execute 'make' to start the build or try 'make help'. For which I will send the below fix: --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -334,10 +334,10 @@ if RISCV config ARCH_R9A07G043 bool "RISC-V Platform support for RZ/Five" select ARCH_RZG2L - select AX45MP_L2_CACHE + imply AX45MP_L2_CACHE select DMA_GLOBAL_POOL - select ERRATA_ANDES - select ERRATA_ANDES_CMO + imply ERRATA_ANDES + imply ERRATA_ANDES_CMO help This enables support for the Renesas RZ/Five SoC. Cheers, Prabhakar