From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CDDC83F10 for ; Thu, 31 Aug 2023 15:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0688D0010; Thu, 31 Aug 2023 11:00:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 890368D0001; Thu, 31 Aug 2023 11:00:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 757D58D0010; Thu, 31 Aug 2023 11:00:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 63E6B8D0001 for ; Thu, 31 Aug 2023 11:00:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 23AED140270 for ; Thu, 31 Aug 2023 15:00:45 +0000 (UTC) X-FDA: 81184711650.14.8DF07B2 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf09.hostedemail.com (Postfix) with ESMTP id 949BA140074 for ; Thu, 31 Aug 2023 15:00:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XeX6Z9tS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693494029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=maWUEzzcpZvbMut13ZGvpoiNO4A5EezHq+i4LSTx+aw=; b=hOIWciFRKjL+ja/TMIeBGVYhhq9mPF4NyTkySXeNwpciiZZJSFNMlTeCTHRK2s4pAWuBvS Udu/qMBIRCxHQF5n3FutSIHhdJHrOuW/c4vEJ8bgAoo9Ri85cZCdom+gNPuUDevUCP3G/j HO1/Xk1fjPi6TwGuE5PhsT2cPehWeXI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XeX6Z9tS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693494029; a=rsa-sha256; cv=none; b=8rMO4Kdnepho1xa1+YAec6dWIfffhebHJYq3Tf9pNxh2vUZxud+eQBM8BeWUMc0x3YXbQA 6WD9A2P5Sx4La8pkf3S0XSWQILbL1npuG0Rv+n9aauOjKSWvwBYBeIDvxezmWM1BRUQ195 OE3/LKsbUGBFXpxxmNSM3Jk5T7RiGiE= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7927f241772so33913139f.1 for ; Thu, 31 Aug 2023 08:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693494028; x=1694098828; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=maWUEzzcpZvbMut13ZGvpoiNO4A5EezHq+i4LSTx+aw=; b=XeX6Z9tSBHzUUdCgo8Yp9Ka6Ix//AV39Ik+M39H5aLGXJgEqg+52mYDlCCqHsUfAbG PCZF1chMI0Klnqh7AcyDGZcS0Yulz9rGIY8LLr66Omi+cFbyJH5gi0XGsU9huhrGn2fY M2WaJQZfuZ2fQPfQFYAW73YUew/YFAFaOC9jbxOlfWH1hLHvI6bOoLAMiFeUptz01sMQ ZsYRv7cOi2Pz3F9OQdrz8C6B+8uBPgN7D4ueATUC7rZSPhOwaIJgEksJBFMP+M4Ae4u3 5rHomU3LWLahq3SHRcTSWH0PUvec4hOQzPhNOLC9cYXX4I80AYRW3IybdKDRJeFqFNLl GOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693494028; x=1694098828; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=maWUEzzcpZvbMut13ZGvpoiNO4A5EezHq+i4LSTx+aw=; b=ORF4c4BvWlIKPGm+AOvGvpLoOWj4KbY72a/y5bJwufKLSQjyy2Hw4EupDoVUnMCfMg KLqEvjf5qIAnjQJ05cAY2b/wv9evnfD1Em7SdKi5y9Idl0bAHriaNfKnk7/Ar/8olE4t ndOfchZ9Gg1+hkGSRaWDmwFX6nhyhUtp4+0WkOReRp/pwK9Pka4ZVNsuBgkg5WsIrLb/ zZnPLOfzDIvaz5V2l1lfzi8HojzARWaW30NQxY24wKlFQwimdWUMBbTJF6BDXx60o21L 6ZDotU7uJ6hmVSUZ5KhvmDH/qEMiOi6gdi2e8dpjr4V3bBPJOELcQpzrVUOw9/0GZT9b qFfA== X-Gm-Message-State: AOJu0YzwpQxYkdYMWnvF6Iw1eMUGIFlTM8wyIc3OWjRVAPNSTGs2Nc/X fKDQpj5D9mPe/PXy/UCHIxd7l6HTH7n4vHzgY/E= X-Google-Smtp-Source: AGHT+IE1hpLVe8DANjvKF5ZIjP2uvUmv41a6THgq2EWWovkdh94ymOSF0VaLPqZX54sKVZhmZgC955Wm4gQkSj2A8QM= X-Received: by 2002:a5e:980a:0:b0:792:82f8:6f90 with SMTP id s10-20020a5e980a000000b0079282f86f90mr6079936ioj.16.1693494028601; Thu, 31 Aug 2023 08:00:28 -0700 (PDT) MIME-Version: 1.0 References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> <20230831-imperial-surviving-afdf6d275388@wendy> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 31 Aug 2023 15:59:37 +0100 Message-ID: Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known To: Geert Uytterhoeven Cc: Conor Dooley , kernel test robot , Lad Prabhakar , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 949BA140074 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: p4ffq6s6qq55oneiyhk3jbmfo5akmosi X-HE-Tag: 1693494029-790422 X-HE-Meta: U2FsdGVkX1/oDOkLJbvb4NHmU78qWBI3/bd8SfR8NPrVEPMIEn/Ag3gLP4vh4WFha6Y4n1W2l7szdGUuyHOEit21IMw6ukGuk9kA6gaylYfCR1Rmh8jn2Yj+LlX+nygVmzzrkndg+jh7zOGF3BJPxwuZZxuZXwmFG3GgTkaVVlaPR6pOEGgk2B7F2f2dZ5CC9a/WC711xNkmkzkNxVe1+hx/KYC7ru7N7B1vMk7k2vj/R0Wd++eX0K7KXtazx/D6nwuZBdnfU9DY3CnOkuDNPDtN5rzxvVcuo1axSmG5zJxaNyt/tYOkkhRvBrT7meEFS90+/X7K0O+8QKEmv/Det07zu3BLdnT0/qHroXmm05S6f3a1Jsur1v5EhnVQU9Dxy/DsEKQd9+/u+nT9OGlocada0w8JwvE6p0ma7nhd71FffUlnhnHab3SxO5SfOZBZ4oogWVjBlQILwWWnjlXK7iJZeyefNyQJ1VBhEFXho5caUcdO++NRLK3ZriKGlstbABDYLYhg5+I4dCiTc2V9Ar5PjVohaHR696X/DiSCJZwXn8dmCEZzKz2/7OU/Gr6eWrI7mb28cr9ya7WGWucuPmhI9heDW0q9dzt1Cu5+6PvpMwqqI+kKqoHBhPQzm91kOzynF9Gsq9d4p9xZA3ZjlXO+fZXC0s/C5C4bTaVubO1/0FEGGBlOAByBjr5ENOd4R46DepWBjC6+NwTE4Sbww+ILO1g0cuvCST18ENKy2B0xbO/Gp1207SN31tAkejG9ERELzJLO3AZfyV0pl4xqNQihFTisrY54loSgaN6rasX5JXjHg9kAnvN2x8uTUJiKdGgXqAvj1qCxiPrt1MXSWH4V0bRKvKq3LJybPJ3XQarzxhpDhooNwb39cKLpMG3t9DTzj2wSbG+J21Tz7rWbE2Ijt78IjKm1WesYDoP/MZxAjNovmo/PAqH6aferPWZwnMBG+yMCN/gFy9FYaG8 d3j7AdAj I9npQjNXHKT57AydcntlCqx7WvAqRciJ2Qq44LgckYoXe1l0QcpRUjHahjPTWeYD/BTRGXvIb1xLtV2v+oeLQf0fwpvTutfVkn+wYot1ne6jBrmkebemw8z4bszGpg6PnNTRWmTeH6aqnTtDXyv0HZ7M5f/fEEEsQZSv9h4c8Ju9sCLsm+0AwY5Pr6Ld68liNnSQtImTWBfAoOsRY+G+GKnLR8Y94Fg0YT7xa7jRr+Qq8sMkRuSSjHFmn9cwQo6hTdY6A9PQj0+gejH6EMZUzgS3S4CX7ldI16VAluU/WJUFI60Fs/qN9i+g+OF9nzqyqwqHg0zblNP8AQZ2+NF3c/Lssbgl7K6/zELtXx0paYKHjc0oo3WEmv/DkTUXWuORi3RKqQ7uSuBAV5qKAPI6tNUxbVQwxXBWNcaX6V565xk0oHpX+8NgqTFUN3iDqz6XuDhQb8qu5WFOyLXtAdXSz/1J2qufRO66vmTgLull6PiFZFW1+2Ec7nxo27Fo2dqhTQtjxe2XzhX0BcaBd8jjEjkNi6IxHEAoTeBAL3ciq7xH/kbd1Vu4LE6rKDZKQJ3T4FcN9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Geert, On Thu, Aug 31, 2023 at 2:24=E2=80=AFPM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Thu, Aug 31, 2023 at 3:02=E2=80=AFPM Lad, Prabhakar > wrote: > > On Thu, Aug 31, 2023 at 1:01=E2=80=AFPM Geert Uytterhoeven wrote: > > > On Thu, Aug 31, 2023 at 1:54=E2=80=AFPM Lad, Prabhakar > > > wrote: > > > > On Thu, Aug 31, 2023 at 12:34=E2=80=AFPM Conor Dooley > > > > wrote: > > > > > On Thu, Aug 31, 2023 at 12:22:50PM +0100, Lad, Prabhakar wrote: > > > > > > On Thu, Aug 31, 2023 at 10:44=E2=80=AFAM Conor Dooley > > > > > > wrote: > > Currently ARCH_R9A07G043 selects DMA_GLOBAL_POOL and we have > > RISCV_DMA_NONCOHERENT selecting DMA_DIRECT_REMAP which causes below > > build issue when MMU is disabled: > > > > kernel/dma/pool.c: In function 'atomic_pool_expand': > > kernel/dma/pool.c:105:44: error: implicit declaration of function > > 'pgprot_dmacoherent' [-Werror=3Dimplicit-function-declaration] > > 105 | > > pgprot_dmacoherent(PAGE_KERNEL), > > | ^~~~~~~~~~~~~~~~~~ > > kernel/dma/pool.c:105:44: error: incompatible type for argument 3 of > > 'dma_common_contiguous_remap' > > 105 | > > pgprot_dmacoherent(PAGE_KERNEL), > > | > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > | | > > | int > > In file included from kernel/dma/pool.c:8: > > Hmm, kernel/dma/mapping.c has its use of pgprot_dmacoherent() inside > an #ifdef CONFIG_MMU block. > kernel/dma/pool.c has it inside an #ifdef CONFIG_DMA_DIRECT_REMAP block. > > I guess that select should get a dependency on MMU: > > config RISCV_DMA_NONCOHERENT > select DMA_DIRECT_REMAP if MMU > > For comparison, m68k does take that into account: > > select DMA_DIRECT_REMAP if HAS_DMA && MMU && !COLDFIRE > Thanks for the pointer. With this changes we dont get an unmet dependencies warning. arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaround': arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't = known 29 | struct sbiret ret; | ^~~ arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI_EXT_IOCP_SW_WORKAROUND, | ^~~~~~~~~ arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' [-Wunused-variable] 29 | struct sbiret ret; | ^~~ arch/riscv/errata/andes/errata.c:39:1: error: control reaches end of non-void function [-Werror=3Dreturn-type] 39 | } | ^ cc1: some warnings being treated as errors To fix the above build issue reported by the bot, adding a dependency for RISCV_SBI in ERRATA_ANDES won't help as ARCH_R9A07G043 is explicitly selecting it. To avoid imply should explicitly select based on dependency something like below? diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata index 92c779764b27..566bcefeab50 100644 --- a/arch/riscv/Kconfig.errata +++ b/arch/riscv/Kconfig.errata @@ -2,7 +2,7 @@ menu "CPU errata selection" config ERRATA_ANDES bool "Andes AX45MP errata" - depends on RISCV_ALTERNATIVE + depends on RISCV_ALTERNATIVE && RISCV_SBI help All Andes errata Kconfig depend on this Kconfig. Disabling this Kconfig will disable all Andes errata. Please say "Y" @@ -12,7 +12,7 @@ config ERRATA_ANDES config ERRATA_ANDES_CMO bool "Apply Andes cache management errata" - depends on ERRATA_ANDES && MMU && ARCH_R9A07G043 + depends on ERRATA_ANDES && ARCH_R9A07G043 select RISCV_DMA_NONCOHERENT default y help diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index 67604f24973e..543300fe9862 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -334,10 +334,10 @@ if RISCV config ARCH_R9A07G043 bool "RISC-V Platform support for RZ/Five" select ARCH_RZG2L - select AX45MP_L2_CACHE + select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT select DMA_GLOBAL_POOL - select ERRATA_ANDES - select ERRATA_ANDES_CMO + select ERRATA_ANDES if RISCV_SBI + select ERRATA_ANDES_CMO if ERRATA_ANDES help This enables support for the Renesas RZ/Five SoC. Or am I missing a simpler way to fix this. Cheers, Prabhakar