From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA970CA0FE6 for ; Fri, 1 Sep 2023 08:35:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45B54900004; Fri, 1 Sep 2023 04:35:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40B858D0002; Fri, 1 Sep 2023 04:35:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FB1C900004; Fri, 1 Sep 2023 04:35:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2167F8D0002 for ; Fri, 1 Sep 2023 04:35:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DB27F14019D for ; Fri, 1 Sep 2023 08:35:49 +0000 (UTC) X-FDA: 81187370418.26.D38DEED Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 0F27CC001A for ; Fri, 1 Sep 2023 08:35:47 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OBRzbmXF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693557348; a=rsa-sha256; cv=none; b=WZFynhJHlnjn63XFFV3W0z34CMFCzDMrXmVK34/Qq50suE7tRJS6e2ETjVK88Y8U/79+vt bcKjOY+Iwi/3Egjc2ps9utrBpeZsJ9WtrY8216W1uqwpCp6IocZz6valJDvenJu9Z3Trce gMOar0/6tUG0Rl3kc0EAO+dCJVqQCHI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=OBRzbmXF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693557348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hBwkl8r56F9MsUo4ywqpeDj588eZZ4KwRWAzOpHdTZc=; b=dULYgEGx8qPEf6t0UYZE8rtzZ7sUlq6WHLaVWjsgkMYKZcMWJ3yaGx6qA8D7Y9xrWOikBe qCnLuNRVkPBqcWUfeqVQ6cfRaciXdLijiWf2eYjJg6ppG7h0bnCKqy+nbKEzvBXAmFMGc1 mauvHiYBKN3LoMF0RTLVhkG4CjJUIEg= Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-79329a8f78bso62451239f.3 for ; Fri, 01 Sep 2023 01:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693557347; x=1694162147; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hBwkl8r56F9MsUo4ywqpeDj588eZZ4KwRWAzOpHdTZc=; b=OBRzbmXFwb1cGaGNXjmZDWUeTYHY+Ob07CTMwYnN++FN9hfhn2zZqYWjHLEPpZYJae xnBmqJLCBR/RdFFrs7DDySZwRCQ3vyuo08vDHIu+x1E/24x731ZJe+g9yEWr0rV1mDbe zkPlvNupAR2jWnu8+h2mGWJGWTPem90h7Q0MQSALuirPP0vpo6J0ENcfLVHplvdGnRlH rcIibPCQ7Ifr0Iy5JqpmvaWMkdSv69ya2+oNjs4dtBi79cqnurM7Fi1v2PH8tj92cTRH QqSD2ksLLji/hUqsGSpX7JH2IE90YQuHZt+gWIMx719S9J1pcDO5eqh3EizsTnVBUzeW ikqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693557347; x=1694162147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hBwkl8r56F9MsUo4ywqpeDj588eZZ4KwRWAzOpHdTZc=; b=cstG3Tt9pq9K1wIIH1MBidHtrbzbIAaX9w2Xa0QHf6UognSq/YslpkagPoLtYxbw30 e6NIjyDBUPXkfQ4iyJyOB+aEu3BqD3z/J7OxpK6XYot/aAFCFEf5qFeBkCJ+iQY7Mhzr W9Cezpl6xLthLaS1dqdHIuB6c9C9L7IF0jLwL4CsSQAL80L9RqLtxcnFX6NLiKhnJRlU Fe7oh0ypvrowvZO+dNnrEZQzvecaODg8+R0/DZAsxRWgKQPmme1slBgD1hrAVsVSM7HK mbzrxtdQz4n+wYo06lnZ+Fu6g4cbjYyinxhpzCXn/l3tmrzP9czcHVM0E6TUGnmTIYiR NRxw== X-Gm-Message-State: AOJu0YykncxB3i/fgHSVd3p4Bt4mECY67xGahhVdGh9S4phXPrclJN6U sAIBSp+faQxCTQEG7sfQNT8BLNR3U49bc04d+og= X-Google-Smtp-Source: AGHT+IGsIyPdvF6MA8CXUeTIapdA5U+Ur0uIO4xefYecaaBMCoe3Iu35bQpJWRy+7CHZNmIXTEdS6HQHSIcdW/UNRb8= X-Received: by 2002:a5e:8b01:0:b0:792:82f8:7402 with SMTP id g1-20020a5e8b01000000b0079282f87402mr1914582iok.16.1693557347139; Fri, 01 Sep 2023 01:35:47 -0700 (PDT) MIME-Version: 1.0 References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> <20230831-imperial-surviving-afdf6d275388@wendy> <20230831-nimble-rust-00821dccffdf@spud> In-Reply-To: <20230831-nimble-rust-00821dccffdf@spud> From: "Lad, Prabhakar" Date: Fri, 1 Sep 2023 09:34:55 +0100 Message-ID: Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known To: Conor Dooley Cc: Geert Uytterhoeven , Conor Dooley , kernel test robot , Lad Prabhakar , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0F27CC001A X-Stat-Signature: 1czid7hsq8rziphxzyujyixuaxet1jee X-HE-Tag: 1693557347-683247 X-HE-Meta: U2FsdGVkX1/2QckM+8AOLjOBIZcrJb7wTKd6SXxQdh8VARGuoM5kJ3jdgXxFZ7Vcb5Sx3zI09BwYOHUmFg0AAU9068YscLmQRjLk79Okt1jGNbx4tL8MCA7SECRLZbzXTpgT5vPlPanLQ40ud/2P1b5z4OilbYzljt0JYtyI9Itq7Ah5B3B8Ihym1bMPzcn4cW+THy2U3szMSr3D+qwUTaaGI8Kvv+Sey3AlyfDJZlytoVGOt9aXkBx0AeYLH1g0DiF92J+F3Ouh6GzaW4yBIdMzbh7LyfQihPBGOrKPhNuCPlkDRhDCDHQlAHgp3tdXdjIJcGuT6F3cyyE9StWMpgzXYRuwGy3sEaRvPWocRuU4NyH7EW4ArnkdDN43/4Dt8D1I5hYWEpKG/EPmkwpJB4+XuxPYmyUyjXwElFUlm9Zg/zVF4pRvsTk1ZcKoP8xyx15z+GbKMOIr6zagM3uyRQcJ+OoMjPHVZM1MqgCF6l29eF8kGIjphQTNGPc/CyHDRFDhy1TAxTAIb9BTaF5sx6er5fFvyNC2mkbjbN6JShL77HJoHhclFzKzEp/FE+99lnV4AapNWztsEgFzuzqoLrw+ee+4QBiTqfdKno2TxRd+/m3MoV+SnMaeujb2xRaajkfCaZdxUuDg/o6SJEe0FlnKMFq69twvs9L8F2Jvf9nMNAyRUOBI89MWCx/CkWNAl7puHR9JH1spL1KWwYaMYqrYviTOcUZpzAWI7ThJ2ERre5kUq6rZkFRlesFThf4iBbzrWvdRh/68I/y+JSLDbbARcSy2FEJGCQE4+/DAePwIJZ3hJTwRqZUU8QMiuk/XG4jddhKGIuu0L+B3L0479ZTt86RmueiDUCOZEeZ5LIXhi2zdfGKmcXqjLqqe2Df7inuMyJaCsiqDmCMxHx39W2ne0CCFsQuNSEvqagYkw6TlI+PjGypqfvdsNYQIeJT0jitpeVNFIfHZ2qHZjbj GHm035Q3 KWeTRARF/E48vVGuRLnRGPCz9n46daJQMwIWh2qfUtj6y9BmkjmfRnrkmoyF3YVWF11E5ksEORcITcC9tBHcp4V7/OUUhw8FnEYYUCT0KBYXY/P1Isi2KVihsXkLHh5Gm7PYqIeTsVWJbGRiUeNcvUnGBPBVqKyGyc+maeIFD0wM/0YDEMYIgHObes9imQWH6QxXDNSQfXkubgmGysnd+UuZOAe4XuP7MgZXVBVM8IuotGRKSuP4zc8akxTEtgwlOEGAs/PLDrqnlRTMe6rFXJSGzH2B4geFdB8flYThFXrfUIAQ8noeU9lx1YVXViLDexot46vIJC1qX09sFv/fvdkEKwM9xYf2/BoH3Xj7iWnvJgIyb6Z9NraIJtaZFMLmnQxu7KTRYaZYMLnr29tIJBwXr8DFAJa+U4HJFRI9QLtRMRH0l09Cx+s4diUYBT5yo/nzmMp+hUU3BmeB4taeIl/v+nTHMj2WFmt6eduY3ilHHUPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Conor, On Thu, Aug 31, 2023 at 5:36=E2=80=AFPM Conor Dooley wro= te: > > On Thu, Aug 31, 2023 at 03:59:37PM +0100, Lad, Prabhakar wrote: > > > > > Currently ARCH_R9A07G043 selects DMA_GLOBAL_POOL and we have > > > > RISCV_DMA_NONCOHERENT selecting DMA_DIRECT_REMAP which causes below > > > > build issue when MMU is disabled: > > > > > > > > kernel/dma/pool.c: In function 'atomic_pool_expand': > > > > kernel/dma/pool.c:105:44: error: implicit declaration of function > > > > 'pgprot_dmacoherent' [-Werror=3Dimplicit-function-declaration] > > > > 105 | > > > > pgprot_dmacoherent(PAGE_KERNEL), > > > > | ^~~~~~~~~~~~~~~~= ~~ > > > > kernel/dma/pool.c:105:44: error: incompatible type for argument 3 o= f > > > > 'dma_common_contiguous_remap' > > > > 105 | > > > > pgprot_dmacoherent(PAGE_KERNEL), > > > > | > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > | | > > > > | int > > > > In file included from kernel/dma/pool.c:8: > > > > > > Hmm, kernel/dma/mapping.c has its use of pgprot_dmacoherent() inside > > > an #ifdef CONFIG_MMU block. > > > kernel/dma/pool.c has it inside an #ifdef CONFIG_DMA_DIRECT_REMAP blo= ck. > > > > > > I guess that select should get a dependency on MMU: > > > > > > config RISCV_DMA_NONCOHERENT > > > select DMA_DIRECT_REMAP if MMU > > > > > > For comparison, m68k does take that into account: > > > > > > select DMA_DIRECT_REMAP if HAS_DMA && MMU && !COLDFIRE > > > > > Thanks for the pointer. With this changes we dont get an unmet > > dependencies warning. > > > > arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaroun= d': > > arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' is= n't known > > 29 | struct sbiret ret; > > | ^~~ > > arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of > > function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] > > 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, > > ANDES_SBI_EXT_IOCP_SW_WORKAROUND, > > | ^~~~~~~~~ > > arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' > > [-Wunused-variable] > > 29 | struct sbiret ret; > > | ^~~ > > arch/riscv/errata/andes/errata.c:39:1: error: control reaches end of > > non-void function [-Werror=3Dreturn-type] > > 39 | } > > | ^ > > cc1: some warnings being treated as errors > > > > To fix the above build issue reported by the bot, adding a dependency > > for RISCV_SBI in ERRATA_ANDES won't help as ARCH_R9A07G043 is > > explicitly selecting it. To avoid imply should explicitly select based > > on dependency something like below? > > > > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata > > index 92c779764b27..566bcefeab50 100644 > > --- a/arch/riscv/Kconfig.errata > > +++ b/arch/riscv/Kconfig.errata > > @@ -2,7 +2,7 @@ menu "CPU errata selection" > > > > config ERRATA_ANDES > > bool "Andes AX45MP errata" > > - depends on RISCV_ALTERNATIVE > > + depends on RISCV_ALTERNATIVE && RISCV_SBI > > help > > All Andes errata Kconfig depend on this Kconfig. Disabling > > this Kconfig will disable all Andes errata. Please say "Y" > > @@ -12,7 +12,7 @@ config ERRATA_ANDES > > > > config ERRATA_ANDES_CMO > > bool "Apply Andes cache management errata" > > - depends on ERRATA_ANDES && MMU && ARCH_R9A07G043 > > + depends on ERRATA_ANDES && ARCH_R9A07G043 > > select RISCV_DMA_NONCOHERENT > > default y > > help > > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig > > index 67604f24973e..543300fe9862 100644 > > --- a/drivers/soc/renesas/Kconfig > > +++ b/drivers/soc/renesas/Kconfig > > @@ -334,10 +334,10 @@ if RISCV > > config ARCH_R9A07G043 > > bool "RISC-V Platform support for RZ/Five" > > select ARCH_RZG2L > > - select AX45MP_L2_CACHE > > + select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT > > select DMA_GLOBAL_POOL > > - select ERRATA_ANDES > > - select ERRATA_ANDES_CMO > > + select ERRATA_ANDES if RISCV_SBI > > + select ERRATA_ANDES_CMO if ERRATA_ANDES > > help > > This enables support for the Renesas RZ/Five SoC. > > > > Or am I missing a simpler way to fix this. > > This seems reasonable to me at least /shrug > Ok I will go this approach then. Cheers, Prabhakar