From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70057C83F12 for ; Thu, 31 Aug 2023 13:03:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD1208D000E; Thu, 31 Aug 2023 09:03:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A82938D0001; Thu, 31 Aug 2023 09:03:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 949388D000E; Thu, 31 Aug 2023 09:03:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80F5E8D0001 for ; Thu, 31 Aug 2023 09:03:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4647E1202C8 for ; Thu, 31 Aug 2023 13:03:24 +0000 (UTC) X-FDA: 81184415928.01.D5E8B93 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf07.hostedemail.com (Postfix) with ESMTP id A1FD240118 for ; Thu, 31 Aug 2023 13:02:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mXqYW67C; spf=pass (imf07.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693486920; a=rsa-sha256; cv=none; b=mfbTI9P+E0RMESgpi0Bf1UfGAwG8wD7yMQYpcOntECmJX7Dp+PB0qIurz1kpqyHyzvls+L fNqk8AsQdD/8rp3fda7pjAgiv7zjvQ+dxwX65gYIaRVDb5MqwGXTr/DU8M4kJz45V9sGNY zvcjguJIklEECdNLCU9bMDvWfi1Eg/Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mXqYW67C; spf=pass (imf07.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693486920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CpJWFwXbjpBPJKdgfU1P3LDYz3QvE+vc+2XTO0Izgdw=; b=3dR6bZGOteyhZAeEjR1lw+CbDTVIef5pW6pRdw2Cac77JaHvFZQwR2lf0tqADG2YTnRlJz pz69qonhMx3fNXT+vlg0ijj5wjAZE4IuERHEufFWzaEqv4XUuzLb5bRRjmWj0FF/mhUAuC jgYoY/bhGf2kWpNsQ9kNaz7Hf1S4wW8= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-34baeb01942so2733965ab.1 for ; Thu, 31 Aug 2023 06:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693486919; x=1694091719; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CpJWFwXbjpBPJKdgfU1P3LDYz3QvE+vc+2XTO0Izgdw=; b=mXqYW67C86ervowC3NGsz7U0sXVcVQ+d4L28Pemt1OowLaDodw4iL79oNLoGlp4nCg F6ZTUicDRQykZs5hxaIk4hIkMEm4QAqCniG0yCMBsT/zJYfMm+PErGkAf5xNd+2V2+5u TtDgeTAtZsmuf1igdmUOvcrwJoExrvMbLQHpizMM61rNegGs6Qq/SpZiCUxRCPpJMSRU +UbNAeZjNFKJbnkhjxe7bkhcG3D6CK2b4q9Bxxw6kUsyNP7uHvxKdh/7E000DASBAfmh VNy6SOj+ZJRKPLoaoFk3oaPYvVXjk+wlqXoVE70u8rqlkpqq5xx+LJ/l0CTJX1xH/MT+ r5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693486919; x=1694091719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CpJWFwXbjpBPJKdgfU1P3LDYz3QvE+vc+2XTO0Izgdw=; b=DFiRp6NUihI/JrAty+7mMoOemAzo+AVrJm/2Is9RoIgHeakvEOU0OHkuPdB2rCgrz2 Ozc232/853/h2FhrubZuDsxlaJluyB931fK0XZKxhAczwPDSn/PdBt4katu00n5TV60P TdHu+7jJNoiz2wKcGVH54gGf0F3NfQctAUz3xFQJT6UKN99Rdb/5LWs/qfjnqpEmDs8e H7QMEqt8dKts/uTNteQ9tekVomM3zapglqpGJqI7HpWPVWsIyGV5mSZvGdCc/+Fn955M 0puHERy4y6ZWadpnI1+/0CdmRYTMme9bWR21D94STuCa1USAXXyQP8XaO67wQt3ErHmY 2b8Q== X-Gm-Message-State: AOJu0YynuY2Isb/8/c9KQaQ821hVja7D5kq558ynkuolOcbV62PWESPk /dTtekptHKYbVisatJRMFww8G1XdT9vVsrjyEMs= X-Google-Smtp-Source: AGHT+IHJps3hnk8E8l1z8WvBtp8AIxG8dbn+uLFjyWsXxVA4Stfdvio9HOCUnnVm+4nhdvVW2W7A3dDGhJnww0/tSLM= X-Received: by 2002:a05:6e02:1071:b0:345:f28f:cc26 with SMTP id q17-20020a056e02107100b00345f28fcc26mr5021202ilj.24.1693486919382; Thu, 31 Aug 2023 06:01:59 -0700 (PDT) MIME-Version: 1.0 References: <202308311610.ec6bm2G8-lkp@intel.com> <20230831-congested-monument-44ddb496204d@wendy> <20230831-imperial-surviving-afdf6d275388@wendy> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 31 Aug 2023 14:01:08 +0100 Message-ID: Subject: Re: [WARNING: ATTACHMENT UNSCANNED]Re: [linux-next:master 13230/13643] arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known To: Geert Uytterhoeven Cc: Conor Dooley , kernel test robot , Lad Prabhakar , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A1FD240118 X-Stat-Signature: k1k6ah3ypc6n31ryxjw3nmnieng4mdp3 X-Rspam-User: X-HE-Tag: 1693486920-70072 X-HE-Meta: U2FsdGVkX18CqRljviTrvMW6pJt9bsw8diwArkebAIC0CHN+ROgRopZ8FpGgWWghjVhU/W5iimo1rvBj3vDVCCRHd0ynRX/1UrNy55edeRbPz+heWcb+vQ5JXWgD8X5VhfyI17OmAdbjwZ32j/RTEKk8lM7mc5BdVZAxQcbQPPoIS4iaMdBTvmAJRlGvSWFazSvHvblCOmbt59VXBPyG919ly1MDmHFI7CCns6gzBbqMt2bdxwyeg2A1oyAUcTT9pRDZ+s3W9MrZR7NpuLHujA6HCnRUIeu3pxFQe6Z30ECFpPuFV2R16LhLCuGTj8RXKOoHCagwwcNG0ZI04po+24Kzm/ZEwMIS6aFFSHW6ZaP85xYgTrk8SBcvM4JYnatbo02QIiU8Fc6DDHGfsyn78mtcOJajry//O6M5TmTWh04+hzQ5R74DG6WHR3gBs+w3Bw6ho8d6Oge0kZ7GXZJ/nwgI+a3B+DdyL9WGtbuAlvTn2pXUt6N+7Fxj5LdfCSf2MtakzE0kXqD9T1D/H1337N+Kdu0bpDdI7QWFrou70NbeUSnydgoEAsYDM8yFcKrSnHPT4oPNZh4AyDp4KqhdDIevVRcO4cbnq4K1rtcTsjZ9n1//owFVlsCHkwJcbkQXMKybZFX1cQ1fy1cuSRxh2mwH2+J/j4jh/N8P2YvbY+3MARy26HNCBlxlH/4cbsxp+Cw03woJUdd8hqTX4sjLkOq6IvRcJ47jiunLaOG889ip59bFpgUV5rN9sHvfa9X00UIZmVofEi+6VmPdCn46lAs8aApUUbU6ZTB7GdLpjYTTXMTUAXGDcZcdulgNO1nJPF7DvSugo5etHu/JAVdKEGUy/+fOnWOdul2yUk0czRHf73WlWsh4BqwMW4Bdk5KcAR5akF8L4QKtrHsa7/lFqb99wpRP8QRlwxUMeg5hl1GKwA/Zt4M2VQ7CsQuBd52/ihad/cHjyQBzCLwEMPw flRikUGT qNCorkeNl2Ec6pMU/H8IlKJpHKY0+TO2PneYwKE8ZJdwsMCQF9eQdTUccBShqgkMYkcLEJ5GhdgLUnJYDk7rWwK5VKX0IuBDovEfNaZ4C9M9yIkRnMmpFnwYmoaAMBEB+eEdNhFwEZemRBfi1mbwN2EFR9dr99gDTBNTfwPFxi/0W9huAiObpCt+5FGg6/bpT0g4ICztJjlbNpaQT87VZejUe/V5LDXgUiJBltasF8SP7QenZScOx+RtlDfu89ByXSSWyGpHPZhnBiwjlusSc8E52AvYwYZh9DyHV5OZ2+TIJAjv1bCvugSxl8LpwA1uRX1hCF6BUOVtWTID8q2fDJpvO+ae3uOp5HJzxchMvyNiuHBdI2IouO8qtiNmKBbFm9IQIliMCuL291CvhsQpZ8ywPWFv9vvjAtujxTX5rIrDD4FF4HIPDMET5YRtA+5ElnI2LzS4oVMxmtyrfaRwtsrTWJSuBRvPmWWzBlkWCR7mhKvgS8E7DA9KlOGjgnLxmyt8zcyUbBF6IggieXQ/DMuUZhOCTeqF93LOS4yDrblM2MQLzjp/a7FjhH+S+slSS9FMIJLUhlVZNcmUhAxZsMecSq3CsPaA3YU0f3jrc53OYeIawfR4lyDWG2mxrtWxWb7l/uDhFVzkwZu4Gcl7NaP9YZpB4dTRHYkERPAvWaTA3EBI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Geert, On Thu, Aug 31, 2023 at 1:01=E2=80=AFPM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Thu, Aug 31, 2023 at 1:54=E2=80=AFPM Lad, Prabhakar > wrote: > > On Thu, Aug 31, 2023 at 12:34=E2=80=AFPM Conor Dooley > > wrote: > > > On Thu, Aug 31, 2023 at 12:22:50PM +0100, Lad, Prabhakar wrote: > > > > On Thu, Aug 31, 2023 at 10:44=E2=80=AFAM Conor Dooley > > > > wrote: > > > > > > > > > > On Thu, Aug 31, 2023 at 04:52:00PM +0800, kernel test robot wrote= : > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/li= nux-next.git master > > > > > > head: a47fc304d2b678db1a5d760a7d644dac9b067752 > > > > > > commit: f2863f30d1b05e5ecf61c063609cb974954d47f8 [13230/13643] = riscv: errata: Add Andes alternative ports > > > > > > config: riscv-randconfig-001-20230831 (https://download.01.org/= 0day-ci/archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/config) > > > > > > compiler: riscv64-linux-gcc (GCC) 13.2.0 > > > > > > reproduce (this is a W=3D1 build): (https://download.01.org/0da= y-ci/archive/20230831/202308311610.ec6bm2G8-lkp@intel.com/reproduce) > > > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just = a new version of > > > > > > the same patch/commit), kindly add following tags > > > > > > | Reported-by: kernel test robot > > > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec= 6bm2G8-lkp@intel.com/ > > > > > > > > > > > > All error/warnings (new ones prefixed by >>): > > > > > > > > > > > > arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_s= w_workaround': > > > > > > >> arch/riscv/errata/andes/errata.c:29:23: error: storage size = of 'ret' isn't known > > > > > > 29 | struct sbiret ret; > > > > > > | ^~~ > > > > > > >> arch/riscv/errata/andes/errata.c:35:15: error: implicit decl= aration of function 'sbi_ecall' [-Werror=3Dimplicit-function-declaration] > > > > > > 35 | ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES, A= NDES_SBI_EXT_IOCP_SW_WORKAROUND, > > > > > > | ^~~~~~~~~ > > > > > > >> arch/riscv/errata/andes/errata.c:29:23: warning: unused vari= able 'ret' [-Wunused-variable] > > > > > > 29 | struct sbiret ret; > > > > > > | ^~~ > > > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > > > > > > > vim +29 arch/riscv/errata/andes/errata.c > > > > > > > > > > > > 26 > > > > > > 27 static long ax45mp_iocp_sw_workaround(void) > > > > > > 28 { > > > > > > > 29 struct sbiret ret; > > > > > > 30 > > > > > > 31 /* > > > > > > 32 * ANDES_SBI_EXT_IOCP_SW_WORKAROUND SBI E= XT checks if the IOCP is missing and > > > > > > 33 * cache is controllable only then CMO wi= ll be applied to the platform. > > > > > > 34 */ > > > > > > > 35 ret =3D sbi_ecall(ANDESTECH_SBI_EXT_ANDES= , ANDES_SBI_EXT_IOCP_SW_WORKAROUND, > > > > > > 36 0, 0, 0, 0, 0, 0); > > > > > > 37 > > > > > > 38 return ret.error ? 0 : ret.value; > > > > > > 39 } > > > > > > 40 > > > > > > > > > > Looks like the config doesn't enable SBI, so ERRATA_ANDES_CMO wil= l need > > > > > to grow a dependency on RISCV_SBI. > > > > I think adding dependency for RISCV_SBI on ERRATA_ANDES would be a = good idea. > > > > > > > > While at it I am seeing below warnings with this randconfig: > > > > WARNING: unmet direct dependencies detected for ERRATA_ANDES_CMO > > > > Depends on [n]: ERRATA_ANDES [=3Dy] && MMU [=3Dn] && ARCH_R9A07G0= 43 [=3Dy] > > So the issue is that CONFIG_MMU=3Dn. > > > --- a/arch/riscv/Kconfig.errata > > +++ b/arch/riscv/Kconfig.errata > > @@ -3,6 +3,7 @@ menu "CPU errata selection" > > config ERRATA_ANDES > > bool "Andes AX45MP errata" > > depends on RISCV_ALTERNATIVE > > + depends on RISCV_SBI > > help > > All Andes errata Kconfig depend on this Kconfig. Disabling > > this Kconfig will disable all Andes errata. Please say "Y" > > @@ -12,7 +13,7 @@ config ERRATA_ANDES > > > > config ERRATA_ANDES_CMO > > bool "Apply Andes cache management errata" > > - depends on ERRATA_ANDES && MMU && ARCH_R9A07G043 > > Why does this depend on MMU? > Currently ARCH_R9A07G043 selects DMA_GLOBAL_POOL and we have RISCV_DMA_NONCOHERENT selecting DMA_DIRECT_REMAP which causes below build issue when MMU is disabled: kernel/dma/pool.c: In function 'atomic_pool_expand': kernel/dma/pool.c:105:44: error: implicit declaration of function 'pgprot_dmacoherent' [-Werror=3Dimplicit-function-declaration] 105 | pgprot_dmacoherent(PAGE_KERNEL), | ^~~~~~~~~~~~~~~~~~ kernel/dma/pool.c:105:44: error: incompatible type for argument 3 of 'dma_common_contiguous_remap' 105 | pgprot_dmacoherent(PAGE_KERNEL), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | int In file included from kernel/dma/pool.c:8: > > + depends on ERRATA_ANDES && MMU > > select RISCV_DMA_NONCOHERENT > > default y > > help > > > --- a/drivers/soc/renesas/Kconfig > > +++ b/drivers/soc/renesas/Kconfig > > @@ -333,11 +333,9 @@ if RISCV > > > > config ARCH_R9A07G043 > > bool "RISC-V Platform support for RZ/Five" > > + depends on AX45MP_L2_CACHE > > This looks backwards to me... > Ok, then how about going with the imply approach? Cheers, Prabhakar