From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D604FE7C4DB for ; Wed, 4 Oct 2023 16:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BC28D002C; Wed, 4 Oct 2023 12:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CC398D0027; Wed, 4 Oct 2023 12:04:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED76D8D002C; Wed, 4 Oct 2023 12:04:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E01CE8D0027 for ; Wed, 4 Oct 2023 12:04:36 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 985EEA0366 for ; Wed, 4 Oct 2023 16:04:36 +0000 (UTC) X-FDA: 81308251752.26.D1513B0 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf24.hostedemail.com (Postfix) with ESMTP id 81930180199 for ; Wed, 4 Oct 2023 16:04:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K6SAW0Kx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696435444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MABqfnWSdAh1rkdR5ORe/BqnN4/f/y3PtSz94ONAKI4=; b=PY46O9r6qeyD8EoZlQhp2C9sBzKw0zFdlF82R9jXAk8m5NycqCao9+EzyL829Tef61l55E qVbbwwB8T1Pu7Vfa7MWFM9z7IMS4Qe459Z8IYXgiU2zJOwuawuf/2Nd5Fq1PZAxIQu2gc7 OenI2z+1EfNuycHRid1Tvi4UznBqRnY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K6SAW0Kx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696435444; a=rsa-sha256; cv=none; b=GnOo2TNKAf/6+A7lXQykl+dDvdDM16Qnr1xwha/kwjWHOIenbPRQhaz4re606wwLLjiPQS uEA3serM9LNQ/RKGDMpKJV5x6ZcubcfnbbcByjvi96P7qr3mqVSIQubq2dbqoZRj90DBxf WELeNXKK8JoR8AufkoV2NTw4tPNYFKc= Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-49d0d90a7ddso14173e0c.0 for ; Wed, 04 Oct 2023 09:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696435443; x=1697040243; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MABqfnWSdAh1rkdR5ORe/BqnN4/f/y3PtSz94ONAKI4=; b=K6SAW0Kxq9Bg+MdPt7vOdi10FbMXJirnlNdfR8GfU8vm1CG3xYp3YLHD44afFs0Hp5 FN4hwiZ6vKnq+EDq/g9PXyJyyxv/DXn6BeVtcfkQNSqoCSApqD9zGUrVDkRWPmRtHfbi v4qNKxAj8hkB9OW7QLJSfOvephCE1l77hiuJyrrw33Lo318SrqZmLLIIihGkwnHUtwJu 2oUFsJ+WVoOJ/sEd4irnMvKV9SHlDTcKXQQDt+i+yfNcuwBbURmmKQFpb0USXYxuZZST LGqA/HYpH/aWuG1Cw9+4FKzTla2O9XbdIopJPD85Nr1L05Iy3x+AvVSs8LS87eBvQgNL 0Z9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696435443; x=1697040243; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MABqfnWSdAh1rkdR5ORe/BqnN4/f/y3PtSz94ONAKI4=; b=maAIFbrh+V8S5Oyy9v9+1Qz5ZfM0hfd3wQP+XjCSfoQIdupCW2vm3IyK2tU4Dszj8h GBOJrdBVe4ySnk+2UdghgyGCuTT0tnvkLsWJtOyX/esJXRJx/xw/OUey1+BfjHiHpLY0 ydrxRgUmtXWsihgDAFg/QL+XbwvNPchQOFnI5ZeQZKi8pA4hyX9G3jq3n8aPoZ7s8KOz +OnVlFMQZ1za6oy3NtaLdYQHk61WbyOWZdOe1UOr+TyRG8kwBBsoL7Ik3GHSJlLH7TMX hcSMLH1LxOTKbX6rm/SGyxe7lmHmPxzNMS0n7b2I51xmvEsBUZYMmTKe+lv4su3v16OA 9Ihw== X-Gm-Message-State: AOJu0YzVTADn0OK4Sv1cpeHr6sp3lottfqJoTQ8wKWW2Eo/xTKckA5NK ewetQqE3LSj4jJVj6ityjCqvnHn2nbGMg5RqU20= X-Google-Smtp-Source: AGHT+IFhqTAHYHSaLhsynlzcRRRkFceUfAS3vdmJwZJTjrHm3e3CkHq0mrE5OVpqiZHY9FG2KMkgJe29WNiyo850cMc= X-Received: by 2002:a1f:4ac2:0:b0:49a:3537:881e with SMTP id x185-20020a1f4ac2000000b0049a3537881emr2263379vka.13.1696435443340; Wed, 04 Oct 2023 09:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20230921-th1520-mmc-v1-0-49f76c274fb3@baylibre.com> In-Reply-To: From: "Lad, Prabhakar" Date: Wed, 4 Oct 2023 17:03:36 +0100 Message-ID: Subject: Re: [PATCH 0/6] RISC-V: Add eMMC support for TH1520 boards To: Robin Murphy Cc: Geert Uytterhoeven , Arnd Bergmann , Icenowy Zheng , Jisheng Zhang , Drew Fustini , Christoph Hellwig , Lad Prabhakar , Robert Nelson , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Guo Ren , Fu Wei , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Jason Kridner , Xi Ruoyao , Han Gao , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexandre Ghiti , Linux-MM , Fabrizio Castro Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 81930180199 X-Stat-Signature: w6qyrzptwrdqwwcmcjxkqxooedsz75ro X-HE-Tag: 1696435444-852245 X-HE-Meta: U2FsdGVkX19egtz6oPCiwM06hWKQ/ED9PrdihhRo1vC/rwDaP5cC1M2y8BRc9Fod9ijAhfIltc/gzevISr2Eec/SmwoA3PC6miR4gAXmk44rQEZPy1QXGrYqhX6KG1qKfRbSxAztj5sKb1evx+dKM+IU0fYYWhcBTUDu7ntl/us4rxI4HayWBDORoCOuj9EBs5RqtFcLbQFjEvg8TTZPykN30zMoT1smTYnvQ4X+y8X0BR2Z3wZNuePXc6oaQMk9KqI8dR4eU3kjkijU0DnuXliNzHH5bEzKaZc+51Id4qW94VJ8hRsHrX9GptXMEXkKSEo0c/WDmDj/J3HJpSXj93cBvXGLHuMLaFENegKNeyW/xyKDTHBC7+7tf4hUu6P2XYEwItFdgPrvC0K8he4QI9lP0JrIZ6QWYF3b4YQYLp3hro9SYXAyWLndRMxWCpTVI8U8AeQ0dVz0YdifjDx7jxumoC2ZfQtkE6fBM5oXpQQ1G0jlFASBhTQlkx3/dE70Q1NperzTvj3IAXHBvS5Wi4mQ5UFxE6Hd0DyJ03cUxJ+0AZUusiGCcpCsNMaL/mC8GksTKwtEFZJHo34KOa+tDI8nk4L/YDgxxwhJAW3JRmMe3qFKxJT3DY7pvik+i5+fmHDBRv2IqIMwrLmrvdTIIojqlF2csJg3N+o6sq7pc19IcYKRUS9h0fWNzFuoSUbQ6ivMck/zrbMSL4CCqmky5VAq+NM1lWm5uAl/TcESVoSDPs1PkHShkGH3zxbNEKGh4VJ/Kz9rxSCoToid9RVX5lPVOkzeVbD/GrmbG9W3gZ+kg3D70P6J4XTLISMu2AYP4L7l2sSdAP3kM9BKMf4OHiL6zqE7GYTxFAKnZylszyEv5mDlI3RSPk6Jc995ztjaohDp/vsgwgWq2Zjue5zvN5Mczm/5gmXpBOOiWKzg/CdUfC30PT0pYDZIr43TiRYUu9dC1yt+ii8/Zyu2dkB h7HTEzle bQAbpuSR/92uATrSx5H3wJBEN5lhV7hHxfUxK7xlmw4p2acQXGJDkDYfb1Tm98/o3MxXKOIDz2u9EPD23yEI5Y4SMEIl7Gkfm9w2fMoMSDNoFmrdAftBi18boNkLyL+jWiR1kzQIeEPHy3M7mncN74qO4DIPpKkNwh+zxzAYaWLLgAGRXxQ+Q5QxSd3nyARD4m/8ausa+zfYoJ5JRUba74BfGslRqusmnh+dH0Yi/R7XteHXoKhYulPOe94VY3F25as25bViwfTnpaPybu1LiRQVqk1zaZCEZSfKwEYHrkTwnY+FiilbZFLTG+Ylc2El3WzZirvWN4jG9cIHivy6qpBeUPlwm1B/T4E2W2FO+/d1g3OpMxgFXbtyrehJapfGL7ncX2WITnFpnuOgv6TnVISoPWkcAH7ZjhbFCjxKUkZvMWA5tuEXFyRXp+k9ZMhxegNxj7xljKqLOfF75Sk7/SerZ16KHdF/ogUrn2QOmMNxmNRLq4dI5UdUqUKC50z1YgDaGBMee/BQUZW4UoVdQv5YjvtLjVzdH75VX3dxNEmTzNtNAo3yKLPE19omRzw60a6RllKU0+mdxwPTWyWFLH/VJdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 4, 2023 at 3:18=E2=80=AFPM Robin Murphy = wrote: > > On 04/10/2023 3:02 pm, Icenowy Zheng wrote: > [...] > >>>> I believe commit 484861e09f3e ("soc: renesas: Kconfig: Select the > >>>> required configs for RZ/Five SoC") can cause regression on all > >>>> non-dma-coherent riscv platforms with generic defconfig. This is > >>>> a common issue. The logic here is: generic riscv defconfig > >>>> selects > >>>> ARCH_R9A07G043 which selects DMA_GLOBAL_POOL, which assumes all > >>>> non-dma-coherent riscv platforms have a dma global pool, this > >>>> assumption > >>>> seems not correct. And I believe DMA_GLOBAL_POOL should not be > >>>> selected by ARCH_SOCFAMILIY, instead, only ARCH under some > >>>> specific > >>>> conditions can select it globaly, for example NOMMU ARM and so > >>>> on. > >>>> > >>>> Since this is a regression, what's proper fix? any suggestion is > >>>> appreciated. > >> > >> I think the answer is to not select DMA_GLOBAL_POOL, since that is > >> only > > > > Well I think for RISC-V, it's not NOMMU only but applicable for every > > core that does not support Svpbmt or vendor-specific alternatives, > > because the original RISC-V priv spec does not define memory attributes > > in page table entries. > > > > For the Renesas/Andes case I think a pool is set by OpenSBI with > > vendor-specific M-mode facility and then passed in DT, and the S-mode > > (which MMU is enabled in) just sees fixed memory attributes, in this > > case I think DMA_GLOBAL_POOL is needed. > > Oh wow, is that really a thing? In that case, either you just can't > support this platform in a multi-platform kernel, or someone needs to do > some fiddly work in dma-direct to a) introduce the notion of an optional > global pool, Looking at the code [0] we do have compile time check for CONFIG_DMA_GLOBAL_POOL irrespective of this being present in DT or not, instead if we make it compile time and runtime check ie either check for DT node or see if pool is available and only then proceed for allocation form this pool. What are your thoughts on this? [0] https://elixir.bootlin.com/linux/v6.6-rc4/source/kernel/dma/direct.c#L2= 38 > and b) make it somehow cope with DMA_DIRECT_REMAP being > enabled but non-functional. > DMA_DIRECT_REMAP config option is selected by NONCOHERENET config option an= yway. Cheers, Prabhakar