From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D494AEB8FB7 for ; Wed, 6 Sep 2023 12:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5870744015C; Wed, 6 Sep 2023 08:25:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53413440151; Wed, 6 Sep 2023 08:25:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF0F44015C; Wed, 6 Sep 2023 08:25:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 27567440151 for ; Wed, 6 Sep 2023 08:25:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F2545C0C09 for ; Wed, 6 Sep 2023 12:25:00 +0000 (UTC) X-FDA: 81206091960.27.1384E43 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 4073E1C0031 for ; Wed, 6 Sep 2023 12:24:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lbqOcW9+; spf=pass (imf20.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694003099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5fLhsTfYTqZdZr8z56hbpmg5XtICWKziyrzDfh2mv1o=; b=NiPC0QL3we1ZP/IZ86i+idxA8HBDZeFXWsKiZyURCsxF61ZLxWVc/4ytSKsk3OebHsxLRs CqCADUMTZCVfmgyB+XSTWtqqCjYnP2kkNTd9ii64HU2HM0AFshB43AxjXpXv2ku+76Fuqc WWlh//qEDa88g3i4ulM3vmkQddVZNSw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lbqOcW9+; spf=pass (imf20.hostedemail.com: domain of prabhakar.csengg@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=prabhakar.csengg@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694003099; a=rsa-sha256; cv=none; b=usVtn/plO6ucEUe+QRJBdBC4A/IwMSDa07cUBfe11BdPJ08eiqgeNm8O3mW7+Z9mZM+tsC tw4tMy+nGUgaWKfjYU/cnma3xasnLzRdZXnTliog0PZaSez72Iku7O0BdzkO0sD+XDPWA+ XCeS9+wj9SAD2kzI5vZwOIhBTf0N/tc= Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-34f3264a283so1908155ab.1 for ; Wed, 06 Sep 2023 05:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694003098; x=1694607898; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5fLhsTfYTqZdZr8z56hbpmg5XtICWKziyrzDfh2mv1o=; b=lbqOcW9+zrNYIz3d1R27UJ0uruuojFfuygBkiniQeo2LK0EyKqUqQPoUzwQRXOpv8q Yf+ekzkbgjEi3lEDSHeitpY4QbylyztYgHG8mUZV6FTfhvKuCWS6qXHFR+dZ00GYK1tx JVfW/rsvD7Tod9z63kT17SbRl9oEF+1L/Ys/1YC5XHWG/cFHqr1BM+6a+WByva2iFYpt kfmfcSKPI00q8XS3pirz/Wdn11i3nYiwKCDPOtZSifdywoY/Eh+26m1zLnPsgofGbgQ9 t6fcjZZr6Atz4Iv8fWu9w673gyBlJGC+0qj3j7Ju0QbFd+GHU+7eqHvl4PxC0TKpBtwA ZUew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694003098; x=1694607898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5fLhsTfYTqZdZr8z56hbpmg5XtICWKziyrzDfh2mv1o=; b=G5RK2qb6pnA7U3FuvGz38Azqh1OHcn4NCWPycsIarhujv1UqVfRPXs1iZmMxkbrwSD wWThHBDc/EhYXMkAo6qU7IxEY/GLI4Vtg6HhUxRcfTkF2eGd6P6lKsR2SPdlAzaXh14t AEAYJuoS6jjZXxxXFGejfnlillUCjuJWPA5xGf37h4+nyElcWWzbg2/M3SdfdNeAz0wS wbz/Hpdge5rIxDOgNG/U4kcGsYJ7OwmMP5DO/Lf4CWTU3YtrULrYmnu6FMNd/CN4FfF9 mRI/xxjU/KjdovPgZgXgFMoJoBoCYWawbLaGuOlZ1KjDXoWMui7RZMoHoB2eF4sd5N7K C+HA== X-Gm-Message-State: AOJu0YxE8OFhlnh8A6u2wSxqhNbvI5tdI3z4y816GTTJMq07GYEFfFn8 74DEHYMs+koU711lgJtuMjyP5/UBALMO86Uu1/k= X-Google-Smtp-Source: AGHT+IFXuzhnrvDWBwLUAAVx6AQhArl0lv3tw42IPTTuVjcH7zGUQNDliDj5Ts43x4pPls6rz9VqRxSdtcA8m3KZ8rM= X-Received: by 2002:a05:6e02:19c5:b0:34a:95f9:650c with SMTP id r5-20020a056e0219c500b0034a95f9650cmr18133885ill.10.1694003098249; Wed, 06 Sep 2023 05:24:58 -0700 (PDT) MIME-Version: 1.0 References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> In-Reply-To: From: "Lad, Prabhakar" Date: Wed, 6 Sep 2023 13:23:57 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() To: Alexandre Ghiti Cc: Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4073E1C0031 X-Rspam-User: X-Stat-Signature: tfr96z3zcuy5aegt8fakkg1u95eur83x X-Rspamd-Server: rspam01 X-HE-Tag: 1694003099-352731 X-HE-Meta: U2FsdGVkX186GlUomshnIUxxQBix8KEF/7iGEtEdYEFbywzBmubkRtfcQEgACRU0S6sSMAWdp0m9zuP4O1VvNdZky+8WPU8Phaity2qjbHKCcWOSphYexfX3IT4HsDmuHPBayYqRi49GgaUoBn6klIzzXR7ofE6TG0wEpLPYuEnHJnYUGebn/BFcJ4gmfK3s3gGHuyDHbTKq3GUz4davflRlCFoVc3pbSFUzW5lsU9BKdCTINg2JcbbYF+QcM5+fNbh2mgUyagEFTjOFaUGQBfaoBWvSQxD4y/eNb7XQugo5u4dz7I9lqDvs1jnonmUzEwncNYBDEDP/lUku30QMfysmy4XVbRhTu424u/Ypgnt61lAWoh+qQgUq3XylfnL9nUTzMhZBeO0LxkSRqzbORz66VYpDkEAzoSo9uIDJwOPwO/u4Q8dt/nVlpX+6UYbr9BxslG692girj3x8aygnR5Ss4BNwlZNPTZxLpXrIDgZSlL4kSdo8OsS9ttQdrPnNZ3Cjmt3j3s/zPgsYogXCz9xccA8Im6hL2/MiV2MlK/hHKFdRsCyuF3Dsuwl2jU6nF7qpwlv61OT/rwPKfKoTeADnnNs8tv7OQpQcSvuT7akXI8li0U6qfnySnaUZB/dNg6Bee1Aylr1YcL0+L0+5qAlVYblIzGMNNc9rbc7tN3WnwWQn/+3bwnVa/eQXUi/a4QUx4Lu9BRKrNySpnDCMSbn+wY+ONyo7X6EOfDT7FzcQhFiPkGloJiOSwHwVQatRqjyWrzyO4BG/CHspb4Wtm1iZUOlcfWUgJUsyoaiP1bz5Cl+U8MhRZvvIyrNwlf7yTnf6DzqEX/gdYCzy8+rudkLN7/uPcYKDtAU0AiPybdTPGvSZQQy4ukRjqFPUEP0YyPAyiU9znRpIB4VYx5tc5b0WmYY0LdTKUIY+cZ71uVwX4iixD4NENeR7R54jVeRnivaF7uWH6puFYtVu98p 4V3PLmHv L0YTVNKtqnSxdkmI9fWDHBfWRGsjpW/u8Vy8MyVtLc+Is84KFqpERNVkzS71NL3V+SzZQJmIUaWCrWkxL4xsY+N1PcL8/TKAZrjq31AXCOuw7VCpPSm3kXLHHm9wxX5j1D3CDBK2/MJDXppcryHVYxI2sb3bp7OCAjI3vuc7QFFRbRu0MfJksNc7UGXfNe7xLdNfLINhGHe08xDvV+kLu4Es0ZII2rbUH3OtUr3SfbaSnD5cDliv5ybDSiTXK0InH/3ATcSTTffXp1VHDBKq7Y3KYmxBUJeNjNR+h6tEnFMeeysKsXmkq3otFi8+Xo+KDJ8fYOaiURUdDIwhq96dgjyMG0mNDPn9JxPD7C9V8NMmfw3hTWNwgdqZCqSJ///jUwNsoYQahib9b9k90k2DhpyTEzqhB1UWYRcc8fdi5jPJw8r0mW+rhl58rhp0oCp8thqaD5dJ0bucx4t4PsTdzX8JgaRFFmzEuCoq57c0MZy+RTruHe8FW8sdfh0IXmqAf5x0VlS2SeI0Hj3W0i2Rt48mWaSNRj0oLGxbQWMx4x5kBaxJP5neyoxxsOX5V+kIQtTnLG/ZjiVoUw3pMvwSbbjVzaBuhga+k+yKJeVzoliA/Udrp8rwEFD77k8prLWAUHiwyZTNF53CCSqmLRLr8+jjrPeMRPmpXKNEKdeUwsB5YEnU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Alexandre, On Wed, Sep 6, 2023 at 1:18=E2=80=AFPM Alexandre Ghiti wrote: > > On Wed, Sep 6, 2023 at 2:09=E2=80=AFPM Lad, Prabhakar > wrote: > > > > Hi Alexandre, > > > > On Wed, Sep 6, 2023 at 1:01=E2=80=AFPM Alexandre Ghiti wrote: > > > > > > Hi Prabhakar, > > > > > > On Wed, Sep 6, 2023 at 1:49=E2=80=AFPM Lad, Prabhakar > > > wrote: > > > > > > > > Hi Alexandre, > > > > > > > > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > > > > > This function used to simply flush the whole tlb of all harts, be= more > > > > > subtile and try to only flush the range. > > > > > > > > > > The problem is that we can only use PAGE_SIZE as stride since we = don't know > > > > > the size of the underlying mapping and then this function will be= improved > > > > > only if the size of the region to flush is < threshold * PAGE_SIZ= E. > > > > > > > > > > Signed-off-by: Alexandre Ghiti > > > > > Reviewed-by: Andrew Jones > > > > > --- > > > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- > > > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++++--= ------ > > > > > 2 files changed, 31 insertions(+), 14 deletions(-) > > > > > > > > > After applying this patch, I am seeing module load issues on RZ/Fiv= e > > > > (complete log [0]). I am testing defconfig + [1] (rz/five related > > > > configs). > > > > > > > > Any pointers on what could be an issue here? > > > > > > Can you give me the exact version of the kernel you use? The trap > > > addresses are vmalloc addresses, and a fix for those landed very late > > > in the release cycle. > > > > > I am using next-20230906, Ive pushed a branch [1] for you to have a loo= k. > > > > [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug > > Great, thanks, I had to get rid of this possibility :) > > As-is, I have no idea, can you try to "bisect" the problem? I mean > which patch in the series leads to those traps? > Oops sorry for not mentioning earlier, this is the offending patch which leads to the issues seen on rz/five. Cheers, Prabhakar