From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F36C432C3 for ; Tue, 26 Nov 2019 14:10:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6CBC520727 for ; Tue, 26 Nov 2019 14:10:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rq4wgxhy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CBC520727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3D056B030F; Tue, 26 Nov 2019 09:10:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6886B0310; Tue, 26 Nov 2019 09:10:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8DEC6B0311; Tue, 26 Nov 2019 09:10:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 8EDA66B030F for ; Tue, 26 Nov 2019 09:10:02 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 2FC998249980 for ; Tue, 26 Nov 2019 14:10:02 +0000 (UTC) X-FDA: 76198612644.29.way19_3a732852c633f X-HE-Tag: way19_3a732852c633f X-Filterd-Recvd-Size: 3515 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 14:10:01 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id z22so669567qto.7 for ; Tue, 26 Nov 2019 06:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FtZkdml7U6qj2jxVG0aJfMPhl8Pc8rIq3csWsA0rzgQ=; b=rq4wgxhyGph7sMBYDEYoIFwxMRzv9XdXXTVxbaJBLaAFOGnCuIXHI+W4F1pJ8Q28ff lX50oIWJuUpCB4JX+WjfvnD/bke0OdsN+c6yGjNE3zw4MYkJFKz1dKmfPbsCxBInR+T6 yDFl7010NbDnqlR/JTo3tqNLnqStfAEB47hVmOsG+uGKb2l8oXonsRYZl/gHxpREC1cw EPP8gQskJB2D+IlXtqC60v3Nxwbp459YQCSu1XeSP5H4K5K5B0GNrZwRD0t3qbo1ilXV guSzjHfClGo0KgQ3vStfTvG82+E8i1dSn34agTtYdmR65iO1cS2pNLMuEHclMvSMBZfR Y/Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FtZkdml7U6qj2jxVG0aJfMPhl8Pc8rIq3csWsA0rzgQ=; b=bVSAxFvK8CDQ1oCF7EWOu6hNUMlndd7ipZbZK3KGrywjo1fWbMcI19TfQUbt9JWHgz sJeeiNwmE232aYu7uC2n0PKyuCquQGzLn/SjtIovzuueqfvF7dCmM2iTf0Cc1g7GBUEd hN+Co2jAltMPzdzfGZAUYvKvsgFLEg452hNzppdgEgEiiwIrYk8LT5md39xRMEIuj7aq 21S+wYPEr7qlMAId6tFMOKRMouZQkFlHU4CjFO96Jq5LcekyGVKRP+5i55VcWHWAqKqt 4pcWls3F4PnXJN8DkruZJM/iO4cvNZeV32APCB+BgQDaxIOHz8qrz9XsqFe1aA+KRRwe 1o4g== X-Gm-Message-State: APjAAAV6PHogi00105D287qKIfuOtiibaOqfMR3MASc8jxo+tNWM0Euk RGBQhR+6vmJloJRluoERmHPqdaIQp5B/VqXnZzY= X-Google-Smtp-Source: APXvYqzOrJdvvaM25hHIRi2TGSLvSpPFpJq4poExivCZHlAX3I639X3QB/w2UwsbUIUf9Mu8aT8+ulVlS6cNpips5Mw= X-Received: by 2002:ac8:1b41:: with SMTP id p1mr26799235qtk.353.1574777396781; Tue, 26 Nov 2019 06:09:56 -0800 (PST) MIME-Version: 1.0 References: <20191125142018.GA21373@haolee.github.io> In-Reply-To: From: Hao Lee Date: Tue, 26 Nov 2019 22:09:43 +0800 Message-ID: Subject: Re: [PATCH] mm: fix comments related to node reclaim To: Anshuman Khandual Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Nov 2019 at 17:42, Anshuman Khandual wrote: > On 11/25/2019 07:50 PM, Hao Lee wrote: > > --- a/include/uapi/linux/capability.h > > +++ b/include/uapi/linux/capability.h > > @@ -273,7 +273,7 @@ struct vfs_ns_cap_data { > > /* Allow enabling/disabling tagged queuing on SCSI controllers and sending > > arbitrary SCSI commands */ > > /* Allow setting encryption key on loopback filesystem */ > > -/* Allow setting zone reclaim policy */ > > +/* Allow setting node reclaim policy */ > > Does this point to the capability for accessing vm.zone_reclaim_mode = 0 > sysctl knob ? In that case we should not be changing the name here as the > interface still retains the original name 'zone_reclaim_mode'. Yes. This comment should be consistent with sysctl documentation and interface. Thanks for your correction!