From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C68FC433DB for ; Wed, 23 Dec 2020 07:33:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 899F32247F for ; Wed, 23 Dec 2020 07:33:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 899F32247F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B5206B00B6; Wed, 23 Dec 2020 02:33:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8654A6B00B7; Wed, 23 Dec 2020 02:33:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 753968D0015; Wed, 23 Dec 2020 02:33:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 605566B00B6 for ; Wed, 23 Dec 2020 02:33:08 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1C2673637 for ; Wed, 23 Dec 2020 07:33:08 +0000 (UTC) X-FDA: 77623730856.08.blood70_1f0607227466 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 038941819E623 for ; Wed, 23 Dec 2020 07:33:07 +0000 (UTC) X-HE-Tag: blood70_1f0607227466 X-Filterd-Recvd-Size: 4389 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 07:33:07 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id x16so21544005ejj.7 for ; Tue, 22 Dec 2020 23:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BgD+OJZtoy+GqCM4AjTNJMAwwBgfIvF+0uEaXy3nQiY=; b=uplarCDz+XlWFtOFZTQlEadVd4ReELf1LV8VyzHkLPCt5lwIClEYJoQ/PIvKP6Uitd PAuWMab8zLgU/mX1i9MSkc7V5OGGk6d6MRiuUr3zo7fg0cOCsNtrDZKiXIqvSqxcybV6 tv3xVHJGIMOcwykr2D0YFeSM6RfOfevV0av+WV8VpZSRjhZJ1vfvT2yvpUmxTk55kYC3 Q14hzrzCHxh88a8MQSkaWClP6krQVtydqOxdkXbH+2TTRu9ww5s8CJa2wvdCbm51MfS3 +c4qJtJXWYnlpqJcIVl5LI7Lw3Zh13m8BeWXkEbtFAWS9gQhBL+GzvgX3wW+wPq1lPB/ VNug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BgD+OJZtoy+GqCM4AjTNJMAwwBgfIvF+0uEaXy3nQiY=; b=njRlShvLLxOKxidJpTRmGUufbYbzHCMEj6zmhupqaN5AJM0TIYHHLmHnrZ0VKif/su 3DN27vCUBkQdf8RYvwi3ZJyVcgAGHWHzK1TZwf6XjsjeRHLzCy5qz4tgYdgL6Bjdfsra z2+FYUDxkhsuABoPiJx66GclzQs2lPalUSSwghu2S7B7Rqs6L2aekHgrNIFthcvghOBg wTTrWHzwSBwLEqVvuQXWO1SYLMngnOQCS4ACJXJ1/n9x4BQFDV4NBkokBBF/tBptZqy2 PQrKcYWefWpRqqDL+0xDq5TMObQJ65N6/tSfVdVSCLZh3vOF/mPzXCQNE883O1wuUSFI gTpg== X-Gm-Message-State: AOAM531Uj8+Pvwa8j2APFYOfde5e3j4IfpT00ALmFf4GhuZzrA+NsbfC 6bUggQJOnFyPimrXQDaHUVfywq170Ca3Xsye5L0= X-Google-Smtp-Source: ABdhPJzwaAwBlSb/w5HjnFBFHlQvQqi0eTQuHSKEXXdKeWgFK4lMdP6YwHr6eccYHnczeh7ohVB7cIEJUFK/n42GDPM= X-Received: by 2002:a17:907:389:: with SMTP id ss9mr23240811ejb.158.1608708786301; Tue, 22 Dec 2020 23:33:06 -0800 (PST) MIME-Version: 1.0 References: <1608707589-6067-1-git-send-email-yanghui.def@gmail.com> In-Reply-To: <1608707589-6067-1-git-send-email-yanghui.def@gmail.com> From: Hao Lee Date: Wed, 23 Dec 2020 15:32:58 +0800 Message-ID: Subject: Re: [PATCH] mm:remove useless code To: hui yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 3:13 PM hui yang wrote: > > From: YangHui > > remove useless code > > Signed-off-by: YangHui > --- > mm/vmscan.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 257cba7..af1d176 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1234,8 +1234,8 @@ static unsigned int shrink_page_list(struct list_head *page_list, > * Try to allocate it some swap space here. > * Lazyfree page could be freed directly > */ > - if (PageAnon(page) && PageSwapBacked(page)) { > - if (!PageSwapCache(page)) { > + if (PageAnon(page) && PageSwapBacked(page) && > + !PageSwapCache(page)) { I think this is incorrect. Consider this scenario: PageAnon(page) && PageSwapBacked(page) is true !PageSwapCache(page) is false In original logic, this snippet will run into the first if branch which does nothing actually. However, in your logic, this snippet will run into else if branch. Regards, Hao Lee > if (!(sc->gfp_mask & __GFP_IO)) > goto keep_locked; > if (PageTransHuge(page)) { > @@ -1270,7 +1270,6 @@ static unsigned int shrink_page_list(struct list_head *page_list, > > /* Adding to swap updated mapping */ > mapping = page_mapping(page); > - } > } else if (unlikely(PageTransHuge(page))) { > /* Split file THP */ > if (split_huge_page_to_list(page, page_list)) > -- > 2.7.4 > >