From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD7FEB64D9 for ; Thu, 15 Jun 2023 12:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F08046B0072; Thu, 15 Jun 2023 08:20:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB83E8E0003; Thu, 15 Jun 2023 08:20:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D80AD8E0002; Thu, 15 Jun 2023 08:20:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C86AF6B0072 for ; Thu, 15 Jun 2023 08:20:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93D78B0197 for ; Thu, 15 Jun 2023 12:20:06 +0000 (UTC) X-FDA: 80904889212.11.EF8858D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 9F611C0017 for ; Thu, 15 Jun 2023 12:20:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c5fpxOBQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of fdeutsch@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=fdeutsch@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686831603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l5404QqJ9PwKRp/L4j64ezHhwogh+Ie4zcQIBW4EmEI=; b=k6icTYBHzqRNSIyFKQsu+chGcZnyXnBL9aaoHfECzk9RCQcyB1/Lq9dzgZB9BrYIPmGZq8 lRDMm4KXuQoDri394t+Ry0n5Iuy2vKVWoToxCLycv8PaImoGffdS0CotNIjKxHpr3VUHjF 964EgEoILrOMcx6JIT1o+3cx5r2ciTk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c5fpxOBQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of fdeutsch@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=fdeutsch@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686831603; a=rsa-sha256; cv=none; b=ikMvYXVJEnjvV/Ukp1zKPDC+riO7mAE5G8ZOcpD50lh9eEnFh0pwpj27wb/UBMXWX4Z3lX kCBB/gLGp/VcjV8cDyiWvdUNDneFZknlLa/EscPUe4gDGtvvjSkEF+tJiqRwZ/jSF77PKb qzPI5+AY/0O7DTt6yXYBSgTbTVjyy7I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686831602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5404QqJ9PwKRp/L4j64ezHhwogh+Ie4zcQIBW4EmEI=; b=c5fpxOBQqALYNG+GwX8npweFU5kGftTjAzfi+91n8Ny/HigJmUzyU67RD2qoAWT0H4o9HZ 45rlyyp5yaQfpghcqsYRAhmvV6cZCmAiT90RL6fpxh8GGUkAOo3APdFzWB+RgzJ9XdUB8p HosTZ8X6x7/OCBl9xe2enkFOTRPemcM= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-_ypkMTjxMjyDtIdd86h8GQ-1; Thu, 15 Jun 2023 08:20:01 -0400 X-MC-Unique: _ypkMTjxMjyDtIdd86h8GQ-1 Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-bc501a1b17fso2226978276.3 for ; Thu, 15 Jun 2023 05:20:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686831298; x=1689423298; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l5404QqJ9PwKRp/L4j64ezHhwogh+Ie4zcQIBW4EmEI=; b=Ops3UW4RPMtkf9+U0gxJxJa31glgBJAU7nKijIejGX46XXMCKyeO3KgUL8+PrfePGh 9dVq0ueaNLy0KAqG0aLNGu6NdzA6EWg1aEIq/tqt/CL9RMOxlZLhrXD/J0IzQPvGJc/v 1OHgTcpNcPP78jSnfAT2n6tEX/xw8lpAcix1xf47JKAbDolqZivIzsTk14S1rEJGzkKQ M6yW36VR9KKystlyU4BvKz3Hip2HLullkyPcvBbl+Lptp/G7EE7VMOapIzsml12Fbjww +/02RECs0oZoyg+wpXdYYpADN+TF+Kd80igvfT4foPt1EqMmIygd5GYbM5aL2m/tykCv r0Aw== X-Gm-Message-State: AC+VfDybuyx0Kz64p0PS7e9Q4QaJAvb0I9LDdiblNDVwaSqefZ3VAP2r UcKcEIy7G0brFwEU2DgP2A5Xa7AauqN4JaZbgqVxSDdrAkdOgJITUEa9JC+APG32LDeykA2rJnU E46lqOWF0DqHoUN1ylAvaGwuPV9s= X-Received: by 2002:a25:4c89:0:b0:bce:81a4:d01d with SMTP id z131-20020a254c89000000b00bce81a4d01dmr4167330yba.34.1686831297930; Thu, 15 Jun 2023 05:14:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7bt74dQwyhmZGqxPQPhFJX2M7hWAKu0bEofTYEYlV2Y09Sb6Pvk3LWyGxUJFROME74Om5rnH1uFS9h/QV5Bss= X-Received: by 2002:a25:4c89:0:b0:bce:81a4:d01d with SMTP id z131-20020a254c89000000b00bce81a4d01dmr4167310yba.34.1686831297638; Thu, 15 Jun 2023 05:14:57 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: Fabian Deutsch Date: Thu, 15 Jun 2023 14:14:41 +0200 Message-ID: Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: =?UTF-8?B?6LS65Lit5Z2k?= Cc: Yu Zhao , minchan@kernel.org, senozhatsky@chromium.org, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , David Hildenbrand , Yosry Ahmed X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9F611C0017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ix7jepwhkf7h3uetktdkeiucrbq35kqk X-HE-Tag: 1686831603-384036 X-HE-Meta: U2FsdGVkX190eKoa4B1pukI0OVVzeY8D5VUbgp9ngy56dnaWfnKhmN2KdfmuO/RMne17kq28QxLgnhn5tSyRgoV5pCyX9SY5vDKYbMiysvJauROWjPEc/XRilMi2ggeexPnEXYiqz8rOINlYYALdy+64VQJ5T6WLMheVbgafSDuFbuzMujHm3aSJvsnvXZxi2rLkmTB3X8ALvxDoOhHcU2FO46XEdAg/F+bmN1VpTRYQ+vc4GGWWcLZkyxgNQKvSZ4hIVERxN6ebpZGToUWf6qjQgU2MeGoFdK/SQZXK//4KMWNmcImVkhZ+6rqKS+GLXhRU68wZewWFoyi3UoL2/6LwnGgbett/wrTAGfpOZxdgY6QLbRrka46sJzx5ia6qD4miDkL4/+VhnTmotONJeNSCn0aOamYDVsayB923w9vL3BgRqm8dKr3cocXUTjUWcmOlh58wPAzELr+QF7K2sJuhjJ4I0XVPDSN7FwTBsNFEn9gUvcF7IjwJvus7ApzjEvKulW/EDLWmsnQtazMhra60y8HsoLL4qGLP+BmO0dc4mSv0TmIwaBABkuL8mNTySvFbzbuayoJ9cBxWzNvD2NYV9UWThU8DEG1uFYxv2BgUM7Ww8bVHrUeSSDzys3/MLOBuRW8ifmEtZ+h4ixlxuWy7fqp8f14cEnleXXaM0gN6DOGeRb+geVDu06ygtnrv0RACEORwYoR5HQWCTgevWYWTkc/V3nHEOJv8P8rdyVDUJiyUaD/QsF7KMrahp/sQVCXJxVC8TQdHJPpsNOtjwrWY2jGb2o9SzlIL0bWczlpAJmx11QRK+6Nl4ebv5bwxASs8wx6jo8Z3xenURgG1+5fZkGE+OsYacN0nLd0geLYTHaO+/a63maBY+iBVI7kL1u83IGsb0ezBfhWUgs5NNPs+aJeBRg6gWwm5o4GNqNANY35Z52irXXijTNlQxaign8mQjPZLQJ6JtQKiT6W BAGi9hJ0 lRnQtoMIkS6HKx1t2HVRTGkWviP2M9KikSheCdDjRmGSBhsmBxMf9v9/Vsy5NjM9YwYhaEisaOIO6qem6a9or13iXn5n3Cwh3S5hmwZKAj9jZPK0RFzhswvbRZL7G7iYwNfOlE4zhm61EzSgXj426pTppUlYvaBgA56Ca1qNnHyztroF5zHbcHdo6q5haLxW94d5QL4q/oDRUm3dQogw3bs/BDZhljdMP5fLidRS/S73LCL9cJkZsvHO7cwS8QcGCXpvJsx0ksGlImQAEB9oCIeNw7a9RwEMZm/xLw82ImBi8bkQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 15, 2023 at 12:00=E2=80=AFPM =E8=B4=BA=E4=B8=AD=E5=9D=A4 wrote: > > > While looking at this in the past weeks, I believe that there are two d= istinct problems: > > 1. Direct zram usage by process within a cg ie. a process writing to a = zram device > > 2. Indirect zram usage by a process within a cg via swap (described abo= ve) > > > > Both of them probably require different solutions. > > In order to fix #1, accounting a zram device should be accounted toward= s a cgroup. IMHO this is something that should be fixed. > > > > Yu Zhao and Yosry are probably much more familiar with the solution to = #2. > > WRT per-cgrou-swapfile, to me this is addressing #2, but I agree with Y= u Zhao, that there are probably better solutions to this. > > > > Lastly, this patchset, while it will possibly not address the swap issu= e (#2) completely, is it satisfying the needs of #1? > > > > - fabian > > Thanks for your reply, fabian. According to the previous design and > test results, this patchset can meet the need of direct and > indirect usage scenarios=EF=BC=8Ccharge the compressed memory to memory c= group. As said, I can not speak about the indirect swap case, but if it is addressing the direct case, and putting the memory accounting on the cgroup - then this would address one of the use-cases I have in mind. Thanks! - fabian