linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Fabian Deutsch <fdeutsch@redhat.com>
To: 贺中坤 <hezhongkun.hzk@bytedance.com>
Cc: Yu Zhao <yuzhao@google.com>,
	minchan@kernel.org, senozhatsky@chromium.org,  mhocko@suse.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 Andrea Arcangeli <aarcange@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	 Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup
Date: Thu, 15 Jun 2023 14:14:41 +0200	[thread overview]
Message-ID: <CA+PVUaS5FhNksVUL-7+Ts6qyEd=tCV8e_2ig7pLwZa8hvhzwHg@mail.gmail.com> (raw)
In-Reply-To: <CACSyD1P=RtUtVOQrY9NVwn79=80zgC92NJyaqbjHXdrhZONx1A@mail.gmail.com>

On Thu, Jun 15, 2023 at 12:00 PM 贺中坤 <hezhongkun.hzk@bytedance.com> wrote:
>
> > While looking at this in the past weeks, I believe that there are two distinct problems:
> > 1. Direct zram usage by process within a cg ie. a process writing to a zram device
> > 2. Indirect zram usage by a process within a cg via swap (described above)
> >
> > Both of them probably require different solutions.
> > In order to fix #1, accounting a zram device should be accounted towards a cgroup. IMHO this is something that should be fixed.
> >
> > Yu Zhao and Yosry are probably much more familiar with the solution to #2.
> > WRT per-cgrou-swapfile, to me this is addressing #2, but I agree with Yu Zhao, that there are probably better solutions to this.
> >
> > Lastly, this patchset, while it will possibly not address the swap issue (#2) completely, is it satisfying the needs of #1?
> >
> > - fabian
>
> Thanks for your reply, fabian. According to the previous design and
> test results, this patchset can meet the need of  direct and
> indirect usage scenarios,charge the compressed memory to memory cgroup.

As said, I can not speak about the indirect swap case, but if it is
addressing the direct case, and putting the memory accounting on the
cgroup - then this would address one of the use-cases I have in mind.
Thanks!

- fabian



  reply	other threads:[~2023-06-15 12:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  3:48 Zhongkun He
2023-06-15  4:59 ` Yu Zhao
2023-06-15  8:57   ` Fabian Deutsch
2023-06-15 10:00     ` [External] " 贺中坤
2023-06-15 12:14       ` Fabian Deutsch [this message]
2023-06-16  1:39     ` Yosry Ahmed
2023-06-16  4:40       ` [External] " 贺中坤
2023-06-16  7:37         ` Yosry Ahmed
2023-06-16  7:57           ` David Hildenbrand
2023-06-16  8:04             ` Yosry Ahmed
2023-06-16  8:37               ` David Hildenbrand
2023-06-16  8:39                 ` Yosry Ahmed
2023-06-15  9:32   ` Fabian Deutsch
2023-06-15  9:41   ` [External] " 贺中坤
2023-06-15  9:27 ` David Hildenbrand
2023-06-15 11:15   ` [External] " 贺中坤
2023-06-15 11:19     ` David Hildenbrand
2023-06-15 12:19       ` 贺中坤
2023-06-15 12:56         ` David Hildenbrand
2023-06-15 13:40           ` 贺中坤
2023-06-15 14:46             ` David Hildenbrand
2023-06-16  3:44               ` 贺中坤
2023-06-15  9:35 ` Michal Hocko
2023-06-15 11:58   ` [External] " 贺中坤
2023-06-15 12:16     ` Michal Hocko
2023-06-15 13:09       ` 贺中坤
2023-06-15 13:27         ` Michal Hocko
2023-06-15 14:13           ` 贺中坤
2023-06-15 14:20             ` Michal Hocko
2023-06-16  3:31               ` 贺中坤
2023-06-16  6:40                 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+PVUaS5FhNksVUL-7+Ts6qyEd=tCV8e_2ig7pLwZa8hvhzwHg@mail.gmail.com' \
    --to=fdeutsch@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=david@redhat.com \
    --cc=hezhongkun.hzk@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=yosryahmed@google.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox