From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E427C54FD0 for ; Mon, 27 Apr 2020 11:22:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B02B205C9 for ; Mon, 27 Apr 2020 11:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SF6lAYna" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B02B205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C19228E0005; Mon, 27 Apr 2020 07:22:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9ED8E0001; Mon, 27 Apr 2020 07:22:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB8518E0005; Mon, 27 Apr 2020 07:22:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 914D18E0001 for ; Mon, 27 Apr 2020 07:22:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4EF82181AC9CC for ; Mon, 27 Apr 2020 11:22:52 +0000 (UTC) X-FDA: 76753397784.17.sky21_533c5da2c9a1d X-HE-Tag: sky21_533c5da2c9a1d X-Filterd-Recvd-Size: 8534 Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 11:22:51 +0000 (UTC) Received: by mail-yb1-f196.google.com with SMTP id t9so1729586ybo.8 for ; Mon, 27 Apr 2020 04:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+sTQSBQGvXy2D0dvI63XoUSxEtSuunGosymuu+jpg/E=; b=SF6lAYnaqav9eZe45MUqVbHRk8X6z+oNRi/QZhImIdXs0eInNuxXy+LZwyM+bF9FGD aRJQ66d9SfSStp6pYXSRcfaTwvdGmsEf+ICq9rMc6jGFf8sa084HfaMVB7jWGW2VU8/D s3wQwaXpNqY6lqIWrmRgym99+Y6szkPnzbmCYlhkm1nfAChJeKnzfSd0zmQtg6wTxSw5 P6WxB/2sqVQIG6o1K6cZywL4/U4Xfd+rcxauhvPm7QxKmTN0N9keSPS4nyhY5dxWxfFf Tj0ep3vh+I41QtEE8fOXANNtFUsuSrYjS8PbhtJdRONQoMzBOSM94tRej17/Vh+TNVEX Fkjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+sTQSBQGvXy2D0dvI63XoUSxEtSuunGosymuu+jpg/E=; b=Y46UEUFBUAgpYPR7eJoc/xB/2PWFz0ah9fMB+QjQefkoqtphbVI4uFW3be+0AcyXnI TzD7pjLNaIET8twxF/OLCsiQ6v5o8io1ywCsPAuwtJx0pIweWRXOfu76jMmeTeemzkDp fkZ9zhOE7k22mskZ3kHI4V88J0vT4GAXzVzS242wloxnuJGHkqQkHEcnUfOJbnD2i1Yn q4FDyKNQAODkhPrwHrfDPQmba69Z/SQl6ezhihccXuvKW/6QGHogq1N6ptPysD8Vhaxf ufS0IdHXJGpHvL/ZzqLP5o++sNpx8hWzSs2wTg4C2cqvPdf+8+IzHFuZVH1hrA2jypQG S0WA== X-Gm-Message-State: AGi0PuaK7GHXb4S941vWVtE8EkAOa578Gic42RviHGLdH1VVHq8wqnxp U7b7g11ET6zpD/Jb3FC54Ta5hzob/IezlGyjMds= X-Google-Smtp-Source: APiQypLoKOT4HJqObJu4I4isle7K49Tlnkyakb26swB2oUjwLyIMIQmoMshoqmgAIQz/uEKhCW1VoFGOOSd5wtL22oI= X-Received: by 2002:a25:77c9:: with SMTP id s192mr34880191ybc.482.1587986571296; Mon, 27 Apr 2020 04:22:51 -0700 (PDT) MIME-Version: 1.0 References: <20200427111113.5956-1-urezki@gmail.com> <20200427111113.5956-15-urezki@gmail.com> In-Reply-To: <20200427111113.5956-15-urezki@gmail.com> From: Uladzislau Rezki Date: Mon, 27 Apr 2020 13:22:40 +0200 Message-ID: Subject: Re: [PATCH 15/24] mm/list_lru.c: Rename kvfree_rcu() to local variant To: Joel Fernandes Cc: Linux Memory Management List , Andrew Morton , RCU Content-Type: multipart/alternative; boundary="0000000000007d812f05a443efbb" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000007d812f05a443efbb Content-Type: text/plain; charset="UTF-8" Hello. I apologize. Please ignore this patch and email. Wanted to send it to one person, instead git send-email also handled some emails from commit footer. -- Vlad Rezki On Mon, Apr 27, 2020 at 1:11 PM Uladzislau Rezki (Sony) wrote: > Rename kvfree_rcu() function to the kvfree_rcu_local() one. The aim is > to introduce the public API that would conflict with this one. So we > temporarily rename it and remove it in a later commit. > > Cc: linux-mm@kvack.org > Cc: Andrew Morton > Cc: rcu@vger.kernel.org > Signed-off-by: Uladzislau Rezki (Sony) > Reviewed-by: Joel Fernandes (Google) > Signed-off-by: Joel Fernandes (Google) > --- > mm/list_lru.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/list_lru.c b/mm/list_lru.c > index 4d5294c39bba..42c95bcb53ca 100644 > --- a/mm/list_lru.c > +++ b/mm/list_lru.c > @@ -373,14 +373,14 @@ static void memcg_destroy_list_lru_node(struct > list_lru_node *nlru) > struct list_lru_memcg *memcg_lrus; > /* > * This is called when shrinker has already been unregistered, > - * and nobody can use it. So, there is no need to use kvfree_rcu(). > + * and nobody can use it. So, there is no need to use > kvfree_rcu_local(). > */ > memcg_lrus = rcu_dereference_protected(nlru->memcg_lrus, true); > __memcg_destroy_list_lru_node(memcg_lrus, 0, memcg_nr_cache_ids); > kvfree(memcg_lrus); > } > > -static void kvfree_rcu(struct rcu_head *head) > +static void kvfree_rcu_local(struct rcu_head *head) > { > struct list_lru_memcg *mlru; > > @@ -419,7 +419,7 @@ static int memcg_update_list_lru_node(struct > list_lru_node *nlru, > rcu_assign_pointer(nlru->memcg_lrus, new); > spin_unlock_irq(&nlru->lock); > > - call_rcu(&old->rcu, kvfree_rcu); > + call_rcu(&old->rcu, kvfree_rcu_local); > return 0; > } > > -- > 2.20.1 > > -- Uladzislau Rezki --0000000000007d812f05a443efbb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello.

I apologize. Please ignore=C2=A0= this patch and email. Wanted to send it to one person,
instead gi= t send-email also handled=C2=A0some emails from commit footer.
--
Vlad Rezki

On Mon, Apr 27, 2020 at 1:11 PM U= ladzislau Rezki (Sony) <urezki@gmail= .com> wrote:
Rename kvfree_rcu() function to the kvfree_rcu_local() one. The aim is<= br> to introduce the public API that would conflict with this one. So we
temporarily rename it and remove it in a later commit.

Cc: linux-mm@kvack.= org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: rcu@vger.kerne= l.org
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
=C2=A0mm/list_lru.c | 6 +++---
=C2=A01 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/list_lru.c b/mm/list_lru.c
index 4d5294c39bba..42c95bcb53ca 100644
--- a/mm/list_lru.c
+++ b/mm/list_lru.c
@@ -373,14 +373,14 @@ static void memcg_destroy_list_lru_node(struct list_l= ru_node *nlru)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct list_lru_memcg *memcg_lrus;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* This is called when shrinker has alread= y been unregistered,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 * and nobody can use it. So, there is no need = to use kvfree_rcu().
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * and nobody can use it. So, there is no need = to use kvfree_rcu_local().
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
=C2=A0 =C2=A0 =C2=A0 =C2=A0 memcg_lrus =3D rcu_dereference_protected(nlru-&= gt;memcg_lrus, true);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 __memcg_destroy_list_lru_node(memcg_lrus, 0, me= mcg_nr_cache_ids);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 kvfree(memcg_lrus);
=C2=A0}

-static void kvfree_rcu(struct rcu_head *head)
+static void kvfree_rcu_local(struct rcu_head *head)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct list_lru_memcg *mlru;

@@ -419,7 +419,7 @@ static int memcg_update_list_lru_node(struct list_lru_n= ode *nlru,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 rcu_assign_pointer(nlru->memcg_lrus, new); =C2=A0 =C2=A0 =C2=A0 =C2=A0 spin_unlock_irq(&nlru->lock);

-=C2=A0 =C2=A0 =C2=A0 =C2=A0call_rcu(&old->rcu, kvfree_rcu);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0call_rcu(&old->rcu, kvfree_rcu_local); =C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0;
=C2=A0}

--
2.20.1



--
Uladzislau Rezki
--0000000000007d812f05a443efbb--