From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D081BC43334 for ; Tue, 7 Jun 2022 13:02:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AF148D000E; Tue, 7 Jun 2022 09:02:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45D8E8D0003; Tue, 7 Jun 2022 09:02:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3251B8D000E; Tue, 7 Jun 2022 09:02:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 21C128D0003 for ; Tue, 7 Jun 2022 09:02:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E2A9335338 for ; Tue, 7 Jun 2022 13:02:56 +0000 (UTC) X-FDA: 79551454752.12.85EAB2D Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf15.hostedemail.com (Postfix) with ESMTP id E90DBA0062 for ; Tue, 7 Jun 2022 13:02:29 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id y19so35054272ejq.6 for ; Tue, 07 Jun 2022 06:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBAPBWQf7bsWIM/4567gDBghNiToioCbV6qlqQR50IE=; b=OT+kV986wrjlyG5A3563I0PsfN8ar2tPHfFbfeIMGQj5cM4EkuJ85aSaPsz3X+jFbs 5Hl26oH02RBZ67QjLH3eFdutFJLu0vE9wHc/sos+jY+lJOkksVd/3XGi525lV3ePQwT3 tVRJQWlCfGREhCBZA5BvutVdIH7PjhnWaXGWcUehl226wbbJYKHIZFK84PyzOey+yXRq WfMSIfgz6IRY0qZpzbT5tiF6GUCvwextRuHYhf6MiVKFw23gsWVDajzpT6yiuYUxRMwJ mEljkE0TmXQi9quPQ11u8ckt+vtjOj18lECEGqUFZ9ngeIqqVxFR4D/HF2TgYU599N+I zL5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBAPBWQf7bsWIM/4567gDBghNiToioCbV6qlqQR50IE=; b=7qnEGai0Leoqx+HN7XnthBB79sMwP9W8kXp+fs77txqG9y6/RlWV7y8Iky2E6Ert/N sMnkfo0X0bkUbAr0hqp7uQoxcV2Ox+Y6bgyyafE5oSXmZKXyTSPvLHcNmCqhVw0PDIzv ybDppg08kzn+SNdOdB2OYyeQRVXUhHMSWNv/QhnEQGw6SJBM5tRBg7SQI3GBVZOmjHp7 j6tMbMVTgLbwIoqcn5GL78vXQ8I/GDKEgTBTb+Yb3c4a+6hdq3k+3CnQ2YrCkJ+BSfyi J11zWzKoxbBSFJztY5YGSzf3Ok95K43LNMr7xYwi62G8pcsRzN8trEaQ9ZcIJ+Aw9R3H AHBQ== X-Gm-Message-State: AOAM531VlQF8SE/uo6VQwNrgtQAoobfUOerhBUfkpFmIhViIP9uaYAgH Mb7l75qSwT6uKuejaBZQiAcryWuyzGZhi1ZrIfEPe7NzhufPJA== X-Google-Smtp-Source: ABdhPJwogSbzt92JF6FwrbwYRbZwWsQVfNnGp89cOXlkV67J/FcJoO4bVQot8XM1emIjITJkZbAsx3kTsYzV0SjEOQc= X-Received: by 2002:a17:906:d550:b0:704:7ba6:9854 with SMTP id cr16-20020a170906d55000b007047ba69854mr26088882ejc.579.1654606974834; Tue, 07 Jun 2022 06:02:54 -0700 (PDT) MIME-Version: 1.0 References: <20220607093449.3100-1-urezki@gmail.com> <20220607093449.3100-3-urezki@gmail.com> In-Reply-To: From: Uladzislau Rezki Date: Tue, 7 Jun 2022 15:02:42 +0200 Message-ID: Subject: Re: [PATCH 2/5] mm/vmalloc: Extend __alloc_vmap_area() with extra arguments To: Christoph Hellwig Cc: Andrew Morton , Linux Memory Management List , LKML , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E90DBA0062 X-Stat-Signature: gzyeoj417hop9gyyatiz9g8t7zymn6q4 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OT+kV986; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1654606949-501927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > On Tue, Jun 07, 2022 at 11:34:46AM +0200, Uladzislau Rezki (Sony) wrote: > > It implies that __alloc_vmap_area() allocates only from the > > global vmap space, therefore a list-head and rb-tree, which > > represent a free vmap space, are not passed as parameters to > > this function and are accessed directly from this function. > > Yes, which totally makes sense. > > > Extend the __alloc_vmap_area() and other dependent functions > > to have a possibility to allocate from different trees making > > an interface common and not specific. > > Which seems completely pointless. Why add argument that are always > passed the same values? > I wrote about it in the cover latter. It is a preparation work for making vmalloc per-cpu. In that case free/busy data are located on different rb_roots that is why those functions have to be adopted to work with any tree. -- Uladzislau Rezki