From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE1BC001B5 for ; Fri, 2 Sep 2022 16:46:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD03A800DB; Fri, 2 Sep 2022 12:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B804E8D002B; Fri, 2 Sep 2022 12:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7002800DB; Fri, 2 Sep 2022 12:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 966078D002B for ; Fri, 2 Sep 2022 12:45:59 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 73733A0190 for ; Fri, 2 Sep 2022 16:45:59 +0000 (UTC) X-FDA: 79867722438.21.9F3ECDB Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf20.hostedemail.com (Postfix) with ESMTP id 1B7211C0064 for ; Fri, 2 Sep 2022 16:45:58 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso6008200pjh.5 for ; Fri, 02 Sep 2022 09:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=6Bn341OZdaO1Ajjvul1ciSQkpdi2HXa6yajc+wV7KF0=; b=UuOUdc1lrwse1WuqW0nbs5Enufm53BNTljAMITm/SOp3cTseM4drqiEWGUT6Ap+4uR 3qoM7aCRNpmGXnc02t3bwILRhmyfwOz4tZthXvlUeXpx1ECGr7OS3RKfaXjxReHvx5ZU CbZcAdAYjrk8beZYak1peIWRdGKdhQ5f/gpNcf0T04O6TYbQNESS1hJXVpEziNmH+8sn f1CnQKS/uz74k2uwRzDegUpDTSVvk+VUOZFRieJRYwXh1OlJ67ptHxr0G7plbS8S394q twQiPkYadduhLtmHaN5p4FcQUssaqPT9ngxmx5gfOMh4cVKyF+PJmQOAtWmgt5YTQvCw 2kyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=6Bn341OZdaO1Ajjvul1ciSQkpdi2HXa6yajc+wV7KF0=; b=AWu1DryxOemlvPF6u4lhLnpwj3gZVMYbArqGcOQDttcsWA9K3jOJj40u6V4y5lwDN1 xkehYtFNN/vQ4YeuXmiQFDvKtKY9PG0pOE2eDkSg7wo50nHElkpl/KIhydG/WKXtb4qR vjtpeZMt/wad7Xp6EU+AxeRkszfoWs5d+cs8Kp6Jf4qs2Dg9h09m2wxL9yojmg5GX2k/ bvQsBQDsplIR1zFsU7UjAtJ5LaTgKHtOwEFM5o22iz35NEKZWAum4JYHWUpkoLpVIAHV gOKL52A/BQcGNLJkSJwocjjhEcfqL2/J0/uO7nqlyhMInUf5105T7OpoTr3oLs65/xfb TRww== X-Gm-Message-State: ACgBeo1A/J2snbJ/b9tCY1DkkekVGvdj++EEsYCCr+SL0IEQ02JQgfKn RXoc0BK3BI3agrmpo6UheNedieWBO9WLuTDCAJ8= X-Google-Smtp-Source: AA6agR5ea0NY94qclq1WPIQgFvItSSRmJdBaFn/nLRmCSHqulCNh3s89fQEtSSzn6RIIyJbg1AXa/rTbDVrcRwMBDBA= X-Received: by 2002:a17:90b:4a4c:b0:1fe:24ac:2bb3 with SMTP id lb12-20020a17090b4a4c00b001fe24ac2bb3mr5772326pjb.79.1662137158046; Fri, 02 Sep 2022 09:45:58 -0700 (PDT) MIME-Version: 1.0 References: <20220831052734.3423079-1-song@kernel.org> <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org> In-Reply-To: From: Uladzislau Rezki Date: Fri, 2 Sep 2022 18:45:47 +0200 Message-ID: Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments To: Baoquan He Cc: Song Liu , Andrew Morton , Linux-MM , open list , Song Liu Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662137159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Bn341OZdaO1Ajjvul1ciSQkpdi2HXa6yajc+wV7KF0=; b=mCBFg21dpyBdi+be3KI5o3Xz77KKSZQWAwhAcyq2U7XNMB8f60FZieWF/GTzwGkyilNAmL cd6zUQBe4ajouesljFz++OYLJvbSOemYWLhsDu8Pt5CJBbskJeDaqyPAMrc0sbW8C91RSa c19Q9V3367lTOhAWLPi6WeIkcZTQiks= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UuOUdc1l; spf=pass (imf20.hostedemail.com: domain of urezki@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662137159; a=rsa-sha256; cv=none; b=5joYtXPbDr1DiBZSQo9IaiNEg/vMFHeqduhFlzSNJOHcNY/gIj5q+F6eqWNXrVx/1HG6E6 XwJaMA1Kna01bRq2eabPUS4bIPSm3GlKtsoS/mjIdS1N+OdhQzcfeCPm8tMwEw3vHeAeje iwc0fKwveblypvx1EFn30iDl1n9KKs8= X-Stat-Signature: 8i9o7sureyrhef9359eogf9iq8rmdimj X-Rspamd-Queue-Id: 1B7211C0064 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UuOUdc1l; spf=pass (imf20.hostedemail.com: domain of urezki@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspam-User: X-HE-Tag: 1662137158-607221 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002309, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Even without this patch, the debug path would work correctly. The > > difference is just only in > > whether roots are hardcoded or passed over function paramter. > > Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check() > will fail compilation because the function interface has been changed. > Ah. That makes sense, though the commit message has to reflect it. So it is only about compilation error if debug is ON. -- Uladzislau Rezki