From: Uladzislau Rezki <urezki@gmail.com>
To: Weitao Hou <houweitaoo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roman Penyaev <rpenyaev@suse.de>, Roman Gushchin <guro@fb.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/vmalloc: fix a compile warning in mm
Date: Mon, 24 Jun 2019 11:41:28 +0200 [thread overview]
Message-ID: <CA+KHdyWTst1GFUC3JqHAieuV19UdR67LEPhvDKYZ569u2L1qbA@mail.gmail.com> (raw)
In-Reply-To: <20190624050937.6977-1-houweitaoo@gmail.com>
Hello, Hou.
It has already been fixed. Please have a look at:
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning.patch
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning-fix.patch
--
Vlad Rezki
On Mon, Jun 24, 2019 at 7:09 AM Weitao Hou <houweitaoo@gmail.com> wrote:
>
> mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
> mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> insert_vmap_area_augment(lva, &va->rb_node,
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 4c9e150e5ad3..78c5617fdf3f 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
> unsigned long nva_start_addr, unsigned long size,
> enum fit_type type)
> {
> - struct vmap_area *lva;
> + struct vmap_area *lva = NULL;
>
> if (type == FL_FIT_TYPE) {
> /*
> --
> 2.18.0
>
--
Uladzislau Rezki
prev parent reply other threads:[~2019-06-24 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 5:09 Weitao Hou
2019-06-24 9:41 ` Uladzislau Rezki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+KHdyWTst1GFUC3JqHAieuV19UdR67LEPhvDKYZ569u2L1qbA@mail.gmail.com \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=guro@fb.com \
--cc=houweitaoo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rpenyaev@suse.de \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox