From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71BAC43334 for ; Thu, 9 Jun 2022 13:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C088E6B0078; Thu, 9 Jun 2022 09:53:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB7A16B00AD; Thu, 9 Jun 2022 09:53:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A58DB8D0006; Thu, 9 Jun 2022 09:53:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 977D96B0078 for ; Thu, 9 Jun 2022 09:53:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5D03720886 for ; Thu, 9 Jun 2022 13:53:40 +0000 (UTC) X-FDA: 79558840200.06.AACF0EE Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf18.hostedemail.com (Postfix) with ESMTP id DEF871C0068 for ; Thu, 9 Jun 2022 13:53:39 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id b8so14628347edj.11 for ; Thu, 09 Jun 2022 06:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yMMFb3q8dQKJuiEfkSLQTJlf/XhrzWNCwTcjPXBqwk8=; b=IItgPjqhpx0+83mRLTgiGBYEQIi+BKGDe8oSQ+ezGoEQ8ASfW5c3KBNlItx7qhZIt/ d7POxEPq0nH13evlIx+T2QQCYuccW9BbltNkKptOFiXBQ1MTG8sL5Ix2Rs12AyGUc1OZ 20M3CdkHFWwMDGUs8F6abivuMs7hsD+zcSorF0RWaVAWmgVfLqlhEuRqsuTFeoFawdSR Hn0ZZqDHgai+cR5LgBEHl4GYVmF9tkOe/ZPULlTxeY3K9VZwesffe2BMg2A4BMJdPHA8 UXcZ2+Gt+fneWiehw5DVfm4jIF2D5zNSYGHjJT2OX1kKfBtHQnu63HFo7XZMITzQcKIM egGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yMMFb3q8dQKJuiEfkSLQTJlf/XhrzWNCwTcjPXBqwk8=; b=cPG2DxZHvtcUZ8fGlM0YOW7J0otV2Q7dIV6tQYCued74IAKpiDUHoez7WweXfSabv3 mHR6RnzK15WHK4WIhGRLekCP1juMX3BU7hUao77L6+WjIiSQli4uGDiN6PqjcBtUJbNq LUgfPpaXDD0lw2rixNmn3hSRbfeD9QoJXB4HmgoJaLriFbLCm1nSEhOjok0nSfyUYIju Z+BoCmH+t0tZBvLs8fPCSmWunJ2X+fX5dG8hpDdzsc/sGbQ0vNy/lxxzQMEg+0Gz5YVy j3ch4NIGJbQq2sb8YlJwEMqXWa6hAJE0Uj+Dnoo0T+vga1QzMHcvS7fjxDLWE4e1K9LA pTYg== X-Gm-Message-State: AOAM533Avp9OpmF/UQS7bpZwRCC0dnLuHoF7Sl9AA9M42h4HTpPhkPKq iaTJhMyMIWcBKQwOFzLXk5EyQLtrRTYJKCF3D+w= X-Google-Smtp-Source: ABdhPJzv2A4wp+xAKyjpuf4pqm0yuKPhCeXw+EKHLTCqRKXsbJIqAK9prUci7/okkqHMgmjZPWX7C2b87OF269RhAIQ= X-Received: by 2002:a05:6402:2554:b0:42d:ee79:559d with SMTP id l20-20020a056402255400b0042dee79559dmr45259225edb.175.1654782818596; Thu, 09 Jun 2022 06:53:38 -0700 (PDT) MIME-Version: 1.0 References: <20220607093449.3100-1-urezki@gmail.com> <20220607093449.3100-4-urezki@gmail.com> In-Reply-To: From: Uladzislau Rezki Date: Thu, 9 Jun 2022 15:53:26 +0200 Message-ID: Subject: Re: [PATCH 3/5] mm/vmalloc: Initialize VA's list node after unlink To: Baoquan He Cc: Andrew Morton , Linux Memory Management List , LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654782819; a=rsa-sha256; cv=none; b=t27o21YuxSnVruWCss4cSHjIoFZlhpkQMEscUBd1XjUSGy4PnLR4Oqdv+tncBNoIj8Qd37 Tr16WvRD297/8PxQ/9YPnblHWsH7jXuoeEmwEghfffs5iyHPpddkC0nlt5tFisV3c7BfKP nh66T1/nivOyFmNNd8ZWM9r27Ug3XBs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654782819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMMFb3q8dQKJuiEfkSLQTJlf/XhrzWNCwTcjPXBqwk8=; b=UDQzN45uA0EDY9YTxUlb8GLu+/XhuLeLgKqB+eY63I2EQLgr5QdDbYW3mJQg2N51tskFQE rRs5d/fDlzuKEIEbdbcwdVNAFStrrH7haehnCmoVZxqCygm8qBYMshN2/m86mg5b66sccN VOHYKt9Q23SQLASp9F3HYMjg//fOG2A= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IItgPjqh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=urezki@gmail.com Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IItgPjqh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Stat-Signature: 6zqwm8qry8fkzqxj38ofhi3pyp6pzjrn X-Rspamd-Queue-Id: DEF871C0068 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1654782819-34136 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 9, 2022 at 3:30 PM Baoquan He wrote: > > On 06/09/22 at 02:36pm, Uladzislau Rezki wrote: > > > > > > On 06/07/22 at 11:34am, Uladzislau Rezki (Sony) wrote: > > > > A vmap_area can travel between different places. For example > > > > attached/detached to/from different rb-trees. In order to > > > > prevent fancy bugs, initialize a VA's list node after it is > > > > removed from the list, so it pairs with VA's rb_node which > > > > is also initialized. > > > > > > > > There is no functional change as a result of this patch. > > > > > > > > Signed-off-by: Uladzislau Rezki (Sony) > > > > --- > > > > mm/vmalloc.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > index 745e89eb6ca1..82771e555273 100644 > > > > --- a/mm/vmalloc.c > > > > +++ b/mm/vmalloc.c > > > > @@ -978,7 +978,7 @@ __unlink_va(struct vmap_area *va, struct rb_root *root, bool augment) > > > > else > > > > rb_erase(&va->rb_node, root); > > > > > > > > - list_del(&va->list); > > > > + list_del_init(&va->list); > > > > > > Don't object this change, while list_del poison members, which is also > > > not bad? > > > > > It is not bad for sure. The main aim was to be align with what the > > RB_CLEAR_NODE() does, i.e. initialize VA when it is detached > > and be safe with list manipulation when it is detached. For example > > whether it is empty or not: list_empty(), etc. > > Agree. list_del() can't make list_empty() work, and RB_CLEAR_NODE() has > done the clearing already. > > Then this change looks reasonable to me, thanks. > > Reviewed-by: Baoquan He > Thanks! -- Uladzislau Rezki