From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34027CCD1BB for ; Wed, 18 Sep 2024 14:40:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 487F26B0082; Wed, 18 Sep 2024 10:40:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 438C86B0083; Wed, 18 Sep 2024 10:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325F86B0085; Wed, 18 Sep 2024 10:40:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 14E076B0082 for ; Wed, 18 Sep 2024 10:40:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8DD8C40637 for ; Wed, 18 Sep 2024 14:40:43 +0000 (UTC) X-FDA: 82578120366.23.FE69386 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf16.hostedemail.com (Postfix) with ESMTP id B4B01180014 for ; Wed, 18 Sep 2024 14:40:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUt8t8bu; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726670329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3uHcaosDH+2kqlFhkf7ltR5bOFuDI1RT/7lxsyCyAUQ=; b=LJbAxhur2L3lmiWw8olXoGoiQ1nf+w2kYqcu8haR+0f9yTbM2G7NvL9BfVW+Pp8i+nKF0k JIW0VKnQp3+YeOOesf5+ykLxoaF65C0HO73gbldt8ye0FMV2DgZVb3sozgtuSXgt7FBOtY gm1rmmTh0UYhtmUHRrkrl0nm+HEOn8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726670329; a=rsa-sha256; cv=none; b=RGV7YArxcIUFanbHcSRmkacCyAjQ+dNEnNcnowA8U0rD+cN2F/GFyIr/442if7DcxSyDCe 6FEPbf4XUuzmdCoMf/F/PTjiXv/rd2KlCyMUgLld+oeJIhwDY00qop/uPTxBGYumbHXLDY t1XxztUaa8IJKbwtirnEkgy1vMTKCME= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUt8t8bu; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a8a7903cb7dso439824066b.3 for ; Wed, 18 Sep 2024 07:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726670439; x=1727275239; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3uHcaosDH+2kqlFhkf7ltR5bOFuDI1RT/7lxsyCyAUQ=; b=HUt8t8buLxEbs0/0WKh+VBSHEJhjmu5vXxQRkfM4F+kP4M1YqMwlAx+1szHA45lnLU UpwA3ZLS58mh7elfgOxXdtFlIx8D9COTteEgE4J2ec+ybPZgW2odY0G68/rrD1ZeSUyD T6BQ9pS0icvTh4YCcI5x6JR5c8hgF6WRGbilzfdMNxQxkVjawFX2mYJ7f+Z9+KcS1DhP BXVnJlf01LGTzsbu/mUqeBB6T+wzu/HFbEXi1ZTERKtz8f0TihUNrK6znPUjpS/tluta ncYPeuTcLLawunSeyJMAq158RmECp8AOmO8IpHCl5znKL0yyZVRvQjFmUA7aih8oIEbr 3inw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726670439; x=1727275239; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3uHcaosDH+2kqlFhkf7ltR5bOFuDI1RT/7lxsyCyAUQ=; b=cR3b7QxIVosxrPg5LVWlFPcwEU+Li9sM/Woh+ktDyVY76Tk6NVEJ3xVL/ImhZ0i5pJ fShr5IJnLQn8BGgBc5DYXryW5zzcA5ojnyQojvcNqxkQMUoEfQqEISKLnyNdhWcszySg 2RET7DgAW442NfSyG8JdidrIWiwbm0T2jRHBUSl8vFy964FrUKdvgXv+2qqgsMbzWnDn 3lXFQI+BbkatjZYzYGbecE1sk0NFUNUxn+RTrYOYmaZwqyQzBRasD1a2i3uVq4Q4Uai1 hbZ1Nhn554SdywnaqjIHIbe0DXTjJbiL6uzv/Y9J8EwgzqbTTKqeQVmEf1l76qwa972G MTfg== X-Forwarded-Encrypted: i=1; AJvYcCU+PahgTHpF3ZpBfOm1bJdtk8XqILXiX/71ENzJvtMHjVGPkiiljfW0sAw4njOqNgI4sQHqr+R+qg==@kvack.org X-Gm-Message-State: AOJu0Yx0euOCWxPSXwpv0RatrhJ/nDfuzUJKTNoN8b+Fs7E0VHuAE67L aSoHkWOUS9b98DJOE0b6v0qqyriyBuqHaehzc0EfVSjyzuipDiuCWrt93n4EVg+4r6fgxVPdfu7 XOpH9AEewYa6yNTgocHjj/iTrMN8= X-Google-Smtp-Source: AGHT+IFayqEt3iMxQ5M5A7AnOxm3PGP4C+oLCToDpDYoWFq/yqCfgfhmSsqoJzzq4US7UK2z+G6kC7IkTCIp+kwgaow= X-Received: by 2002:a05:6402:50cb:b0:5c3:c4d1:83d with SMTP id 4fb4d7f45d1cf-5c41e1b529dmr22239439a12.26.1726670438835; Wed, 18 Sep 2024 07:40:38 -0700 (PDT) MIME-Version: 1.0 References: <8d6c5d10-5750-4472-858c-eadc105453be@suse.cz> In-Reply-To: From: Uladzislau Rezki Date: Wed, 18 Sep 2024 16:40:25 +0200 Message-ID: Subject: Re: [GIT PULL] slab updates for 6.11 To: Linus Torvalds Cc: Vlastimil Babka , David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , RCU , Shakeel Butt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B4B01180014 X-Stat-Signature: qszdc1ewruwa9x433jsbfhjytua6pqw5 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726670440-268856 X-HE-Meta: U2FsdGVkX1/12j/W7MVxV+c8ueT9XSnXBIf23j1BCitsrYxtIc/8EVdGWyzL3fpOhjfDCcOQnmTreXqIN/Q03Z/1PwiTTom+MTydsjEuzWWNklxSDjpYirmmc4ILY6XNuABlDk8Kr0NvjAXvFS6EeAeRjFcm47w9381gf4Ddl5fLw14dloRlMwX53vd0VtugbpCB+lPyGS3iUWaYgnJGt+2/isfz42anos/1Sm7lx9Qd4ruz1Gu3l4wxp6LTUgqSif07UV5cIx/4avf3F9CmCASCeocYB84WkM77EgTbObRVli+pmEDvOvjy23lFGkpRA+WiIO8L/HSO60znWjgF824q1V+0573ZwiAhN7rve1pFEOJChNlmvBwDZHBCkYKju/v61V3eaY4RxaMWRJIj9SHgUsDZEdOiKMxwsUSBi/huZDhw5M1Vj2xoDRCokcrbWFSGKcSFYVm/uFJrU1NXaudQjcT5jFZA35ZPRYZbyx78yIS7NQ8/ocziFu8uRtAlO8PfmxxOZ7oEw/R8naQpatfRw5OU62SlJri9HF3AbzBBC2QMoIXo8wjx0NMNTvMKb5Wzs6CPVluR9OZp3IIo9VG7rqqLWkUc5TpnLb+zl9bfRmLCGQvJbsT1FmzwzM4YHieb+FZzn7GKzqilLaAXYyotPNPBV0Z1gSKUGZn9tO5KBdc9X8SZgLnux1bTmkVg6gmRVDq9qFhyQdiK4Rr2Z+7gSqbTpZZ3IA+PLdBKbzmtV+bCtkpz9RN/6Lux/9d2S8poPOwWLh6QFCRehuUsGV7b6wvE5Dw+pqDLBm24MEeAq6LrRyVpg3S+98iCSFyH8ta6oo8tNw7vTZJ5S3m2kngXGQwZ6Z2Z59rvG8d9A+kXnmQibnoeMMKiausMsKqeTRjKKpt77hfiskBgu0MUsaKlZ9JJ3ynlGPswRGmo0A0rrqW8oEHBWwBG3brXddFtHYYBAWhNxhKzJa6asD3 AbE4p9BF KlcvJArB06A1j4zgrtk3w+FKAoHrS5akP+aEUtPXZS6s/w2jr7Z8lvMUFMSAcqT7CoJ2hf591yLAu0LDks3UWG054dGdf+D/8DCcdzYmnGtigecXy6yrpRPBnYIiZzlmeIsn2TjBC1bh2EYh2e8BSuL4z/rv98pJqTulgMJd0YfjmdQsOv07314KdRDK5+D1K8Cxwh61YChJcdmFnWbnR5UnTgR2WdIWXLAk4DfgMM4npkTMd8TPx+o3aMoMGojqMFDs+xJLQZpKDa4y2GeKl23gRFULi0tt5Mgy89iBN02uyrC/BMu3IExwIwGWnEZKMUdj+vzaEuNLJshCt23te9+hlo/7zcOI+nRDiVGhx8QHK4/XUA9l/EMhfSmQmgEmh1ItMh5rPD3Yh+0Zd/YwVnU5uoJFviopsSILOxCpd+8nTQI2O5LLRiTzv41wpBxvL0sGRe5gZ02mQDWYB0X3W20wmxHPf6tLjxGUPJ9ShLNhi1utR2q6x+EUyfQGp/MTM8GbdEYgteFTQ1Ubejyk19rpdhe3sFVjeKP/g0AlFzMN/uziIeG+WRrRtD/vetECPk4FEzss/2U+nQsiEppWIqsKAq5q7S2LtNSlS5NO+1rO8Owimn2WZBX5Iy1IY8pMkH7LhGX8oQKDMIS8LOuvOkRMppGeJOT+kyFRZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Linus! On Wed, Sep 18, 2024 at 9:06=E2=80=AFAM Linus Torvalds wrote: > > On Mon, 16 Sept 2024 at 11:45, Vlastimil Babka wrote: > > > > There's a small conflict with the rcu tree: > > https://lore.kernel.org/lkml/20240812124748.3725011b@canb.auug.org.au/ > > Hmm. The conflict resolution is trivial, but the code itself looks buggy. > > Look here, commit 2b55d6a42d14 ("rcu/kvfree: Add kvfree_rcu_barrier() > API") makes kvfree_rcu_queue_batch() do this: > > bool queued =3D false; > ... > for (i =3D 0; i < KFREE_N_BATCHES; i++) { > ... > queued =3D queue_rcu_work(system_wq, &krwp->rcu_w= ork); > ... > return queued; > > and note how that return value is completely nonsensical. It doesn't > imply anything got queued. It's returning whether the *last* call to > queue_rcu_work() resulted in queued work. > > There is no way the return value is meaningful that I can see, and > honestly, that means that the code in kvfree_rcu_barrier() looks > actively buggy, and at worst might be an endless loop > > Now, maybe there's some reason why the code works fine, but it looks > really really wrong. Please fix. > > The fix might be either a big comment about why it's ok, or making the > "queued" assignment be a '|=3D' instead, or perhaps breaking out of the > loop on the first successful queueing, or whatever. > > But not this "randomly return _one_ value of many of the queuing success"= . > Thank you for valuable feedback! Indeed it is hard to follow, even though it works correctly. I will add the comment and also break the loop on first queuing as you suggested! It does not make sense to loop further because following iterations are never successful thus never overwrite "queued" variable(it never reaches the queue_rcu_work() call). bool queued =3D false; ... for (i =3D 0; i < KFREE_N_BATCHES; i++) { if (need_offload_krc(krcp)) { queued =3D queue_rcu_work(system_wq, &krwp->rcu_wo= rk); ... return queued; if we queued, "if(need_offload_krc())" condition is never true anymore. Below refactoring makes it clear. I will send the patch to address it. diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index a60616e69b66..b1f883fcd918 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3607,11 +3607,12 @@ kvfree_rcu_queue_batch(struct kfree_rcu_cpu *krcp) } // One work is per one batch, so there are three - // "free channels", the batch can handle. It can - // be that the work is in the pending state when - // channels have been detached following by each - // other. + // "free channels", the batch can handle. Break + // the loop since it is done with this CPU thus + // queuing an RCU work is _always_ success here. queued =3D queue_rcu_work(system_unbound_wq, &krwp->rcu_work); + WARN_ON_ONCE(!queued); + break; } } Thanks! --=20 Uladzislau Rezki