From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E84ECAAD3 for ; Thu, 1 Sep 2022 12:17:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D5A88D0002; Thu, 1 Sep 2022 08:17:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3854C8D0001; Thu, 1 Sep 2022 08:17:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D5B8D0002; Thu, 1 Sep 2022 08:17:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 183AB8D0001 for ; Thu, 1 Sep 2022 08:17:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E751640261 for ; Thu, 1 Sep 2022 12:17:08 +0000 (UTC) X-FDA: 79863416136.28.C8CCA14 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 7BFF920032 for ; Thu, 1 Sep 2022 12:17:07 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id v4so16193661pgi.10 for ; Thu, 01 Sep 2022 05:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=xWg9vWseJ0vGCFN4/5PNMcvbHQf9T6lN5XKy27FC6ac=; b=IgpsmeVmKubge+xXzYFDFlQF06BsFao8lKDbEayczz0tTLfNRmCcJm3lk/xmNhxp7Z nFwkqMD7WaxHSsaHS26w05bgLYWY/BrMWFm0XawJ+4Yc1gWgi7LioAQRQzmf55EiTR5o ECQMIcwHdY15ue7kGAYmApQY1H/2Qz/aFyk8bA1TLrAgrXToxVruoFddRL3SjGY/j5th kx2HdElyBvUsW0CUFxDllqfNH5+6Mlk9dYq1NiwMEOCjKiyvLT9y9hC/b27BY/0Vg7I+ ctJu8dUXe7wIZ5JHq4uLYfV3BDECkR4pbVnIBGRsRuPkfYezm89MysKKssqJsGKYzurL h/Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=xWg9vWseJ0vGCFN4/5PNMcvbHQf9T6lN5XKy27FC6ac=; b=j5PA68Hcm+RYRKA+nYyH7HXTqKASDx2PchG2ofktmeeDN8uAbzCDBoRksjhtlRNoe0 xKGf3kQjgP5YiEzII1BZV6ADgakbz+IJzO80H6Q+YFdg4fwbyHSW+keUrA/kJjaO4o98 ixtYtp1gmzHudFRQ6Lv28nE0HhnWJi+dvF2jevVIHanrXBlpEYG9h5X1Jq/1XHYpB3dN Tmh4bdQjKYxH+qFPhJXXZzpCZN+MC6hv5J4g0j33EoBDk/ewwYY1iZPaIgRVwJothZdn t+jKauL6m7z8A7VV2TxSe5zEpjH8GVlOC9mx2V8aXihwKVoLYdp7ly+YawYxn7lMVxP5 IzjA== X-Gm-Message-State: ACgBeo3WE4xo1Bt1+n48xAtVOYduEWDS7KQyrJBwH0/Q9M8aO1BOxDp7 yEnwLJySRL8Mo8j01//ez0fenRywptn7beHd7sc= X-Google-Smtp-Source: AA6agR6TEK+tqlcnxtFCFr/6xyVnEZt6VEpgROats0J7Z0KAJHpJJaNEeQpk+RhjXcgdfWleJqb0IZugg4VAplsz5W4= X-Received: by 2002:a63:4142:0:b0:42b:5b22:f2fc with SMTP id o63-20020a634142000000b0042b5b22f2fcmr26808494pga.573.1662034626413; Thu, 01 Sep 2022 05:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20220831052734.3423079-1-song@kernel.org> <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org> In-Reply-To: From: Uladzislau Rezki Date: Thu, 1 Sep 2022 14:16:55 +0200 Message-ID: Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments To: Song Liu , Andrew Morton Cc: Linux-MM , open list , Song Liu , Baoquan He Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662034627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xWg9vWseJ0vGCFN4/5PNMcvbHQf9T6lN5XKy27FC6ac=; b=sdpd2xK0u0eYZRUdGeC8oKDBnAO6YFws8QQdYyKMqYiNUQ70acIacau6Z6UJjNiR4tMIzq oVEhwIjlUFo+sCGXc+tKDelrBWuQbtedN++o9Z/b38tzJp0mc/PAcd6S1LZ+/eXk3WpPJA gSb2IPsQIBNbsPagjM1tYSRb4UDikXs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IgpsmeVm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662034627; a=rsa-sha256; cv=none; b=29fIlrRkAV+Grl5UA8e7IgahdZ7vW53HC3VL/Hbo2vrOcacZ8izCciSe/BYbPzi4f2fjrz 5zV5+1Rwmtf6VFcBAsruDfr9Ibc/uI+X3RNKYQv9r9Fw50q4q+N0EpP1Wc1q8EajypQaho zszDPE79QaEpe5A5UvWrW+M4vQQ41nw= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IgpsmeVm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspamd-Queue-Id: 7BFF920032 X-Stat-Signature: sn9qw576w5nt74tbe864ep3gse97kg5t X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1662034627-584871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is only for debug purpose. Even without this patch, the debug path would work correctly. The difference is just only in whether roots are hardcoded or passed over function paramter. -- Uladzislau Rezki On Thu, Sep 1, 2022 at 2:47 AM Song Liu wrote: > > On Wed, Aug 31, 2022 at 4:01 PM Andrew Morton wrote: > > > > On Tue, 30 Aug 2022 22:27:34 -0700 Song Liu wrote: > > > > > find_vmap_lowest_match() is now able to handle different roots. Make > > > similar changes to find_vmap_lowest_match_check() and > > > find_vmap_lowest_linear_match() to handle different trees. > > > > What are the runtime effects of this change? > > The code is gated by DEBUG_AUGMENT_LOWEST_MATCH_CHECK. It > is only compiled when the developer enables it explicitly. Therefore, > there isn't > any runtime effect. > > Thanks, > Song -- Uladzislau Rezki