From: Sandeep Patil <psandeep.s@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org, Ohad Ben-Cohen <ohad@wizery.com>,
Daniel Walker <dwalker@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
Mel Gorman <mel@csn.ul.ie>, Michal Nazarewicz <mina86@mina86.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Jesse Barker <jesse.barker@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rob Clark <rob.clark@linaro.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Linaro-mm-sig] [PATCHv23 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks
Date: Thu, 8 Mar 2012 13:25:13 -0800 [thread overview]
Message-ID: <CA+K6fF5aN7Z3roKOzZe+a87ey4YcLd5Fr1U794wvb+8H3qP2+w@mail.gmail.com> (raw)
In-Reply-To: <1329929337-16648-13-git-send-email-m.szyprowski@samsung.com>
> +static int __reclaim_pages(struct zone *zone, gfp_t gfp_mask, int count)
> +{
> + /*
> + * Increase level of watermarks to force kswapd do his job
> + * to stabilise at new watermark level.
> + */
> + __update_cma_watermarks(zone, count);
> +
> + /* Obey watermarks as if the page was being allocated */
> + watermark = low_wmark_pages(zone) + count;
> + while (!zone_watermark_ok(zone, 0, watermark, 0, 0)) {
Wouldn't this reclaim (2 * count pages) above low wmark?
You are updating the low wmark first and then adding "count"
for the zone_watermark_ok() check as well ..
Sandeep
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-08 21:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 16:48 [PATCHv23 00/16] Contiguous Memory Allocator Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 01/16] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 02/16] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 03/16] mm: compaction: introduce map_pages() Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 04/16] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 05/16] mm: compaction: export some of the functions Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 06/16] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 07/16] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 08/16] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 09/16] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 10/16] mm: Serialize access to min_free_kbytes Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 11/16] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks Marek Szyprowski
2012-02-29 9:48 ` [Linaro-mm-sig] " Barry Song
2012-03-08 21:25 ` Sandeep Patil [this message]
2012-02-22 16:48 ` [PATCHv23 13/16] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-02-29 9:53 ` [Linaro-mm-sig] " Barry Song
2012-02-22 16:48 ` [PATCHv23 14/16] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 15/16] ARM: " Marek Szyprowski
2012-02-22 16:48 ` [PATCHv23 16/16] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2012-02-29 9:35 ` [Linaro-mm-sig] [PATCHv23 00/16] Contiguous Memory Allocator Barry Song
2012-02-29 11:43 ` Michal Nazarewicz
2012-02-29 13:34 ` Barry Song
2012-02-29 13:36 ` Michal Nazarewicz
2012-02-29 13:43 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+K6fF5aN7Z3roKOzZe+a87ey4YcLd5Fr1U794wvb+8H3qP2+w@mail.gmail.com \
--to=psandeep.s@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=ohad@wizery.com \
--cc=rob.clark@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox