From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F4DC2BA18 for ; Thu, 20 Jun 2024 21:01:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3D388D00E4; Thu, 20 Jun 2024 17:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4F78D00DB; Thu, 20 Jun 2024 17:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA768D00E4; Thu, 20 Jun 2024 17:01:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A98528D00DB for ; Thu, 20 Jun 2024 17:01:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54560C0618 for ; Thu, 20 Jun 2024 21:01:02 +0000 (UTC) X-FDA: 82252486764.12.F4DE49D Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 03D671C0028 for ; Thu, 20 Jun 2024 21:00:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=of8gV6mB; spf=pass (imf21.hostedemail.com: domain of rmoar@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=rmoar@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718917254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pF98VwdCcJqbDJTb4AUwn3sHBg8bzfdX8R18O7bVHHE=; b=HWNGnNANQAAlaWLGY3VBi9JMWNC1Yccc71e6vOcz3hGn06U/eGgKIuq8zr+yiOej3Yaan/ ElZApqcbnSuwYtVbBMUX1VynLnrxTclkblSN9trbg6MAAxriPHTcHCdJjKgGlJXq1djFWd hNVN3vNp4QNqEytvqCFH0PAsVMZgH+Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=of8gV6mB; spf=pass (imf21.hostedemail.com: domain of rmoar@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=rmoar@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718917254; a=rsa-sha256; cv=none; b=8f0SoCekWjaHjvilh4XAc/iJeV7zLRnzwRiEZnPW/yNGYvWV2HUxJTmmPG/t0x3gTfC/lw 5NYqysOxGXBItIewn339t/K8nT73HmJYZ9J9GThI1LLlBVk1hIm5CIFS1qkZisENqX8mev q/c/larJiqq8WDZqS/GnJZDNPvQChus= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-422f7c7af49so3245e9.0 for ; Thu, 20 Jun 2024 14:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718917257; x=1719522057; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pF98VwdCcJqbDJTb4AUwn3sHBg8bzfdX8R18O7bVHHE=; b=of8gV6mB+a9Yyg4tzFdcEg9ZKVpuchAC3A+09FvHBQ+/c9EVT7rhroUSzDMfN7kv0D er+7ayTDDufCEfXLz/QqABdNkSakzQUX1itxsDGujmYSoeVOGrMBU0xq8UGEsNw2f4pd gpR5AC2ukySLYX9Wvme/HxVrCMQJDdYXaC0WYoGXEMMyi8HBEpG9w7S8twlQAyuk+GG+ RwvAfluXYRqtcfyqTUUDMk4E4dLm4IzLGn2aDEMp3Y70Cg+91aWj0QS8LJYBExh47beV 7ASp6Ty171+FQPaOmKQdNfPFVYEsTNuJt3gFmS2sFnQTimysBzDFf0Nq+SbKbOKdof8f CVBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718917257; x=1719522057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pF98VwdCcJqbDJTb4AUwn3sHBg8bzfdX8R18O7bVHHE=; b=h6PRWwpRNHqJeJAeLX0Lf2Dh6265Q+lFlBaU9AkXoSS5AdEm02W0tVKtdPtOKmkJCD CjcyJ+0XW2xGyKvFRKst4g3rsSkietrCc8tYVJmKg4S3YeDEuZIrX4gg25BFBGsNMaHx Qjae1xW8VKMLWRCrJ+oW+CB6F8ixFAdrDEl9Ye3XuI9s+aVFWwusVI4l1jUL719Jekt2 C6Sx8KSzvRnxRLGXWcg8pi6kIl+c0yDGoMNRMwKU2twmcp8wnG/naLoalXK7LQSupQuf zV/ptk54cufdu2jEAOPmVzP2VbA3PMm2lePpFeHVKqynYkh/toKX16B0ec93KxmSO9A7 Ibgw== X-Forwarded-Encrypted: i=1; AJvYcCUP14tgpaZCchauVn1680v9FiQtcGr889FwEPxH4z2RBMXE3wN0ol3BQH+4Xm58v5yHhepm5uq/UcGIjY+Wz4V2bfs= X-Gm-Message-State: AOJu0YyFzsrSfFnrLv4Q9+xfZnoZE6MbHYSQiuVnK8iGx5Zoufwzb2Hz 6KEtn7IOSrmA1pIsJI2syRW5icOVkTgYFKIdpAgogkcP+XtzMQdRam9SSPbI96IAEVW2TsR2wFX QLM2pTcXf3+gaQdMC5ns4Wne+HpNubVzH7nZg X-Google-Smtp-Source: AGHT+IGEalrN8Y1clv35ZyNYg5HFsBwJ9BjVUYPVovMUPxvCwRYlIRA5gvDMxrAFpvWJZ0QCYZ6hS4Lq7p37QtNhHuY= X-Received: by 2002:a05:600c:1da7:b0:422:ff8d:5d25 with SMTP id 5b1f17b1804b1-42481da99bcmr23335e9.5.1718917257464; Thu, 20 Jun 2024 14:00:57 -0700 (PDT) MIME-Version: 1.0 References: <20240619202659.work.532-kees@kernel.org> In-Reply-To: <20240619202659.work.532-kees@kernel.org> From: Rae Moar Date: Thu, 20 Jun 2024 17:00:44 -0400 Message-ID: Subject: Re: [PATCH] kunit/usercopy: Add missing MODULE_DESCRIPTION() To: Kees Cook Cc: Shuah Khan , Jeff Johnson , Brendan Higgins , David Gow , "Gustavo A. R. Silva" , Andrew Morton , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 03D671C0028 X-Stat-Signature: bpd5nq53f64rx3sa5fmrkf997cnocg6k X-HE-Tag: 1718917258-20497 X-HE-Meta: U2FsdGVkX18ia7uYdIU38PYH+H/tzrCli5u82ya/c6n+eiJgAVKB8hZl5D2WLSxr1RqJc5QFLXGXF7PBnXm1J+1XG07W+iFw136OAnvFzUrpad2r5MS456FvQcgfpFI9LDoVkHRQbaviqjNf7XT4K3C9NIkyBVymYSga51NsqCmyYCk45L0Llm4k7JPF5a9kBtdZzjAR/1AXoA7G2eNihlP3EHWbspAytZfpBfBn9yBGZJ/QlryNn8jWVVzZAvDAQQx4gIf1Hhnt+hgBaw9abkk1tyJIF2/QvFrNsXvotyRW+f+/jC5/V6x2q1ajKO1WyORxlQ8G3yJJ70AUJJ4GFPz8PKA5Ju3xgDPG8ZM9+F1PhJlJop15zU/NUGCNjGrWgfNa/ZC1t15W4odWcO7l9iROeFDJGj+S0GnNg5jgpr4PBLsvELP6IQlGlcLeU3hj5VxX3+WQYiz2Ztulx8a76/zs2xTUZKs2+/fTnf7ibfjaOJgHiIlAWMFxku3BUi9M+j5+dUzvyW5q8nEaYCk1ukoMau3bs6Un0PpBFPf766dIR7esBNsWSg7O/21k/I7WavS7wwV4LGQ72unBXXTboqATijq1jc9CuyD8/r85aSlNEmvUqfWBnvDuUZujDV+LoMJe0dwd7EQIifhIpLyLKoNJ+yR/RkETv7Mm5tel67tNeBvTAiM33jtqp2/F9LvsP2XWbbk5sukB3Dt2p9Pa6HBjTZXxddJ6QK9nqTqtvHY5WFJlnWESZlUL3VNmWM88AUuRIQpOQINApCdg/REebGV1LJaatvHVoOEFezxKxNyolwoh1EVL0fm+fSqGd+Mj325lC1rP3sq3fOASv776UZbTFXEWkG/b037wH/BHc1nzOWyCr2MP1pejtIKGcelHDQ1c7Dr6r3Zrqh7OGPxS/QiqtCcyw7E6p6wVRweZ11M8bi/S0nyyRR9D3Z0i20UlbbWUJ61mMmG21TkVNRG P3v4zVz+ 3Dcg2WJIOhUZEKDY99c972840aBh/8r8rn4dVmds1WfXHgEAzQK9+SAdxLbeo+mF6DeCTiQPehPqzzxZGkUGIxfI3tGQAaKKCqWDHqZkwPefEMsHTT9arRX4CpURAYPkdwsmP6ImzEaZlGpfNf1a0ToUkrfx+WCaRsnf8bDJOgmwd6x5vDmgjpg9ErLRzQ2oX3h8qDhj8d7b886ftooenYlIyiZDfpa3WIP4GHZOFEsWsG5BIi2z6gTC5W4U9yhGiPh+lNIqNPPFdnZOhq1P+kHKy5Vap7jYnrqJQZk1ct/ZkN5rpGPNnt1D94fxLO557+dFCUW8oyLjL6ysy94IeZVICoGT+v3dcsIYNiX8K8X+DrB/QyMOr60ImKIupZyV2gPJhYrYh6q8KSpANeC6AkbfFiWRRIAgOkOfT6Y8q9/k+XxpyNnndA6wgNpBFZ/wpVHgxVFWK2aPgCJPOZkqFyK+8AHVo36Gfl2u0PH1NqdtP5gqekADCXCnB7JX2Fg2RUKfR04BNKQMQguzSlV6hwSBOWHo2918EOawG35Ej4B5QumjdZ9LyXItlaYXKr7DmA3vmMQ7TgdWJFFPRN8MvKdifzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.068973, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 4:27=E2=80=AFPM Kees Cook wrote: > > From: Jeff Johnson > > Fix warning seen with: > > $ make allmodconfig && make W=3D1 C=3D1 lib/usercopy_kunit.ko > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o > > Signed-off-by: Jeff Johnson > Signed-off-by: Kees Cook Hi! This looks good to me. Reviewed-by: Rae Moar Thanks! -Rae > --- > At Jeff's reminder, I've split this out of: > https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicin= c.com/ > since the file got renamed. > --- > Cc: Shuah Khan > Cc: Jeff Johnson > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Cc: "Gustavo A. R. Silva" > Cc: Andrew Morton > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Cc: linux-hardening@vger.kernel.org > Cc: linux-mm@kvack.org > --- > lib/usercopy_kunit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c > index e819561a540d..77fa00a13df7 100644 > --- a/lib/usercopy_kunit.c > +++ b/lib/usercopy_kunit.c > @@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite =3D { > > kunit_test_suites(&usercopy_test_suite); > MODULE_AUTHOR("Kees Cook "); > +MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastr= ucture"); > MODULE_LICENSE("GPL"); > -- > 2.34.1 >